You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/07/28 21:35:36 UTC
Review Request 72715: Set the readonly field in the CSI volume
manager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72715/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
This patch introduces a new `readonly` field in the CSI
`VolumeState` message and passes it through when publishing
volumes. This will allow us to set this field appropriately
when publishing pre-provisioned volumes.
Diffs
-----
src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
Diff: https://reviews.apache.org/r/72715/diff/1/
Testing
-------
Details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 72715: Set the readonly field in the CSI volume
manager.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72715/#review221404
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On 七月 29, 2020, 5:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72715/
> -----------------------------------------------------------
>
> (Updated 七月 29, 2020, 5:35 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a new `readonly` field in the CSI
> `VolumeState` message and passes it through when publishing
> volumes. This will allow us to set this field appropriately
> when publishing pre-provisioned volumes.
>
>
> Diffs
> -----
>
> src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
>
>
> Diff: https://reviews.apache.org/r/72715/diff/1/
>
>
> Testing
> -------
>
> Details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>