You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by lulf <gi...@git.apache.org> on 2017/02/03 10:32:23 UTC
[GitHub] qpid-dispatch pull request #142: DISPATCH-628: Multiple connections per auto...
GitHub user lulf opened a pull request:
https://github.com/apache/qpid-dispatch/pull/142
DISPATCH-628: Multiple connections per autoLink and linkRoute overwrites connection handle
This ensures that an autolink and linkroute can be bound to more than one
connection. The assert checking this is disabled in optimized builds and was
never triggered.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lulf/qpid-dispatch DISPATCH-628
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 49d95b767ca5ee8fc9d0dadb3951c799e4ec89ba
Author: Ulf Lilleengen <lu...@redhat.com>
Date: 2017-02-03T09:58:19Z
DISPATCH-628: Multiple connections per autoLink and linkRoute overwrites connection handle
This ensures that an autolink and linkroute can be bound to more than one
connection. The assert checking this is disabled in optimized builds and was
never triggered.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #142: DISPATCH-628: Multiple connections per auto...
Posted by lulf <gi...@git.apache.org>.
Github user lulf commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/142#discussion_r99380500
--- Diff: src/router_core/route_control.c ---
@@ -396,7 +408,18 @@ void qdr_route_connection_closed_CT(qdr_core_t *core, qdr_connection_t *conn)
al = DEQ_NEXT_N(REF, al);
}
- cid->open_connection = 0;
+ //
+ // Remove our own entry in the connection list
+ //
+ qdr_connection_ref_t * cref = DEQ_HEAD(cid->connection_refs);
+ while (cref) {
+ if (cref->conn == conn) {
+ DEQ_REMOVE(cid->connection_refs, cref);
--- End diff --
Agreed, I think I didn't know about that one. Just pushed an update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #142: DISPATCH-628: Multiple connections per auto...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #142: DISPATCH-628: Multiple connections per auto...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/142#discussion_r99370107
--- Diff: src/router_core/route_control.c ---
@@ -396,7 +408,18 @@ void qdr_route_connection_closed_CT(qdr_core_t *core, qdr_connection_t *conn)
al = DEQ_NEXT_N(REF, al);
}
- cid->open_connection = 0;
+ //
+ // Remove our own entry in the connection list
+ //
+ qdr_connection_ref_t * cref = DEQ_HEAD(cid->connection_refs);
+ while (cref) {
+ if (cref->conn == conn) {
+ DEQ_REMOVE(cid->connection_refs, cref);
--- End diff --
I believe this will leak one qdr_connection_ref_t each time it is run. Why did you not use qdr_del_connection_ref?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org