You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2019/03/20 15:03:00 UTC

[jira] [Commented] (OAK-8151) Let ACE.getPrincipal return principals obtained from PrincipalManager

    [ https://issues.apache.org/jira/browse/OAK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797248#comment-16797248 ] 

angela commented on OAK-8151:
-----------------------------

[~stillalex], proposed patch attached.

> Let ACE.getPrincipal return principals obtained from PrincipalManager
> ---------------------------------------------------------------------
>
>                 Key: OAK-8151
>                 URL: https://issues.apache.org/jira/browse/OAK-8151
>             Project: Jackrabbit Oak
>          Issue Type: Wish
>          Components: core, security
>            Reporter: angela
>            Priority: Minor
>         Attachments: OAK-8151.patch
>
>
> [~stillalex], while {{AccessControlEntry.getPrincipal}} does not mandate the that principal is actually obtained from {{PrincipalManager}} it turned out that some UI code actually relies on that implementation detail. 
> we could still reduce the number of queries resulting from looking up principals by name, by making sure we don't read the same principal multiple times, while computing the entries for a given access control list. that might be somewhat of a compromise to reduce the number of lookups while returning the same principals as we did before optimizing the lookup in OAK-7880.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)