[GitHub] [iceberg] rdblue commented on a diff in pull request #6091: Spark-3.3: Handle statistics file clean up from expireSnapshots action/procedure

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1129758863


##########
core/src/main/java/org/apache/iceberg/actions/BaseExpireSnapshotsActionResult.java:
##########
@@ -46,6 +48,22 @@ public BaseExpireSnapshotsActionResult(
     this.deletedEqDeleteFilesCount = deletedEqDeleteFilesCount;
     this.deletedManifestsCount = deletedManifestsCount;
     this.deletedManifestListsCount = deletedManifestListsCount;
+    this.deletedStatisticsFilesCount = 0;
+  }
+
+  public BaseExpireSnapshotsActionResult(

Review Comment:
   Given that we have to continue creating new constructors, should we deprecate the old ones and no longer make the new ones public? If there is an interface, then there's no need for this class or its constructors to be public.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org