You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Alex Karasulu <ak...@apache.org> on 2011/01/25 05:54:58 UTC
[Codec] Refactoring status
Although I was going to apply the encoding decorator pattern last
(STEP 5 in previous status) I started discussing the approach with
Emmanuel last night and that kicked off the step ahead of the others.
And it's not so bad to do this first.
Now I have a few issues. First I am running out of time, need to crash
but could not fix two failing test cases:
Failed tests:
testDecodeDelResponseSuccessWithControls(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
testDecodeDelResponseSuccess(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
This regression appeared after creation and check in of the
LdapResultDecorator. Emmanuel if you could take a look at this for me
tomorrow morning this would be great.
Now the other bigger issue. There's no way I could finish the
SearchRequestImpl decoupling. I created the decoder and applied it. It
seems to be working just fine but the problem is SearchRequestImpl has
several codec dependencies. Seems there's a whole Filter subsystem for
the codec doing what the ExprNode does for LDAP filter creation in the
model. I'm hoping Emmanuel you can lend a hand here since you're most
familiar with this code.
If we can get this knocked out then I think we can bud ldap-model out
right after into it's own maven module as an OSGi bundle.
Thanks,
--
Alex Karasulu
My Blog :: http://www.jroller.com/akarasulu/
Apache Directory Server :: http://directory.apache.org
Apache MINA :: http://mina.apache.org
To set up a meeting with me: http://tungle.me/AlexKarasulu
Re: [Codec] Refactoring status
Posted by Alex Karasulu <ak...@apache.org>.
Thanks so much for fixing this stuff. It's good to be moving all together again.
Regards,
Alex
On Tue, Jan 25, 2011 at 10:11 AM, Emmanuel Lecharny <el...@gmail.com> wrote:
> On 1/25/11 5:54 AM, Alex Karasulu wrote:
>>
>> Although I was going to apply the encoding decorator pattern last
>> (STEP 5 in previous status) I started discussing the approach with
>> Emmanuel last night and that kicked off the step ahead of the others.
>> And it's not so bad to do this first.
>>
>> Now I have a few issues. First I am running out of time, need to crash
>> but could not fix two failing test cases:
>>
>> Failed tests:
>>
>> testDecodeDelResponseSuccessWithControls(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
>>
>> testDecodeDelResponseSuccess(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
>>
>> This regression appeared after creation and check in of the
>> LdapResultDecorator. Emmanuel if you could take a look at this for me
>> tomorrow morning this would be great.
>
> Sure will do.
>>
>> Now the other bigger issue. There's no way I could finish the
>> SearchRequestImpl decoupling. I created the decoder and applied it. It
>> seems to be working just fine but the problem is SearchRequestImpl has
>> several codec dependencies. Seems there's a whole Filter subsystem for
>> the codec doing what the ExprNode does for LDAP filter creation in the
>> model. I'm hoping Emmanuel you can lend a hand here since you're most
>> familiar with this code.
>
> Will check that this morning.
>>
>> If we can get this knocked out then I think we can bud ldap-model out
>> right after into it's own maven module as an OSGi bundle.
>
> Great ! We are really moving in the right direction. The good job you have
> done so far is the completion of something we started last september, and
> it's a good thing you just started it again with a fresh mind, Alex. Thank
> you for that !
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>
--
Alex Karasulu
My Blog :: http://www.jroller.com/akarasulu/
Apache Directory Server :: http://directory.apache.org
Apache MINA :: http://mina.apache.org
To set up a meeting with me: http://tungle.me/AlexKarasulu
Re: [Codec] Refactoring status
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 1/25/11 5:54 AM, Alex Karasulu wrote:
> Although I was going to apply the encoding decorator pattern last
> (STEP 5 in previous status) I started discussing the approach with
> Emmanuel last night and that kicked off the step ahead of the others.
> And it's not so bad to do this first.
>
> Now I have a few issues. First I am running out of time, need to crash
> but could not fix two failing test cases:
>
> Failed tests:
> testDecodeDelResponseSuccessWithControls(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
> testDecodeDelResponseSuccess(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
>
> This regression appeared after creation and check in of the
> LdapResultDecorator. Emmanuel if you could take a look at this for me
> tomorrow morning this would be great.
Sure will do.
> Now the other bigger issue. There's no way I could finish the
> SearchRequestImpl decoupling. I created the decoder and applied it. It
> seems to be working just fine but the problem is SearchRequestImpl has
> several codec dependencies. Seems there's a whole Filter subsystem for
> the codec doing what the ExprNode does for LDAP filter creation in the
> model. I'm hoping Emmanuel you can lend a hand here since you're most
> familiar with this code.
Will check that this morning.
> If we can get this knocked out then I think we can bud ldap-model out
> right after into it's own maven module as an OSGi bundle.
Great ! We are really moving in the right direction. The good job you
have done so far is the completion of something we started last
september, and it's a good thing you just started it again with a fresh
mind, Alex. Thank you for that !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [Codec] Refactoring status
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 1/25/11 5:54 AM, Alex Karasulu wrote:
> Although I was going to apply the encoding decorator pattern last
> (STEP 5 in previous status) I started discussing the approach with
> Emmanuel last night and that kicked off the step ahead of the others.
> And it's not so bad to do this first.
>
> Now I have a few issues. First I am running out of time, need to crash
> but could not fix two failing test cases:
>
> Failed tests:
> testDecodeDelResponseSuccessWithControls(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
> testDecodeDelResponseSuccess(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
This is just a pb with the LdapResult decorator which is created twice,
one in the computeLength (and this is correct) and the second time in
the encode() method, and of course, it does not contain any information,
so the message is not correctlygenerated.
it's easy to fix, will do it after lunch.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com