You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Erwin Dondorp (Jira)" <ji...@apache.org> on 2022/01/21 10:26:00 UTC
[jira] [Updated] (ARTEMIS-3653) BrokerDiagram should highlight the (real) current broker
[ https://issues.apache.org/jira/browse/ARTEMIS-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwin Dondorp updated ARTEMIS-3653:
-----------------------------------
Description:
When viewing the broker diagram with up to one or two master nodes (and optionally a slave node for each) then it is unclear which node is the current node.
When there are 3 or more master nodes, the connections between the nodes provide a clue (as the one with multiple connections is from the current pair). but still it is unclear whether the masternode or the slavenode of the current pair is the current node.
The code shows that an attempt was made to highlight the current node. actually always the master node from the current pair is highlighted. since the styling is the same, that is not noticeable.
The (upcoming) PR for this change will introduce proper highlighting of the current node. Simultaneously, the previous implementation is fixed.
The implementation details:
* The node-type "ThisBroker" is split into "ThisMasterBroker" and "ThisSlaveBroker"
* "ThisMasterBroker" has the same style as "MasterBroker", but just with a black border
* "ThisSlaveBroker" has the same style as "SlaveBroker", but just with a black border
was:
When viewing the broker diagram with up to one or two master nodes (and optionally a slave node for each) then it is unclear which node is the current node.
When there are 3 or more master nodes, the connections between the nodes provide a clue (as the one with multiple connections is from the current pair). but still it is unclear whether the masternode or the slavenode of the current pair is the current node.
The code shows that an attempt was made to highlight the current node. actually always the master node from the current pair is highlighted. since the styling is the same, that is not noticeable.
The (upcoming) PR for this change will introduce proper highlighting of the current node. Simultaneously, the previous implementation is fixed.
> BrokerDiagram should highlight the (real) current broker
> --------------------------------------------------------
>
> Key: ARTEMIS-3653
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3653
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: 2.20.0
> Reporter: Erwin Dondorp
> Priority: Minor
>
> When viewing the broker diagram with up to one or two master nodes (and optionally a slave node for each) then it is unclear which node is the current node.
> When there are 3 or more master nodes, the connections between the nodes provide a clue (as the one with multiple connections is from the current pair). but still it is unclear whether the masternode or the slavenode of the current pair is the current node.
> The code shows that an attempt was made to highlight the current node. actually always the master node from the current pair is highlighted. since the styling is the same, that is not noticeable.
> The (upcoming) PR for this change will introduce proper highlighting of the current node. Simultaneously, the previous implementation is fixed.
> The implementation details:
> * The node-type "ThisBroker" is split into "ThisMasterBroker" and "ThisSlaveBroker"
> * "ThisMasterBroker" has the same style as "MasterBroker", but just with a black border
> * "ThisSlaveBroker" has the same style as "SlaveBroker", but just with a black border
--
This message was sent by Atlassian Jira
(v8.20.1#820001)