You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/11 09:39:16 UTC
[GitHub] [dolphinscheduler] pandong2011 opened a new pull request, #12310: [fix#12257][Data Quality] Fix no main class set in JAR
pandong2011 opened a new pull request, #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
close 12257
## Brief change log
## Verify this pull request
Manually verified the change by testing locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310#issuecomment-1366478622
@pandong2011 can you test latest code? it should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310#issuecomment-1382677045
Close by #13360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310#issuecomment-1328497786
Hi @pandong2011 are this issue in version 3.0.x or version 3.1.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] taizilongxu commented on pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
taizilongxu commented on PR #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310#issuecomment-1274469549
Quick fix:
1. find ./ -name 'dolphinscheduler-data-quality-*'
2. and open `vim dolphinscheduler-data-quality-3.1.0.jar`
3. edit META-INF/MANIFEST.MF
4. add line: Main-Class: org.apache.dolphinscheduler.data.quality.DataQualityApplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] taizilongxu commented on pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
taizilongxu commented on PR #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310#issuecomment-1274419158
How about set main class in maven build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] pandong2011 commented on pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
pandong2011 commented on PR #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310#issuecomment-1274632708
> Quick fix:
>
> 1. find ./ -name 'dolphinscheduler-data-quality-*'
> 2. and open `vim dolphinscheduler-data-quality-3.1.0.jar`
> 3. edit META-INF/MANIFEST.MF
> 4. add line: Main-Class: org.apache.dolphinscheduler.data.quality.DataQualityApplication
I don't recommend doing this, because if you rebuild, you have to change this file every time. If you want to use maven, I recommend overwriting shade or jar plug-ins in the pom.xml and adding the corresponding configuration, but this implementation is not readable or maintainable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] taizilongxu commented on pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
taizilongxu commented on PR #12310:
URL: https://github.com/apache/dolphinscheduler/pull/12310#issuecomment-1276028089
>
Yes, this is not a good idea. Just use in case the release not public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun closed pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed pull request #12310: [fix#12257][Data Quality] Fix no main class set in JAR
URL: https://github.com/apache/dolphinscheduler/pull/12310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org