You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/05/29 14:32:27 UTC
[GitHub] [camel] essobedo opened a new pull request, #10227: CAMEL-19399: camel-cxf - Don't add entry in Converter cache on error
essobedo opened a new pull request, #10227:
URL: https://github.com/apache/camel/pull/10227
Fixes https://issues.apache.org/jira/browse/CAMEL-19399
## Motivation
If an error occurs while converting a value thanks to the CxfPayloadConverter, the value null is returned to let other fallback converters to try but if there are no such fallback converters, the cache of converters will keep the information that no converter exists which is not incorrect.
## Modifications
* Returns `MISS_VALUE` instead of `null` in case of an error to ensure that the result won't be stored in the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10227: CAMEL-19399: camel-cxf - Don't add entry in Converter cache on error
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10227:
URL: https://github.com/apache/camel/pull/10227#issuecomment-1567216587
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10227: CAMEL-19399: camel-cxf - Don't add entry in Converter cache on error
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10227:
URL: https://github.com/apache/camel/pull/10227#issuecomment-1567267444
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo merged pull request #10227: CAMEL-19399: camel-cxf - Don't add entry in Converter cache on error
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #10227:
URL: https://github.com/apache/camel/pull/10227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10227: CAMEL-19399: camel-cxf - Don't add entry in Converter cache on error
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10227:
URL: https://github.com/apache/camel/pull/10227#issuecomment-1567218425
@ffang Would you mind checking on your side if your use case (https://issues.apache.org/jira/browse/CAMEL-19160) is not broken with this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org