You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/04/27 06:50:07 UTC
Re: Review Request 33531: Made master/slave usage flags newline
behaviour consistent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33531/
-----------------------------------------------------------
(Updated April 27, 2015, 4:50 a.m.)
Review request for mesos, Alexander Rojas and Till Toenshoff.
Summary (updated)
-----------------
Made master/slave usage flags newline behaviour consistent.
Bugs: MESOS-2496
https://issues.apache.org/jira/browse/MESOS-2496
Repository: mesos
Description (updated)
-------
see summary
Diffs
-----
src/logging/flags.cpp c0274424b93094c2f2004663505ee9c71dafd97e
src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
Diff: https://reviews.apache.org/r/33531/diff/
Testing
-------
make check + visual inspection of master/slave --help
Thanks,
Joerg Schad
Re: Review Request 33531: Made master/slave usage flags newline
behaviour consistent.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33531/#review81660
-----------------------------------------------------------
LGTM.
- Michael Park
On April 27, 2015, 4:50 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33531/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 4:50 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Till Toenshoff.
>
>
> Bugs: MESOS-2496
> https://issues.apache.org/jira/browse/MESOS-2496
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/logging/flags.cpp c0274424b93094c2f2004663505ee9c71dafd97e
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
>
> Diff: https://reviews.apache.org/r/33531/diff/
>
>
> Testing
> -------
>
> make check + visual inspection of master/slave --help
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 33531: Made master/slave usage flags newline
behaviour consistent.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33531/#review81662
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33531]
All tests passed.
- Mesos ReviewBot
On April 27, 2015, 4:50 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33531/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 4:50 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Till Toenshoff.
>
>
> Bugs: MESOS-2496
> https://issues.apache.org/jira/browse/MESOS-2496
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/logging/flags.cpp c0274424b93094c2f2004663505ee9c71dafd97e
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
>
> Diff: https://reviews.apache.org/r/33531/diff/
>
>
> Testing
> -------
>
> make check + visual inspection of master/slave --help
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 33531: Made master/slave usage flags newline
behaviour consistent.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33531/#review82416
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 27, 2015, 6:50 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33531/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 6:50 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Till Toenshoff.
>
>
> Bugs: MESOS-2496
> https://issues.apache.org/jira/browse/MESOS-2496
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/logging/flags.cpp c0274424b93094c2f2004663505ee9c71dafd97e
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
>
> Diff: https://reviews.apache.org/r/33531/diff/
>
>
> Testing
> -------
>
> make check + visual inspection of master/slave --help
>
>
> Thanks,
>
> Joerg Schad
>
>