[GitHub] [incubator-druid] kamaci commented on a change in pull request #6943: InterruptedExceptions should never be ignored in the code.

[GitBox <gi...@apache.org>]

kamaci commented on a change in pull request #6943: InterruptedExceptions should never be ignored in the code.
URL: https://github.com/apache/incubator-druid/pull/6943#discussion_r270672564
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/http/client/pool/ResourcePool.java
 ##########
 @@ -186,7 +186,7 @@ V get()
             this.wait();
           }
           catch (InterruptedException e) {
-            Thread.interrupted();
 
 Review comment:
   I agree! One can call `Thread.interrupted()` within an `if` check or assign it to a variable. Should we prohibit to assigning a variable too or not?
   
       <module name="Regexp">
         <property name="format" value='Thread.interrupted();'/>
         <property name="illegalPattern" value="true"/>
         <property name="message" value="Thread.interrupted(); shouldn't be used individually"/>
       </module>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org