You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 05:09:47 UTC
[GitHub] [flink] Aitozi commented on a change in pull request #8479:
[FLINK-11193][State Backends]Use user passed configuration overriding
default configuration loading from file
Aitozi commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file
URL: https://github.com/apache/flink/pull/8479#discussion_r286315022
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -295,6 +297,7 @@ public RocksDBStateBackend(AbstractStateBackend checkpointStreamBackend, boolean
* @param classLoader The class loader.
*/
private RocksDBStateBackend(RocksDBStateBackend original, Configuration config, ClassLoader classLoader) {
+ this.configuration = config;
Review comment:
Thanks @klion26 for your review. I'm not sure whether i quite get you meaning. But IMO this construct is only for creating a re-configured copy of the original state backend. So the configure passed in will be used first ? And also should keep this configure to a member field to reuse it to config the statebackend loaded from `StateBackendLoader#fromApplicationOrConfigOrDefault`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services