You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 12:31:00 UTC
[GitHub] [arrow] AlenkaF opened a new pull request, #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
AlenkaF opened a new pull request, #14656:
URL: https://github.com/apache/arrow/pull/14656
This PR adds code to `_run_cmake` to always copy PyArrow C++ header files to `pyarrow/iclude`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1029176687
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
But so about @kou's original comment, I think doing `os.path.dirname(source)` also works because if `source` is already a directory, `dirname` gives the parent directory.
Now personally I find `..` more explicit to read that it goes one level up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1323272153
@github-actions crossbow submit -g python -g conda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1317584531
@github-actions crossbow submit -g python -g conda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1029174852
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
For me it seems to work also with a ".." in it:
```
In [9]: os.path.exists("/home/joris/scipy/repos/arrow/python/pyarrow/tests/../include/arrow/python/")
Out[9]: True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1029176951
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
```suggestion
pyarrow_dir = pjoin(source, '..')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1317253051
Revision: d5f953f9c4b9a256de9876057fe285a134acc24d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1c3aa4b08e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1c3aa4b08e)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/tree/actions-1c3aa4b08e-github-wheel-macos-big-sur-cp310-arm64)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480980005/jobs/5821476347)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480981661/jobs/5821479677)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480977825/jobs/5821471305)|
|wheel-macos-mojave-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480975488/jobs/5821465580)|
|wheel-macos-mojave-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480978283/jobs/5821472518)|
|wheel-macos-mojave-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480984260/jobs/5821485864)|
|wheel-macos-mojave-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480979425/jobs/5821475079)|
|wheel-macos-mojave-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480976099/jobs/5821466938)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480983106/jobs/5821483337)|
|wheel-manylinux2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/runs/9529476382)|
|wheel-manylinux2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480982186/jobs/5821480960)|
|wheel-manylinux2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/runs/9529446212)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480980714/jobs/5821477715)|
|wheel-manylinux2014-cp37-arm64|[](https://github.com/ursacomputing/crossbow/runs/9529489549)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480986345/jobs/5821490090)|
|wheel-manylinux2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/runs/9529458145)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480978764/jobs/5821473602)|
|wheel-manylinux2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/runs/9529480039)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480977416/jobs/5821470468)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480973424/jobs/5821461660)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480974708/jobs/5821463987)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480985203/jobs/5821487595)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3480976686/jobs/5821468198)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
kou merged PR #14656:
URL: https://github.com/apache/arrow/pull/14656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1317592134
Revision: d5f953f9c4b9a256de9876057fe285a134acc24d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9eb5a3c4ca](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9eb5a3c4ca)
|Task|Status|
|----|------|
|conda-clean|[](https://github.com/ursacomputing/crossbow/runs/9534537370)|
|conda-linux-gcc-py310-arm64|[](https://github.com/ursacomputing/crossbow/runs/9534559098)|
|conda-linux-gcc-py310-cpu|[](https://github.com/ursacomputing/crossbow/runs/9534575294)|
|conda-linux-gcc-py310-cuda|[](https://github.com/ursacomputing/crossbow/runs/9534527233)|
|conda-linux-gcc-py310-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9534567238)|
|conda-linux-gcc-py37-arm64|[](https://github.com/ursacomputing/crossbow/runs/9534571191)|
|conda-linux-gcc-py37-cpu-r40|[](https://github.com/ursacomputing/crossbow/runs/9534545418)|
|conda-linux-gcc-py37-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/9534576119)|
|conda-linux-gcc-py37-cuda|[](https://github.com/ursacomputing/crossbow/runs/9534548458)|
|conda-linux-gcc-py37-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9534562310)|
|conda-linux-gcc-py38-arm64|[](https://github.com/ursacomputing/crossbow/runs/9534547376)|
|conda-linux-gcc-py38-cpu|[](https://github.com/ursacomputing/crossbow/runs/9534554849)|
|conda-linux-gcc-py38-cuda|[](https://github.com/ursacomputing/crossbow/runs/9534582270)|
|conda-linux-gcc-py38-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9534584372)|
|conda-linux-gcc-py39-arm64|[](https://github.com/ursacomputing/crossbow/runs/9534581356)|
|conda-linux-gcc-py39-cpu|[](https://github.com/ursacomputing/crossbow/runs/9534572369)|
|conda-linux-gcc-py39-cuda|[](https://github.com/ursacomputing/crossbow/runs/9534576681)|
|conda-linux-gcc-py39-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9534586827)|
|conda-osx-arm64-clang-py310|[](https://github.com/ursacomputing/crossbow/runs/9534552353)|
|conda-osx-arm64-clang-py38|[](https://github.com/ursacomputing/crossbow/runs/9534590894)|
|conda-osx-arm64-clang-py39|[](https://github.com/ursacomputing/crossbow/runs/9534558635)|
|conda-osx-clang-py310|[](https://github.com/ursacomputing/crossbow/runs/9534528902)|
|conda-osx-clang-py37-r40|[](https://github.com/ursacomputing/crossbow/runs/9534556166)|
|conda-osx-clang-py37-r41|[](https://github.com/ursacomputing/crossbow/runs/9534569960)|
|conda-osx-clang-py38|[](https://github.com/ursacomputing/crossbow/runs/9534528126)|
|conda-osx-clang-py39|[](https://github.com/ursacomputing/crossbow/runs/9534565951)|
|conda-win-vs2019-py310|[](https://github.com/ursacomputing/crossbow/runs/9534553499)|
|conda-win-vs2019-py37-r40|[](https://github.com/ursacomputing/crossbow/runs/9534586236)|
|conda-win-vs2019-py37-r41|[](https://github.com/ursacomputing/crossbow/runs/9534587394)|
|conda-win-vs2019-py38|[](https://github.com/ursacomputing/crossbow/runs/9534568734)|
|conda-win-vs2019-py39|[](https://github.com/ursacomputing/crossbow/runs/9534563750)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/3482642127/jobs/5825197176)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/3482651299/jobs/5825218901)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions/runs/3482653153/jobs/5825222925)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/3482653851/jobs/5825224765)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/3482641344/jobs/5825195307)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions/runs/3482637846/jobs/5825187750)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/3482656448/jobs/5825230144)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions/runs/3482638995/jobs/5825189540)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/3482647632/jobs/5825210085)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/3482652762/jobs/5825222066)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/3482644431/jobs/5825202478)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/3482654634/jobs/5825226400)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions/runs/3482642926/jobs/5825198877)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/3482641829/jobs/5825196338)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/3482656870/jobs/5825231179)|
|test-conda-python-3.9-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/3482647216/jobs/5825209199)|
|test-conda-python-3.9-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/3482655204/jobs/5825227410)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/3482640515/jobs/5825193382)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/3482657511/jobs/5825232890)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/9534580020)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/9534549470)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/9534564764)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1029036517
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
Sorry... I'm not sure why `os.path.abspath()` is needed for it.
Could you show the followings in your environment?
* The `source` value
* `ls -lah ${source}` (`${source}` is the `source` value)
* The `pyarrow_dir` value
* `ls -lah ${pyarrow_dir}` (`${pyarrow_dir}` is the `pyarrow_dir` value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1317245313
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1326768422
Benchmark runs are scheduled for baseline = 59f99d2ca7c710c64e89b14eabebf49eeeb6d319 and contender = 1e9eb6158796b78bf710079c9aac848db7a0fe2c. 1e9eb6158796b78bf710079c9aac848db7a0fe2c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f780c0ef1440400e8d37f6d5c02e921d...8ab5dddf2f3546fabe1e3b5185e0aa32/)
[Finished :arrow_down:0.34% :arrow_up:0.54%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/93b4f7f4eca447a4b4b90e00b342d4d0...29693f71de214fca86f00fbbe0ae148d/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9cd34620ed2e455c944256cc95b30b4e...4691c1df72b84093b50b9617c79ae558/)
[Finished :arrow_down:0.14% :arrow_up:0.35%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dffd7395ab304c919dde50a1db91f74b...2b70a55f0f734a42b7f839047fa599fc/)
Buildkite builds:
[Finished] [`1e9eb615` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1913)
[Finished] [`1e9eb615` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1935)
[Finished] [`1e9eb615` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1904)
[Finished] [`1e9eb615` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1927)
[Finished] [`59f99d2c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1912)
[Finished] [`59f99d2c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1934)
[Finished] [`59f99d2c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1903)
[Finished] [`59f99d2c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1926)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1323278248
Revision: acf87540fe6e1597549275f784401206cb747dd3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d4595c1625](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d4595c1625)
|Task|Status|
|----|------|
|conda-clean|[](https://github.com/ursacomputing/crossbow/tree/actions-d4595c1625-azure-conda-clean)|
|conda-linux-gcc-py310-arm64|[](https://github.com/ursacomputing/crossbow/runs/9635456638)|
|conda-linux-gcc-py310-cpu|[](https://github.com/ursacomputing/crossbow/runs/9635440880)|
|conda-linux-gcc-py310-cuda|[](https://github.com/ursacomputing/crossbow/runs/9635459744)|
|conda-linux-gcc-py310-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9635431360)|
|conda-linux-gcc-py37-arm64|[](https://github.com/ursacomputing/crossbow/runs/9635446774)|
|conda-linux-gcc-py37-cpu-r40|[](https://github.com/ursacomputing/crossbow/runs/9635445797)|
|conda-linux-gcc-py37-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/9635471075)|
|conda-linux-gcc-py37-cuda|[](https://github.com/ursacomputing/crossbow/runs/9635461803)|
|conda-linux-gcc-py37-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9635475348)|
|conda-linux-gcc-py38-arm64|[](https://github.com/ursacomputing/crossbow/runs/9635427507)|
|conda-linux-gcc-py38-cpu|[](https://github.com/ursacomputing/crossbow/runs/9635476009)|
|conda-linux-gcc-py38-cuda|[](https://github.com/ursacomputing/crossbow/runs/9635451625)|
|conda-linux-gcc-py38-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9635481983)|
|conda-linux-gcc-py39-arm64|[](https://github.com/ursacomputing/crossbow/runs/9635448828)|
|conda-linux-gcc-py39-cpu|[](https://github.com/ursacomputing/crossbow/runs/9635466017)|
|conda-linux-gcc-py39-cuda|[](https://github.com/ursacomputing/crossbow/runs/9635460567)|
|conda-linux-gcc-py39-ppc64le|[](https://github.com/ursacomputing/crossbow/runs/9635478366)|
|conda-osx-arm64-clang-py310|[](https://github.com/ursacomputing/crossbow/runs/9635472143)|
|conda-osx-arm64-clang-py38|[](https://github.com/ursacomputing/crossbow/runs/9635432784)|
|conda-osx-arm64-clang-py39|[](https://github.com/ursacomputing/crossbow/runs/9635468817)|
|conda-osx-clang-py310|[](https://github.com/ursacomputing/crossbow/runs/9635480726)|
|conda-osx-clang-py37-r40|[](https://github.com/ursacomputing/crossbow/runs/9635484082)|
|conda-osx-clang-py37-r41|[](https://github.com/ursacomputing/crossbow/runs/9635479846)|
|conda-osx-clang-py38|[](https://github.com/ursacomputing/crossbow/runs/9635463795)|
|conda-osx-clang-py39|[](https://github.com/ursacomputing/crossbow/runs/9635485094)|
|conda-win-vs2019-py310|[](https://github.com/ursacomputing/crossbow/runs/9635477204)|
|conda-win-vs2019-py37-r40|[](https://github.com/ursacomputing/crossbow/runs/9635428832)|
|conda-win-vs2019-py37-r41|[](https://github.com/ursacomputing/crossbow/runs/9635436176)|
|conda-win-vs2019-py38|[](https://github.com/ursacomputing/crossbow/runs/9635444420)|
|conda-win-vs2019-py39|[](https://github.com/ursacomputing/crossbow/runs/9635473999)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/3521550909/jobs/5903520525)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/3521566352/jobs/5903552898)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions/runs/3521549571/jobs/5903517520)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/3521551662/jobs/5903522782)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/3521549837/jobs/5903518306)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions/runs/3521563171/jobs/5903546574)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/3521559300/jobs/5903538566)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions/runs/3521561451/jobs/5903542673)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/3521555196/jobs/5903529828)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/3521557320/jobs/5903533812)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/3521548156/jobs/5903514390)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/3521556870/jobs/5903532886)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions/runs/3521546619/jobs/5903511461)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/3521555826/jobs/5903530873)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/3521562532/jobs/5903545071)|
|test-conda-python-3.9-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/3521554856/jobs/5903528954)|
|test-conda-python-3.9-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/3521549320/jobs/5903516937)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/3521548655/jobs/5903515391)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/3521554072/jobs/5903526895)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/9635448016)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/9635462473)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/9635439898)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1028968169
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
`os.path.dirname(source)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1024442125
##########
python/setup.py:
##########
@@ -436,19 +436,23 @@ def copy_libs(dir):
else:
build_prefix = self.build_type
+ pyarrow_include = pjoin(build_lib, 'pyarrow', 'include')
+ # Move Arrow C++ headers to pyarrow/include
if self.bundle_arrow_cpp or self.bundle_arrow_cpp_headers:
arrow_cpp_include = pjoin(build_prefix, 'include')
print('Bundling includes: ' + arrow_cpp_include)
- pyarrow_include = pjoin(build_lib, 'pyarrow', 'include')
if os.path.exists(pyarrow_include):
shutil.rmtree(pyarrow_include)
shutil.move(arrow_cpp_include, pyarrow_include)
- # pyarrow/include file is first deleted in the previous step
- # so we need to add the PyArrow C++ include folder again
- pyarrow_cpp_include = pjoin(pyarrow_cpp_home, 'include')
- shutil.move(pjoin(pyarrow_cpp_include, 'arrow', 'python'),
- pjoin(pyarrow_include, 'arrow', 'python'))
+ # Move PyArrow headers to pyarrow/include
+ pyarrow_cpp_include = pjoin(pyarrow_cpp_home, 'include')
+ print('Moving PyArrow C++ includes: ' +
+ pjoin(pyarrow_include, 'arrow', 'python'))
+ if os.path.exists(pjoin(pyarrow_include, 'arrow', 'python')):
+ shutil.rmtree(pjoin(pyarrow_include, 'arrow', 'python'))
+ shutil.move(pjoin(pyarrow_cpp_include, 'arrow', 'python'),
+ pjoin(pyarrow_include, 'arrow', 'python'))
Review Comment:
Can we define a variable for `pjoin(pyarrow_include, 'arrow', 'python')` because it's used multiple times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1316946079
https://issues.apache.org/jira/browse/ARROW-18340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1023960868
##########
python/setup.py:
##########
@@ -436,19 +436,28 @@ def copy_libs(dir):
else:
build_prefix = self.build_type
+ # Copy PyArrow headers to pyarrow/include
Review Comment:
🤦♀️ Yes, of course =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1028999045
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
I need to go from `test` folder to the parent `pyarrow` folder to test if the `include` folder is present there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1029188633
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
Ah, now I see Joris you already made a suggestion. Will commit that 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1029187946
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
Oh, sorry for my confusion.
Can change to `pyarrow_dir = os.path.dirname(source)`, @kou do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1316946143
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1023937605
##########
python/setup.py:
##########
@@ -436,19 +436,28 @@ def copy_libs(dir):
else:
build_prefix = self.build_type
+ # Copy PyArrow headers to pyarrow/include
Review Comment:
Could we also do this after the `if self.bundle_arrow_cpp or self.bundle_arrow_cpp_headers:`, so we don't have to repeat it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14656:
URL: https://github.com/apache/arrow/pull/14656#issuecomment-1317609109
Can we add a test to detect this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #14656: ARROW-18340: [Python] PyArrow C++ header files no longer always included in installed pyarrow
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #14656:
URL: https://github.com/apache/arrow/pull/14656#discussion_r1029161905
##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -31,3 +34,17 @@ def wrapper(case=case):
inject_cpp_tests(globals())
+
+
+def test_pyarrow_include():
+ # We need to make sure that pyarrow/include is always
+ # created. Either with PyArrow C++ header files or with
+ # Arrow C++ and PyArrow C++ header files together
+
+ source = os.path.dirname(os.path.abspath(__file__))
+ pyarrow_dir = os.path.abspath(pjoin(source, '..'))
Review Comment:
Sure! Here it is:
```
(Pdb) print(source)
/Users/alenkafrim/repos/arrow/python/pyarrow/tests
(Pdb) pyarrow_dir
'/Users/alenkafrim/repos/arrow/python/pyarrow'
```
<details>
<summary>ls -lah ouput /test</summary>
<br>
```
(pyarrow-dev-9) (base) alenkafrim@Alenkas-MacBook-Pro python % ls -lah /Users/alenkafrim/repos/arrow/python/pyarrow/tests
total 3240
drwxr-xr-x 62 alenkafrim staff 1.9K 22 Nov 10:02 .
drwxr-xr-x 109 alenkafrim staff 3.4K 22 Nov 10:02 ..
-rw-r--r-- 1 alenkafrim staff 0B 5 May 2022 __init__.py
drwxr-xr-x 5 alenkafrim staff 160B 22 Nov 10:03 __pycache__
-rw-r--r-- 1 alenkafrim staff 1.3K 2 Jun 13:33 arrow_16597.py
-rw-r--r-- 1 alenkafrim staff 1.1K 3 Nov 2021 arrow_7980.py
-rw-r--r-- 1 alenkafrim staff 2.0K 11 Apr 2022 bound_function_visit_strings.pyx
-rw-r--r-- 1 alenkafrim staff 6.1K 29 Jun 09:38 conftest.py
drwxr-xr-x 5 alenkafrim staff 160B 27 Oct 12:17 data
-rw-r--r-- 1 alenkafrim staff 961B 3 Nov 2021 deserialize_buffer.py
drwxr-xr-x 3 alenkafrim staff 96B 21 Nov 14:54 interchange
-rw-r--r-- 1 alenkafrim staff 5.0K 3 Nov 2021 pandas_examples.py
-rw-r--r-- 1 alenkafrim staff 1.4K 3 Nov 2021 pandas_threaded_import.py
drwxr-xr-x 16 alenkafrim staff 512B 22 Nov 06:02 parquet
-rw-r--r-- 1 alenkafrim staff 1.9K 11 Apr 2022 pyarrow_cython_example.pyx
-rw-r--r-- 1 alenkafrim staff 953B 19 Apr 2022 read_record_batch.py
-rw-r--r-- 1 alenkafrim staff 13K 22 Apr 2022 strategies.py
-rw-r--r-- 1 alenkafrim staff 1.4K 3 Nov 2021 test_adhoc_memory_leak.py
-rw-r--r-- 1 alenkafrim staff 106K 22 Nov 06:02 test_array.py
-rw-r--r-- 1 alenkafrim staff 2.1K 3 Nov 2021 test_builder.py
-rw-r--r-- 1 alenkafrim staff 13K 19 Apr 2022 test_cffi.py
-rw-r--r-- 1 alenkafrim staff 108K 22 Nov 10:02 test_compute.py
-rw-r--r-- 1 alenkafrim staff 70K 27 Oct 14:04 test_convert_builtin.py
-rw-r--r-- 1 alenkafrim staff 1.8K 22 Nov 10:03 test_cpp_internals.py
-rw-r--r-- 1 alenkafrim staff 71K 22 Nov 06:02 test_csv.py
-rw-r--r-- 1 alenkafrim staff 27K 3 Nov 2021 test_cuda.py
-rw-r--r-- 1 alenkafrim staff 8.5K 3 Nov 2021 test_cuda_numba_interop.py
-rw-r--r-- 1 alenkafrim staff 6.5K 22 Nov 06:02 test_cython.py
-rw-r--r-- 1 alenkafrim staff 175K 22 Nov 06:02 test_dataset.py
-rw-r--r-- 1 alenkafrim staff 891B 3 Nov 2021 test_deprecations.py
-rw-r--r-- 1 alenkafrim staff 9.2K 27 Oct 14:04 test_exec_plan.py
-rw-r--r-- 1 alenkafrim staff 33K 22 Nov 06:02 test_extension_type.py
-rw-r--r-- 1 alenkafrim staff 24K 22 Nov 06:02 test_feather.py
-rw-r--r-- 1 alenkafrim staff 2.3K 19 Apr 2022 test_filesystem.py
-rw-r--r-- 1 alenkafrim staff 79K 22 Nov 06:02 test_flight.py
-rw-r--r-- 1 alenkafrim staff 55K 27 Oct 14:04 test_fs.py
-rw-r--r-- 1 alenkafrim staff 15K 27 Oct 14:04 test_gandiva.py
-rw-r--r-- 1 alenkafrim staff 42K 22 Nov 06:02 test_gdb.py
-rw-r--r-- 1 alenkafrim staff 13K 11 Apr 2022 test_hdfs.py
-rw-r--r-- 1 alenkafrim staff 56K 27 Oct 14:04 test_io.py
-rw-r--r-- 1 alenkafrim staff 36K 22 Nov 06:02 test_ipc.py
-rw-r--r-- 1 alenkafrim staff 12K 22 Nov 06:02 test_json.py
-rw-r--r-- 1 alenkafrim staff 15K 3 Nov 2021 test_jvm.py
-rw-r--r-- 1 alenkafrim staff 7.6K 11 Jul 08:19 test_memory.py
-rw-r--r-- 1 alenkafrim staff 5.8K 19 Apr 2022 test_misc.py
-rw-r--r-- 1 alenkafrim staff 19K 22 Nov 10:02 test_orc.py
-rw-r--r-- 1 alenkafrim staff 159K 22 Nov 06:02 test_pandas.py
-rw-r--r-- 1 alenkafrim staff 44K 22 Nov 06:02 test_plasma.py
-rw-r--r-- 1 alenkafrim staff 3.4K 3 Nov 2021 test_plasma_tf_op.py
-rw-r--r-- 1 alenkafrim staff 20K 22 Nov 10:02 test_scalars.py
-rw-r--r-- 1 alenkafrim staff 21K 22 Nov 06:02 test_schema.py
-rw-r--r-- 1 alenkafrim staff 41K 11 Apr 2022 test_serialization.py
-rw-r--r-- 1 alenkafrim staff 1.6K 11 Apr 2022 test_serialization_deprecated.py
-rw-r--r-- 1 alenkafrim staff 17K 3 Nov 2021 test_sparse_tensor.py
-rw-r--r-- 1 alenkafrim staff 1.7K 3 Nov 2021 test_strategies.py
-rw-r--r-- 1 alenkafrim staff 8.4K 22 Nov 06:02 test_substrait.py
-rw-r--r-- 1 alenkafrim staff 65K 27 Oct 14:04 test_table.py
-rw-r--r-- 1 alenkafrim staff 6.1K 11 Apr 2022 test_tensor.py
-rw-r--r-- 1 alenkafrim staff 33K 22 Nov 10:02 test_types.py
-rw-r--r-- 1 alenkafrim staff 17K 29 Jun 09:38 test_udf.py
-rw-r--r-- 1 alenkafrim staff 1.7K 11 Apr 2022 test_util.py
-rw-r--r-- 1 alenkafrim staff 13K 6 May 2022 util.py
```
</details>
<details>
<summary>ls -lah ouput pyarrow/</summary>
<br>
```
(pyarrow-dev-9) (base) alenkafrim@Alenkas-MacBook-Pro python % ls -lah /Users/alenkafrim/repos/arrow/python/pyarrow
total 185744
drwxr-xr-x 109 alenkafrim staff 3.4K 22 Nov 10:02 .
drwxr-xr-x 36 alenkafrim staff 1.1K 22 Nov 10:02 ..
-rw-r--r--@ 1 alenkafrim staff 6.0K 17 Nov 12:41 .DS_Store
-rw-r--r-- 1 alenkafrim staff 2.1K 3 Nov 2021 __init__.pxd
-rw-r--r-- 1 alenkafrim staff 19K 22 Nov 08:17 __init__.py
drwxr-xr-x 20 alenkafrim staff 640B 22 Nov 10:03 __pycache__
-rwxr-xr-x 1 alenkafrim staff 3.8M 21 Nov 12:35 _compute.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 1.7K 6 May 2022 _compute.pxd
-rw-r--r-- 1 alenkafrim staff 83K 22 Nov 10:02 _compute.pyx
-rw-r--r-- 1 alenkafrim staff 1.7K 30 May 12:10 _compute_docstrings.py
-rwxr-xr-x 1 alenkafrim staff 970K 21 Nov 12:35 _csv.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 1.6K 11 Apr 2022 _csv.pxd
-rw-r--r-- 1 alenkafrim staff 51K 22 Nov 06:02 _csv.pyx
-rw-r--r-- 1 alenkafrim staff 1.9K 3 Nov 2021 _cuda.pxd
-rw-r--r-- 1 alenkafrim staff 34K 11 Apr 2022 _cuda.pyx
-rwxr-xr-x 1 alenkafrim staff 3.0M 21 Nov 12:35 _dataset.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 4.3K 27 Oct 14:04 _dataset.pxd
-rw-r--r-- 1 alenkafrim staff 100K 22 Nov 06:02 _dataset.pyx
-rw-r--r-- 1 alenkafrim staff 1.3K 11 Apr 2022 _dataset_orc.pyx
-rwxr-xr-x 1 alenkafrim staff 934K 21 Nov 12:35 _dataset_parquet.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 30K 29 Jun 09:38 _dataset_parquet.pyx
-rwxr-xr-x 1 alenkafrim staff 1.0M 21 Nov 12:35 _exec_plan.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 16K 22 Nov 06:02 _exec_plan.pyx
-rwxr-xr-x 1 alenkafrim staff 265K 21 Nov 12:35 _feather.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 3.7K 11 Apr 2022 _feather.pyx
-rw-r--r-- 1 alenkafrim staff 105K 22 Nov 06:02 _flight.pyx
-rwxr-xr-x 1 alenkafrim staff 1.9M 21 Nov 12:35 _fs.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 2.4K 3 Nov 2021 _fs.pxd
-rw-r--r-- 1 alenkafrim staff 51K 22 Nov 06:02 _fs.pyx
-rw-r--r-- 1 alenkafrim staff 8.0K 29 Jun 09:38 _gcsfs.pyx
-rw-r--r-- 1 alenkafrim staff 186B 21 Nov 12:35 _generated_version.py
-rw-r--r-- 1 alenkafrim staff 5.6K 29 Jun 09:38 _hdfs.pyx
-rwxr-xr-x 1 alenkafrim staff 483K 21 Nov 12:35 _hdfsio.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 13K 11 Apr 2022 _hdfsio.pyx
-rwxr-xr-x 1 alenkafrim staff 199K 21 Nov 12:35 _json.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 8.5K 19 Apr 2022 _json.pyx
-rw-r--r-- 1 alenkafrim staff 5.6K 11 Apr 2022 _orc.pxd
-rw-r--r-- 1 alenkafrim staff 15K 11 Apr 2022 _orc.pyx
-rwxr-xr-x 1 alenkafrim staff 1.6M 21 Nov 12:35 _parquet.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 25K 29 Jun 09:38 _parquet.pxd
-rw-r--r-- 1 alenkafrim staff 57K 27 Oct 14:04 _parquet.pyx
-rw-r--r-- 1 alenkafrim staff 5.9K 19 Apr 2022 _parquet_encryption.pxd
-rw-r--r-- 1 alenkafrim staff 17K 19 Apr 2022 _parquet_encryption.pyx
-rw-r--r-- 1 alenkafrim staff 30K 22 Nov 06:02 _plasma.pyx
-rwxr-xr-x 1 alenkafrim staff 207K 21 Nov 12:35 _pyarrow_cpp_tests.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 1.2K 22 Nov 06:02 _pyarrow_cpp_tests.pxd
-rw-r--r-- 1 alenkafrim staff 1.7K 22 Nov 06:02 _pyarrow_cpp_tests.pyx
-rwxr-xr-x 1 alenkafrim staff 388K 21 Nov 12:35 _s3fs.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 16K 22 Nov 06:02 _s3fs.pyx
-rw-r--r-- 1 alenkafrim staff 6.3K 22 Nov 06:02 _substrait.pyx
-rw-r--r-- 1 alenkafrim staff 91K 22 Nov 06:02 array.pxi
-rw-r--r-- 1 alenkafrim staff 869B 3 Nov 2021 benchmark.pxi
-rw-r--r-- 1 alenkafrim staff 856B 3 Nov 2021 benchmark.py
-rw-r--r-- 1 alenkafrim staff 2.6K 3 Nov 2021 builder.pxi
-rw-r--r-- 1 alenkafrim staff 2.1K 3 Nov 2021 cffi.py
-rw-r--r-- 1 alenkafrim staff 2.0K 11 Apr 2022 compat.pxi
-rw-r--r-- 1 alenkafrim staff 21K 22 Nov 10:02 compute.py
-rw-r--r-- 1 alenkafrim staff 2.7K 11 Apr 2022 config.pxi
-rw-r--r-- 1 alenkafrim staff 6.2K 27 Oct 14:04 conftest.py
-rw-r--r-- 1 alenkafrim staff 974B 11 Apr 2022 csv.py
-rw-r--r-- 1 alenkafrim staff 1.1K 3 Nov 2021 cuda.py
-rw-r--r-- 1 alenkafrim staff 38K 27 Oct 14:04 dataset.py
-rw-r--r-- 1 alenkafrim staff 8.3K 22 Nov 06:02 error.pxi
-rw-r--r-- 1 alenkafrim staff 9.9K 22 Nov 06:02 feather.py
-rw-r--r-- 1 alenkafrim staff 14K 10 Jun 10:00 filesystem.py
-rw-r--r-- 1 alenkafrim staff 1.8K 22 Nov 06:02 flight.py
-rw-r--r-- 1 alenkafrim staff 14K 27 Oct 14:04 fs.py
-rw-r--r-- 1 alenkafrim staff 20K 27 Oct 14:04 gandiva.pyx
-rw-r--r-- 1 alenkafrim staff 7.4K 11 Apr 2022 hdfs.py
drwxr-xr-x 3 alenkafrim staff 96B 17 Nov 11:37 include
drwxr-xr-x 15 alenkafrim staff 480B 22 Nov 10:02 includes
drwxr-xr-x 3 alenkafrim staff 96B 21 Nov 14:54 interchange
-rw-r--r-- 1 alenkafrim staff 68K 27 Oct 14:04 io.pxi
-rw-r--r-- 1 alenkafrim staff 33K 22 Nov 06:02 ipc.pxi
-rw-r--r-- 1 alenkafrim staff 9.7K 22 Nov 06:02 ipc.py
-rw-r--r-- 1 alenkafrim staff 858B 3 Nov 2021 json.py
-rw-r--r-- 1 alenkafrim staff 9.4K 3 Nov 2021 jvm.py
-rwxr-xr-x 1 alenkafrim staff 7.0M 21 Nov 12:35 lib.cpython-39-darwin.so
-rw-r--r-- 1 alenkafrim staff 14K 22 Nov 10:02 lib.pxd
-rw-r--r-- 1 alenkafrim staff 4.6K 21 Apr 2022 lib.pyx
-rw-r--r-- 1 alenkafrim staff 19K 21 Nov 12:35 lib_api.h
-rwxr-xr-x 1 alenkafrim staff 12M 21 Nov 12:35 libarrow_python.1100.0.0.dylib
-rwxr-xr-x 1 alenkafrim staff 12M 21 Nov 12:35 libarrow_python.1100.dylib
-rw-r--r-- 1 alenkafrim staff 30M 21 Nov 12:35 libarrow_python.a
-rwxr-xr-x 1 alenkafrim staff 12M 21 Nov 12:35 libarrow_python.dylib
-rwxr-xr-x 1 alenkafrim staff 458K 21 Nov 12:35 libarrow_python_flight.1100.0.0.dylib
-rwxr-xr-x 1 alenkafrim staff 458K 21 Nov 12:35 libarrow_python_flight.1100.dylib
-rw-r--r-- 1 alenkafrim staff 1.2M 21 Nov 12:35 libarrow_python_flight.a
-rwxr-xr-x 1 alenkafrim staff 458K 21 Nov 12:35 libarrow_python_flight.dylib
-rw-r--r-- 1 alenkafrim staff 8.0K 27 Oct 14:04 memory.pxi
-rw-r--r-- 1 alenkafrim staff 12K 22 Nov 06:02 orc.py
-rw-r--r-- 1 alenkafrim staff 7.8K 17 Nov 10:51 pandas-shim.pxi
-rw-r--r-- 1 alenkafrim staff 43K 22 Nov 06:02 pandas_compat.py
drwxr-xr-x 6 alenkafrim staff 192B 22 Nov 06:02 parquet
-rw-r--r-- 1 alenkafrim staff 6.3K 22 Nov 06:02 plasma.py
-rw-r--r-- 1 alenkafrim staff 13K 22 Nov 10:02 public-api.pxi
-rw-r--r-- 1 alenkafrim staff 29K 22 Nov 10:02 scalar.pxi
-rw-r--r-- 1 alenkafrim staff 19K 29 Jun 09:38 serialization.pxi
-rw-r--r-- 1 alenkafrim staff 18K 3 Nov 2021 serialization.py
drwxr-xr-x 8 alenkafrim staff 256B 22 Nov 10:02 src
-rw-r--r-- 1 alenkafrim staff 873B 27 Oct 14:04 substrait.py
-rw-r--r-- 1 alenkafrim staff 158K 22 Nov 06:02 table.pxi
-rw-r--r-- 1 alenkafrim staff 38K 19 Apr 2022 tensor.pxi
drwxr-xr-x 3 alenkafrim staff 96B 27 Oct 14:04 tensorflow
drwxr-xr-x 62 alenkafrim staff 1.9K 22 Nov 10:02 tests
-rw-r--r-- 1 alenkafrim staff 90K 22 Nov 06:02 types.pxi
-rw-r--r-- 1 alenkafrim staff 10K 11 Apr 2022 types.py
-rw-r--r-- 1 alenkafrim staff 4.6K 22 Nov 06:02 util.py
drwxr-xr-x 6 alenkafrim staff 192B 17 Nov 11:07 vendored
```
</details>
If I remember correctly, if I didn't use `os.path.abspath()` the `..` didn't have an effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org