[jira] [Commented] (FLINK-6502) Add support ElasticsearchSink for DataSet

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069579#comment-16069579 ] 

ASF GitHub Bot commented on FLINK-6502:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3869
  
    @397090770 I'm afraid I will need to reject this PR as of its current state.
    
    The main issue is that we can't just move those public user-facing classes. We either have to deprecate them and have a more general packaging path for them so that they can be shared across batch / stream ES connectors, or that we simply duplicate them for batch.
    
    As for the base class logic, this PR needs refactoring so that common logic between the batch and stream is shared, instead of almost the exact same code copied between the two.


> Add support ElasticsearchSink for DataSet
> -----------------------------------------
>
>                 Key: FLINK-6502
>                 URL: https://issues.apache.org/jira/browse/FLINK-6502
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataSet API
>    Affects Versions: 1.2.1
>            Reporter: wyp
>
> Currently, Flink only support writing data in DataStream to ElasticSearch through {{ElasticsearchSink}}, We should be able to writing data in DataSet to ElasticSearch too. see [http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/ElasticsearchSink-on-DataSet-td12980.html]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)