You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/12 14:05:14 UTC

[GitHub] [pulsar] MarvinCai commented on a change in pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

MarvinCai commented on a change in pull request #11986:
URL: https://github.com/apache/pulsar/pull/11986#discussion_r706825383



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -786,6 +786,9 @@ public PartitionedTopicMetadata getPartitionedMetadata(
             @ApiParam(value = "Is check configuration required to automatically create topic")
             @QueryParam("checkAllowAutoCreation") @DefaultValue("false") boolean checkAllowAutoCreation) {
         validateTopicName(tenant, namespace, encodedTopic);
+        if (checkAllowAutoCreation) {

Review comment:
       this method is `getPartitionedMetadata`, should only need `READ` permission right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org