You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "khanimteyaz (GitHub)" <gi...@apache.org> on 2019/01/07 15:45:15 UTC

[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3156: enhancement: fixes #2999

Should we refactor this by extrating to another method e.g. 


```
String fileName=  getFileKey(url);


private static String getFileKey(URL url) {
   String defaultFile = System.getProperty("user.home") + "/.dubbo/dubbo-registry-" + url.getParameter(Constants.APPLICATION_KEY) + "-" + url.getAddress() + ".cache";
        return  url.getParameter(Constants.FILE_KEY, defaultFile);
}
```


Do you feel it would help us to increase the readability of code?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org