You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/07 05:20:52 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
davidjumani opened a new pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501
Fixes #487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on pull request #501: vm: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654700162
@davidjumani - what should i expect to see in http://primate-qa.cloudstack.cloud:8080/client/pr/501 ??
as an admin I see every plugin possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#discussion_r450622935
##########
File path: src/components/view/ListApiView.vue
##########
@@ -0,0 +1,116 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
Review comment:
Minor nit - can we can call this something like ListResourceTab ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #501: vm: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654701330
@PaulAngus that's because backup is enabled. You can try it on an environment on which it has been disabled (https://github.com/apache/cloudstack/pull/4202)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #501: vm: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654701330
Well that's because backup is enabled. You can try it on an environment on which it has been disabled (https://github.com/apache/cloudstack/pull/4202)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #501: vm: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654693364
@PaulAngus Good to go ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654655703
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #501: vm: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654672987
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/501 (JID-2233)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654661457
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654661772
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654661237
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/501 (JID-2232)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654656187
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#issuecomment-654660476
Need to find a better way to pass the router link so it can be used against several columns if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org