You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2016/12/02 14:47:40 UTC
Review Request 54308: Refactor widgets on Dashboard page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54308/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19064
https://issues.apache.org/jira/browse/AMBARI-19064
Repository: ambari
Description
-------
Refactor widgets on Dashboard page
Diffs
-----
ambari-web/app/mixins/main/dashboard/widgets/editable.js f330ec3
ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 3a36ed6
ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs d80e601
ambari-web/app/templates/main/dashboard/plus_button_filter.hbs df7714c
ambari-web/app/templates/main/dashboard/widgets.hbs a778033
ambari-web/app/templates/main/dashboard/widgets/pie_chart.hbs fdeafd1
ambari-web/app/views/common/not-scrollable-textarea.js 1898714
ambari-web/app/views/main/dashboard/widget.js cc5be28
ambari-web/app/views/main/dashboard/widgets.js 999fc08
ambari-web/app/views/main/dashboard/widgets/datanode_live.js 184b046
ambari-web/app/views/main/dashboard/widgets/flume_agent_live.js e8169c9
ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js 04e7d66
ambari-web/app/views/main/dashboard/widgets/hbase_average_load.js 48c4de0
ambari-web/app/views/main/dashboard/widgets/hbase_links.js 4f2053a
ambari-web/app/views/main/dashboard/widgets/hbase_master_heap.js 63b1cc2
ambari-web/app/views/main/dashboard/widgets/hbase_master_uptime.js 0801ac2
ambari-web/app/views/main/dashboard/widgets/hbase_regions_in_transition.js 1f225c6
ambari-web/app/views/main/dashboard/widgets/hdfs_capacity.js e64534d
ambari-web/app/views/main/dashboard/widgets/hdfs_links.js cfe5eb1
ambari-web/app/views/main/dashboard/widgets/metrics_cpu.js 72ef1c2
ambari-web/app/views/main/dashboard/widgets/metrics_load.js c357934
ambari-web/app/views/main/dashboard/widgets/metrics_memory.js 659d647
ambari-web/app/views/main/dashboard/widgets/metrics_network.js 40fdb0b
ambari-web/app/views/main/dashboard/widgets/namenode_cpu.js 161b5c0
ambari-web/app/views/main/dashboard/widgets/namenode_heap.js 731143c
ambari-web/app/views/main/dashboard/widgets/namenode_rpc.js 58b86d9
ambari-web/app/views/main/dashboard/widgets/namenode_uptime.js e55f871
ambari-web/app/views/main/dashboard/widgets/node_managers_live.js d5bf50b
ambari-web/app/views/main/dashboard/widgets/pie_chart_widget.js 8f2dc90
ambari-web/app/views/main/dashboard/widgets/pxf_live.js 74b2096
ambari-web/app/views/main/dashboard/widgets/resource_manager_heap.js 9509053
ambari-web/app/views/main/dashboard/widgets/resource_manager_uptime.js 6d87741
ambari-web/app/views/main/dashboard/widgets/supervisor_live.js b8e36ca
ambari-web/app/views/main/dashboard/widgets/text_widget.js 388ea52
ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 69c5821
ambari-web/app/views/main/dashboard/widgets/uptime_text_widget.js 792aa70
ambari-web/app/views/main/dashboard/widgets/yarn_links.js d7b6488
ambari-web/app/views/main/dashboard/widgets/yarn_memory.js b4dc9b7
ambari-web/test/views/main/dashboard/widget_test.js 0544ff6
ambari-web/test/views/main/dashboard/widgets/hbase_average_load_test.js e3a08c9
ambari-web/test/views/main/dashboard/widgets/hbase_regions_in_transition_test.js 8ad1531
ambari-web/test/views/main/dashboard/widgets/namenode_rpc_test.js 474d099
ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js e564922
ambari-web/test/views/main/dashboard/widgets/text_widget_test.js 730e209
ambari-web/test/views/main/dashboard/widgets/uptime_text_widget_test.js fbe2694
ambari-web/test/views/main/dashboard/widgets_test.js 0781c79
Diff: https://reviews.apache.org/r/54308/diff/
Testing
-------
19919 tests complete (29 seconds)
155 tests pending
Thanks,
Andrii Tkach
Re: Review Request 54308: Refactor widgets on Dashboard page
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54308/#review157753
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u0414\u0435\u043a. 2, 2016, 2:47 \u043f.\u043f., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54308/
> -----------------------------------------------------------
>
> (Updated \u0414\u0435\u043a. 2, 2016, 2:47 \u043f.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19064
> https://issues.apache.org/jira/browse/AMBARI-19064
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Refactor widgets on Dashboard page
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/main/dashboard/widgets/editable.js f330ec3
> ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 3a36ed6
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs d80e601
> ambari-web/app/templates/main/dashboard/plus_button_filter.hbs df7714c
> ambari-web/app/templates/main/dashboard/widgets.hbs a778033
> ambari-web/app/templates/main/dashboard/widgets/pie_chart.hbs fdeafd1
> ambari-web/app/views/common/not-scrollable-textarea.js 1898714
> ambari-web/app/views/main/dashboard/widget.js cc5be28
> ambari-web/app/views/main/dashboard/widgets.js 999fc08
> ambari-web/app/views/main/dashboard/widgets/datanode_live.js 184b046
> ambari-web/app/views/main/dashboard/widgets/flume_agent_live.js e8169c9
> ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js 04e7d66
> ambari-web/app/views/main/dashboard/widgets/hbase_average_load.js 48c4de0
> ambari-web/app/views/main/dashboard/widgets/hbase_links.js 4f2053a
> ambari-web/app/views/main/dashboard/widgets/hbase_master_heap.js 63b1cc2
> ambari-web/app/views/main/dashboard/widgets/hbase_master_uptime.js 0801ac2
> ambari-web/app/views/main/dashboard/widgets/hbase_regions_in_transition.js 1f225c6
> ambari-web/app/views/main/dashboard/widgets/hdfs_capacity.js e64534d
> ambari-web/app/views/main/dashboard/widgets/hdfs_links.js cfe5eb1
> ambari-web/app/views/main/dashboard/widgets/metrics_cpu.js 72ef1c2
> ambari-web/app/views/main/dashboard/widgets/metrics_load.js c357934
> ambari-web/app/views/main/dashboard/widgets/metrics_memory.js 659d647
> ambari-web/app/views/main/dashboard/widgets/metrics_network.js 40fdb0b
> ambari-web/app/views/main/dashboard/widgets/namenode_cpu.js 161b5c0
> ambari-web/app/views/main/dashboard/widgets/namenode_heap.js 731143c
> ambari-web/app/views/main/dashboard/widgets/namenode_rpc.js 58b86d9
> ambari-web/app/views/main/dashboard/widgets/namenode_uptime.js e55f871
> ambari-web/app/views/main/dashboard/widgets/node_managers_live.js d5bf50b
> ambari-web/app/views/main/dashboard/widgets/pie_chart_widget.js 8f2dc90
> ambari-web/app/views/main/dashboard/widgets/pxf_live.js 74b2096
> ambari-web/app/views/main/dashboard/widgets/resource_manager_heap.js 9509053
> ambari-web/app/views/main/dashboard/widgets/resource_manager_uptime.js 6d87741
> ambari-web/app/views/main/dashboard/widgets/supervisor_live.js b8e36ca
> ambari-web/app/views/main/dashboard/widgets/text_widget.js 388ea52
> ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 69c5821
> ambari-web/app/views/main/dashboard/widgets/uptime_text_widget.js 792aa70
> ambari-web/app/views/main/dashboard/widgets/yarn_links.js d7b6488
> ambari-web/app/views/main/dashboard/widgets/yarn_memory.js b4dc9b7
> ambari-web/test/views/main/dashboard/widget_test.js 0544ff6
> ambari-web/test/views/main/dashboard/widgets/hbase_average_load_test.js e3a08c9
> ambari-web/test/views/main/dashboard/widgets/hbase_regions_in_transition_test.js 8ad1531
> ambari-web/test/views/main/dashboard/widgets/namenode_rpc_test.js 474d099
> ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js e564922
> ambari-web/test/views/main/dashboard/widgets/text_widget_test.js 730e209
> ambari-web/test/views/main/dashboard/widgets/uptime_text_widget_test.js fbe2694
> ambari-web/test/views/main/dashboard/widgets_test.js 0781c79
>
> Diff: https://reviews.apache.org/r/54308/diff/
>
>
> Testing
> -------
>
> 19919 tests complete (29 seconds)
> 155 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>