You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Fasih (JIRA)" <ji...@apache.org> on 2011/03/22 09:37:05 UTC
[jira] [Created] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h &
TAsyncBufferProcessor.h dont have virtual functions but no virtual
destructor. Causes warnings on -Wall
C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
--------------------------------------------------------------------------------------------------------------------------------------------
Key: THRIFT-1106
URL: https://issues.apache.org/jira/browse/THRIFT-1106
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.6
Reporter: Fasih
Priority: Minor
The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
AW: [jira] [Commented] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
Posted by Roger Meier <ro...@bufferoverflow.ch>.
Dear comitters
Yesterday, I activated these comments on our Continous Integration Server.
Is it a good thing? Please tell me if you think this is not a feature;-)
- roger
-----Ursprüngliche Nachricht-----
Von: Hudson (JIRA) [mailto:jira@apache.org]
Gesendet: Mittwoch, 23. März 2011 19:17
An: dev@thrift.apache.org
Betreff: [jira] [Commented] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010272#comment-13010272 ]
Hudson commented on THRIFT-1106:
--------------------------------
Integrated in Thrift #97 (See [https://hudson.apache.org/hudson/job/Thrift/97/])
THRIFT-1106. cpp: C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
Patch: Fasih
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Assignee: Fasih
> Priority: Minor
> Fix For: 0.7
>
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h
& TAsyncBufferProcessor.h dont have virtual functions but no virtual
destructor. Causes warnings on -Wall
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010272#comment-13010272 ]
Hudson commented on THRIFT-1106:
--------------------------------
Integrated in Thrift #97 (See [https://hudson.apache.org/hudson/job/Thrift/97/])
THRIFT-1106. cpp: C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
Patch: Fasih
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Assignee: Fasih
> Priority: Minor
> Fix For: 0.7
>
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h
& TAsyncBufferProcessor.h dont have virtual functions but no virtual
destructor. Causes warnings on -Wall
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009734#comment-13009734 ]
David Reiss commented on THRIFT-1106:
-------------------------------------
Indentation looks off. Otherwise, looks fine to me.
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Priority: Minor
> Fix For: 0.6
>
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h &
TAsyncBufferProcessor.h dont have virtual functions but no virtual
destructor. Causes warnings on -Wall
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1106.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.6)
0.7
Assignee: Fasih
I just committed this to TRUNK.
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Assignee: Fasih
> Priority: Minor
> Fix For: 0.7
>
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h
& TAsyncBufferProcessor.h dont have virtual functions but no virtual
destructor. Causes warnings on -Wall
Posted by "Fasih (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fasih resolved THRIFT-1106.
---------------------------
Resolution: Fixed
Fix Version/s: 0.6
Attached patch fixes the problem
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Priority: Minor
> Fix For: 0.6
>
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h &
TAsyncBufferProcessor.h dont have virtual functions but no virtual
destructor. Causes warnings on -Wall
Posted by "Fasih (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fasih updated THRIFT-1106:
--------------------------
Attachment: create-virtual-dtor.patch
Patch for the bug
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Priority: Minor
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h
& TAsyncBufferProcessor.h dont have virtual functions but no virtual
destructor. Causes warnings on -Wall
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reopened THRIFT-1106:
-----------------------------------
There were no commits on this ticket.
> C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1106
> URL: https://issues.apache.org/jira/browse/THRIFT-1106
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.6
> Reporter: Fasih
> Priority: Minor
> Fix For: 0.7
>
> Attachments: create-virtual-dtor.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The classes TAsyncBufferProcessor.h & TAsyncProtocolProcessor.h have virtual functions but no virtual destructor.
> This causes warnings on -Wall
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira