You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/10 19:03:44 UTC
[GitHub] [beam] angoenka commented on a change in pull request #15143: Release Guide Updates from 2.31.0
angoenka commented on a change in pull request #15143:
URL: https://github.com/apache/beam/pull/15143#discussion_r686244152
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -632,37 +632,6 @@ See the source of the script for more details or to run commands manually in cas
## 8. Prepare documents
-### Update and Verify Javadoc
-
-The build with `-PisRelease` creates the combined Javadoc for the release in `sdks/java/javadoc`.
-
-The file `sdks/java/javadoc/build.gradle` contains a list of modules to include and exclude, plus a list of offline URLs that populate links from Beam's Javadoc to the Javadoc for other modules that Beam depends on.
-
-* Confirm that new modules added since the last release have been added to the inclusion list as appropriate.
-
-* Confirm that the excluded package list is up to date.
Review comment:
Let's add where to look for it.
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -632,37 +632,6 @@ See the source of the script for more details or to run commands manually in cas
## 8. Prepare documents
-### Update and Verify Javadoc
-
-The build with `-PisRelease` creates the combined Javadoc for the release in `sdks/java/javadoc`.
-
-The file `sdks/java/javadoc/build.gradle` contains a list of modules to include and exclude, plus a list of offline URLs that populate links from Beam's Javadoc to the Javadoc for other modules that Beam depends on.
-
-* Confirm that new modules added since the last release have been added to the inclusion list as appropriate.
Review comment:
Shall we also mention where and what to look for when confirming.
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -632,37 +632,6 @@ See the source of the script for more details or to run commands manually in cas
## 8. Prepare documents
-### Update and Verify Javadoc
-
-The build with `-PisRelease` creates the combined Javadoc for the release in `sdks/java/javadoc`.
-
-The file `sdks/java/javadoc/build.gradle` contains a list of modules to include and exclude, plus a list of offline URLs that populate links from Beam's Javadoc to the Javadoc for other modules that Beam depends on.
-
-* Confirm that new modules added since the last release have been added to the inclusion list as appropriate.
-
-* Confirm that the excluded package list is up to date.
-
-* Verify the version numbers for offline links match the versions used by Beam.
- If the version number has changed, download a new version of the corresponding `<module>-docs/package-list` file.
-
-
-### Build the Pydoc API reference
Review comment:
Shall this be done under a virtual environment ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org