You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/28 16:14:21 UTC
[GitHub] [kafka] tinaselenge opened a new pull request, #12912: MINOR: Fix some compiler warnings
tinaselenge opened a new pull request, #12912:
URL: https://github.com/apache/kafka/pull/12912
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tinaselenge commented on pull request #12912: MINOR: Fix some compiler warnings
Posted by GitBox <gi...@apache.org>.
tinaselenge commented on PR #12912:
URL: https://github.com/apache/kafka/pull/12912#issuecomment-1330377219
@showuon I have addressed your comment. There seem to be some unrelated tests failing. Would you be able to retrigger them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12912: MINOR: Fix some compiler warnings
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12912:
URL: https://github.com/apache/kafka/pull/12912#issuecomment-1333773568
I don't think most of these are actual compiler warnings are they? They seem like lint type warnings. It would be good to clarify in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming merged pull request #12912: MINOR: Fix some warnings
Posted by GitBox <gi...@apache.org>.
dengziming merged PR #12912:
URL: https://github.com/apache/kafka/pull/12912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12912: MINOR: Fix some compiler warnings
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12912:
URL: https://github.com/apache/kafka/pull/12912#issuecomment-1330156517
@tinaselenge , thanks for the PR. So, which compiler warnings are you trying to fix here? Could you add some more info in PR description? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org