You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by wy96f <gi...@git.apache.org> on 2018/06/11 11:32:04 UTC

[GitHub] activemq-artemis pull request #2133: ARTEMIS-1923 fix constructing binding j...

GitHub user wy96f opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2133

    ARTEMIS-1923 fix constructing binding journalimpl bug

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wy96f/activemq-artemis binding_journalimpl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2133
    
----
commit 376861f91ff3ce8068c5a2901179db24cd9dc63a
Author: yang wei <wy...@...>
Date:   2018-06-11T11:27:00Z

    ARTEMIS-1923 fix constructing binding journalimpl bug

----


---

[GitHub] activemq-artemis issue #2133: ARTEMIS-1923 fix constructing binding journali...

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2133
  
    I will ammend the commit with a test


---

[GitHub] activemq-artemis issue #2133: ARTEMIS-1923 fix constructing binding journali...

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2133
  
    A test here would be useful.  Even something as simple as adding some getters and verifying the properties are set as expected would work, I think.


---

[GitHub] activemq-artemis pull request #2133: ARTEMIS-1923 fix constructing binding j...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2133


---