You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2015/05/10 01:27:25 UTC
Review Request 34021: DRILL-2870: Return type of aggregate functions
(part 1)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34021/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Repository: drill-git
Description
-------
Have broken down the final patch into two for easier review. This is a minor refactoring patch.
This patch simply moves count aggregate function to a different template than existing aggregate functions. Reason being that count is the only aggregate function with a required output type (irrespective of the input type). This will eliminate some of the conditional logic in the templates.
Diffs
-----
exec/java-exec/src/main/codegen/config.fmpp 8db120d
exec/java-exec/src/main/codegen/data/AggrTypes1.tdd 8952417
exec/java-exec/src/main/codegen/data/CountAggrTypes.tdd PRE-CREATION
exec/java-exec/src/main/codegen/data/DecimalAggrTypes1.tdd 5ac299c
exec/java-exec/src/main/codegen/templates/CountAggregateFunctions.java PRE-CREATION
Diff: https://reviews.apache.org/r/34021/diff/
Testing
-------
All unit tests and functional tests pass
Thanks,
Mehant Baid
Re: Review Request 34021: DRILL-2870: Return type of aggregate
functions (part 1)
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34021/#review83168
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On May 9, 2015, 11:27 p.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34021/
> -----------------------------------------------------------
>
> (Updated May 9, 2015, 11:27 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Have broken down the final patch into two for easier review. This is a minor refactoring patch.
>
> This patch simply moves count aggregate function to a different template than existing aggregate functions. Reason being that count is the only aggregate function with a required output type (irrespective of the input type). This will eliminate some of the conditional logic in the templates.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/config.fmpp 8db120d
> exec/java-exec/src/main/codegen/data/AggrTypes1.tdd 8952417
> exec/java-exec/src/main/codegen/data/CountAggrTypes.tdd PRE-CREATION
> exec/java-exec/src/main/codegen/data/DecimalAggrTypes1.tdd 5ac299c
> exec/java-exec/src/main/codegen/templates/CountAggregateFunctions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34021/diff/
>
>
> Testing
> -------
>
> All unit tests and functional tests pass
>
>
> Thanks,
>
> Mehant Baid
>
>