You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/12 22:29:31 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #5147: Support default star-tree
Jackie-Jiang commented on a change in pull request #5147: Support default star-tree
URL: https://github.com/apache/incubator-pinot/pull/5147#discussion_r391939779
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java
##########
@@ -190,13 +190,17 @@ public SegmentGeneratorConfig(@Nullable TableConfig tableConfig, Schema schema)
_segmentPartitionConfig = indexingConfig.getSegmentPartitionConfig();
// Star-tree V2 configs
- List<StarTreeIndexConfig> starTreeIndexConfigs = indexingConfig.getStarTreeIndexConfigs();
- if (starTreeIndexConfigs != null && !starTreeIndexConfigs.isEmpty()) {
- List<StarTreeV2BuilderConfig> starTreeV2BuilderConfigs = new ArrayList<>(starTreeIndexConfigs.size());
- for (StarTreeIndexConfig starTreeIndexConfig : starTreeIndexConfigs) {
- starTreeV2BuilderConfigs.add(StarTreeV2BuilderConfig.fromIndexConfig(starTreeIndexConfig));
+ if (indexingConfig.isEnableDefaultStarTree()) {
Review comment:
This won't have backward compatible issue because default star-tree is not enabled by default.
But this is a great question, and we should not ignore the explicitly configured star-tree. Modify the code to generate star-tree for both configs (if both are defined, generate both default and customized).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org