You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/26 17:14:15 UTC
[GitHub] [fineract] vorburger commented on a change in pull request #1115: FINERACT-1022: Fixing ehcache 3
vorburger commented on a change in pull request #1115:
URL: https://github.com/apache/fineract/pull/1115#discussion_r446309384
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientAddressRepository.java
##########
@@ -27,8 +27,8 @@
public interface ClientAddressRepository extends JpaRepository<ClientAddress, Long>, JpaSpecificationExecutor<ClientAddress> {
@Query("SELECT clientAddress FROM ClientAddress clientAddress WHERE clientAddress.client.id = :clientId AND clientAddress.addressType = :addressType AND clientAddress.isActive = :isActive ")
- ClientAddress findByClientIdAndAddressTypeAndIsActive(@Param("clientId") final long clientId, final CodeValue addressType,
- @Param("isActive") final boolean isActive);
+ ClientAddress findByClientIdAndAddressTypeAndIsActive(@Param("clientId") final long clientId,
+ @Param("addressType") final CodeValue addressType, @Param("isActive") final boolean isActive);
Review comment:
hah, nice catch - looks like this was wrong (missing) in #1110 ?! I missed it! @kiran-vsm FYI...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org