You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/11/10 02:56:12 UTC
[GitHub] [submarine] pingsutw opened a new pull request #450: SUBMARINE-666. Update HowToRelease.md
pingsutw opened a new pull request #450:
URL: https://github.com/apache/submarine/pull/450
### What is this PR for?
update HowToRelease.md, make it more clear and fix some typos
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-666
### How should this be tested?
https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/742603121
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jojochuang commented on a change in pull request #450: SUBMARINE-666. Update HowToRelease.md
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #450:
URL: https://github.com/apache/submarine/pull/450#discussion_r522470813
##########
File path: dev-support/cicd/HowToRelease.md
##########
@@ -26,16 +29,16 @@ svn ci -m "Add <your name>'s key"
It's better to send a release plan email informing code freeze date and release date.
## 3. Clean up the JIRA
-Bulk update JIRA to unassign from this release all issues that are open non-blockers.
+Bulk update JIRA to unassigned from this release all issues that are open non-blockers.
Review comment:
Let's update this to "Bulk update JIRA to move out non-blocker issues by setting the target version to the new release."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jojochuang commented on a change in pull request #450: SUBMARINE-666. Update HowToRelease.md
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #450:
URL: https://github.com/apache/submarine/pull/450#discussion_r522472839
##########
File path: dev-support/cicd/HowToRelease.md
##########
@@ -95,7 +98,7 @@ docker tag local/mini-submarine:0.3.0 apache/submarine:mini-0.3.0-RC0
```
In the container, we can verify that the submarine jar version is the expected 0.3.0. Then we can upload this image with a "RC" tag for a vote.
```
-docker push apache/mini-submarine:0.3.0:RC0
+docker push apache/submarine:mini-0.3.0-RC0
Review comment:
Does it require an INFRA ticket to grant you permission to the ASF DockerHub? like this one? https://issues.apache.org/jira/browse/INFRA-20364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #450: SUBMARINE-666. Update HowToRelease.md
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #450:
URL: https://github.com/apache/submarine/pull/450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org