You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/30 22:53:41 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #15621: Test helm templates
ephraimbuddy opened a new pull request #15621:
URL: https://github.com/apache/airflow/pull/15621
This change adds tests to validate limitrange and resourcequota templates including scheduler resources limits and requests configuration
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15621: Test helm templates
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15621:
URL: https://github.com/apache/airflow/pull/15621#discussion_r624285846
##########
File path: chart/tests/test_scheduler.py
##########
@@ -174,3 +174,27 @@ def test_logs_persistence_changes_volume(self, log_persistence_values, expected_
assert {"name": "logs", **expected_volume} == jmespath.search(
"spec.template.spec.volumes[1]", docs[0]
)
+
+ def test_scheduler_resources_are_configurable(self):
Review comment:
Can you add this for `webserver` and `workers` too please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15621: Test helm templates
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #15621:
URL: https://github.com/apache/airflow/pull/15621#discussion_r624514961
##########
File path: chart/tests/test_scheduler.py
##########
@@ -174,3 +174,27 @@ def test_logs_persistence_changes_volume(self, log_persistence_values, expected_
assert {"name": "logs", **expected_volume} == jmespath.search(
"spec.template.spec.volumes[1]", docs[0]
)
+
+ def test_scheduler_resources_are_configurable(self):
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15621: Chart: Add unit tests for limits and resources
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15621:
URL: https://github.com/apache/airflow/pull/15621#issuecomment-830643644
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy merged pull request #15621: Chart: Add unit tests for limits and resources
Posted by GitBox <gi...@apache.org>.
ephraimbuddy merged pull request #15621:
URL: https://github.com/apache/airflow/pull/15621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org