You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zhengchenyu (via GitHub)" <gi...@apache.org> on 2023/08/10 04:08:03 UTC

[GitHub] [incubator-uniffle] zhengchenyu commented on a diff in pull request #1122: [#1111] fix: Shuffle server can not delete remote storage path in security cluster

zhengchenyu commented on code in PR #1122:
URL: https://github.com/apache/incubator-uniffle/pull/1122#discussion_r1289521114


##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -649,6 +649,7 @@ public void checkLeakShuffleData() {
   public void removeResources(String appId) {
     LOG.info("Start remove resource for appId[" + appId + "]");
     final long start = System.currentTimeMillis();
+    String user = getUserByAppId(appId);

Review Comment:
   Only the next line code will remove shuffleTaskInfos. I move before it. 
   Because after next line, getUserByAppId(appId) is always null. 
   User name is not a problem for non security cluster. But user name is important for security cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org