You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/01/28 21:51:37 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1645: Create Azure node from Compute Gallery image, OS disk delete

Kami commented on a change in pull request #1645:
URL: https://github.com/apache/libcloud/pull/1645#discussion_r794911920



##########
File path: libcloud/compute/drivers/azure_arm.py
##########
@@ -703,7 +739,7 @@ def create_node(
 
         r = self.connection.request(
             target,
-            params={"api-version": RESOURCE_API_VERSION},

Review comment:
       As you pointed out in the PR description, changing this version may be problematic.
   
   To be on the safe side, I think it would be good to do the following:
   
   1. Add new ``api_version`` to the driver constructor and allow user to override default API version (we already use similar pattern in many other drives).
   2. Document this change in the upgrade_nodes.rst and show an example how user can utilize ``api_version`` constructor argument to set it to the previous default value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org