You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2010/07/28 13:38:32 UTC

Re: svn commit: r978954 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java

It seems (I say "it seems" because I reverted just before, it could be another revision ahead, but I doubt) that  978944-978954 set 
of revision introduced some issues...
At least with the link element in screen widget, for instance using
<link name="holdButton" target="changeOrderStatus" text="${uiLabelMap.CommonHold}" style="buttontext">
    <parameter param-name="orderId"/>
    <parameter param-name="statusId" value="ORDER_HOLD"/>
    <parameter param-name="partyId"/>
    <parameter param-name="listCollapsed" value="true"/>
    <parameter param-name="detailCollapsed" value="false"/>
</link>
I got this error: (sorry I prefered to put all the relevant log, as it may help)
_________________________________________________________________
Expected collection or sequence. parameterList evaluated instead to freemarker.template.SimpleScalar on line 117, column 8 in 
component://widget/templates/htmlScreenMacroLibrary.ftl.
The problematic instruction:
----------
==> list parameterList as parameter [on line 117, column 1 in component://widget/templates/htmlScreenMacroLibrary.ftl]
 in user-directive renderLink [on line 1, column 1 in Wed Jul 28 13:17:11 CEST 2010]
----------

Java backtrace for programmers:
----------
freemarker.template.TemplateException: Expected collection or sequence. parameterList evaluated instead to 
freemarker.template.SimpleScalar on line 117, column 8 in component://widget/templates/htmlScreenMacr
oLibrary.ftl.
        at freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:135)
        at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:190)
        at freemarker.core.Environment.visit(Environment.java:416)
        at freemarker.core.IteratorBlock.accept(IteratorBlock.java:102)
        at freemarker.core.Environment.visit(Environment.java:209)
        at freemarker.core.MixedContent.accept(MixedContent.java:92)
        at freemarker.core.Environment.visit(Environment.java:209)
        at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79)
        at freemarker.core.Environment.visit(Environment.java:209)
        at freemarker.core.MixedContent.accept(MixedContent.java:92)
        at freemarker.core.Environment.visit(Environment.java:209)
        at freemarker.core.Macro$Context.runMacro(Macro.java:168)
        at freemarker.core.Environment.visit(Environment.java:602)
        at freemarker.core.UnifiedCall.accept(UnifiedCall.java:106)
        at freemarker.core.Environment.visit(Environment.java:209)
        at freemarker.core.Environment.include(Environment.java:1482)
        at org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:97)
        at org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:124)
        at org.ofbiz.widget.screen.MacroScreenRenderer.renderLink(MacroScreenRenderer.java:278)
        at org.ofbiz.widget.screen.ModelScreenWidget$Link.renderWidgetString(ModelScreenWidget.java:1390)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
        at org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:633)
        at org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:370)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
        at org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:540)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:670)
        at org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:126)
        at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:703)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:670)
        at org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:126)
        at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:703)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
        at org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:540)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
        at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:637)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
        at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:637)
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
        at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:135)
        at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:97)
        at org.ofbiz.widget.screen.MacroScreenViewHandler.render(MacroScreenViewHandler.java:104)
        at org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:839)
        at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:559)
        at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:227)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
        at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:271)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
        at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
        at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:852)
        at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588)
        at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
        at java.lang.Thread.run(Thread.java:619)
_________________________________________________________________

Reverting to r978939, and using the same calling link, this error dissapears. Also one of my client, who is using trunk, decided to 
stay at r965923 (not sure why yet he uses this peculiar revision) because "he crossed issues" (I still don't know which issues he 
spoke about, he told me "many")

Also I was surprised that by using a url-mode="plain" I got no poping XSS security error message (it's only in the log). Has anyone 
changed this behaviour or is it normal? If it's normal I will change that!

Thanks

Jacques 



Re: svn commit: r978954 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Scott,
Jacques
PS: Sorry no time for OE-QuoteFix ;)

From: "Scott Gray" <sc...@hotwaxmedia.com>
Thanks Jacques, until I figure out a solution I've reverted the changes to that method in r980238.
Regards
Scott
On 28/07/2010, at 11:38 PM, Jacques Le Roux wrote:
> It seems (I say "it seems" because I reverted just before, it could be another revision ahead, but I doubt) that  978944-978954
> set of revision introduced some issues...
> At least with the link element in screen widget, for instance using
> <link name="holdButton" target="changeOrderStatus" text="${uiLabelMap.CommonHold}" style="buttontext">
>   <parameter param-name="orderId"/>
>   <parameter param-name="statusId" value="ORDER_HOLD"/>
>   <parameter param-name="partyId"/>
>   <parameter param-name="listCollapsed" value="true"/>
>   <parameter param-name="detailCollapsed" value="false"/>
> </link>
> I got this error: (sorry I prefered to put all the relevant log, as it may help)
> _________________________________________________________________
> Expected collection or sequence. parameterList evaluated instead to freemarker.template.SimpleScalar on line 117, column 8 in
> component://widget/templates/htmlScreenMacroLibrary.ftl.
> The problematic instruction:
> ----------
> ==> list parameterList as parameter [on line 117, column 1 in component://widget/templates/htmlScreenMacroLibrary.ftl]
> in user-directive renderLink [on line 1, column 1 in Wed Jul 28 13:17:11 CEST 2010]
> ----------
>
> Java backtrace for programmers:
> ----------
> freemarker.template.TemplateException: Expected collection or sequence. parameterList evaluated instead to
> freemarker.template.SimpleScalar on line 117, column 8 in component://widget/templates/htmlScreenMacr
> oLibrary.ftl.
>       at freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:135)
>       at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:190)
>       at freemarker.core.Environment.visit(Environment.java:416)
>       at freemarker.core.IteratorBlock.accept(IteratorBlock.java:102)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.MixedContent.accept(MixedContent.java:92)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.MixedContent.accept(MixedContent.java:92)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.Macro$Context.runMacro(Macro.java:168)
>       at freemarker.core.Environment.visit(Environment.java:602)
>       at freemarker.core.UnifiedCall.accept(UnifiedCall.java:106)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.Environment.include(Environment.java:1482)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:97)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:124)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.renderLink(MacroScreenRenderer.java:278)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Link.renderWidgetString(ModelScreenWidget.java:1390)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:633)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:370)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:540)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:670)
>       at org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:126)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:703)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:670)
>       at org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:126)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:703)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:540)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:637)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:637)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:135)
>       at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:97)
>       at org.ofbiz.widget.screen.MacroScreenViewHandler.render(MacroScreenViewHandler.java:104)
>       at org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:839)
>       at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:559)
>       at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:227)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
>       at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
>       at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>       at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:271)
>       at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>       at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>       at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
>       at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
>       at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
>       at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
>       at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>       at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
>       at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
>       at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:852)
>       at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588)
>       at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
>       at java.lang.Thread.run(Thread.java:619)
> _________________________________________________________________
>
> Reverting to r978939, and using the same calling link, this error dissapears. Also one of my client, who is using trunk, decided
> to stay at r965923 (not sure why yet he uses this peculiar revision) because "he crossed issues" (I still don't know which issues
> he spoke about, he told me "many")
>
> Also I was surprised that by using a url-mode="plain" I got no poping XSS security error message (it's only in the log). Has
> anyone changed this behaviour or is it normal? If it's normal I will change that!
>
> Thanks
>
> Jacques
>




Re: svn commit: r978954 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/MacroScreenRenderer.java

Posted by Scott Gray <sc...@hotwaxmedia.com>.
Thanks Jacques, until I figure out a solution I've reverted the changes to that method in r980238.

Regards
Scott

On 28/07/2010, at 11:38 PM, Jacques Le Roux wrote:

> It seems (I say "it seems" because I reverted just before, it could be another revision ahead, but I doubt) that  978944-978954 set of revision introduced some issues...
> At least with the link element in screen widget, for instance using
> <link name="holdButton" target="changeOrderStatus" text="${uiLabelMap.CommonHold}" style="buttontext">
>   <parameter param-name="orderId"/>
>   <parameter param-name="statusId" value="ORDER_HOLD"/>
>   <parameter param-name="partyId"/>
>   <parameter param-name="listCollapsed" value="true"/>
>   <parameter param-name="detailCollapsed" value="false"/>
> </link>
> I got this error: (sorry I prefered to put all the relevant log, as it may help)
> _________________________________________________________________
> Expected collection or sequence. parameterList evaluated instead to freemarker.template.SimpleScalar on line 117, column 8 in component://widget/templates/htmlScreenMacroLibrary.ftl.
> The problematic instruction:
> ----------
> ==> list parameterList as parameter [on line 117, column 1 in component://widget/templates/htmlScreenMacroLibrary.ftl]
> in user-directive renderLink [on line 1, column 1 in Wed Jul 28 13:17:11 CEST 2010]
> ----------
> 
> Java backtrace for programmers:
> ----------
> freemarker.template.TemplateException: Expected collection or sequence. parameterList evaluated instead to freemarker.template.SimpleScalar on line 117, column 8 in component://widget/templates/htmlScreenMacr
> oLibrary.ftl.
>       at freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:135)
>       at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:190)
>       at freemarker.core.Environment.visit(Environment.java:416)
>       at freemarker.core.IteratorBlock.accept(IteratorBlock.java:102)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.MixedContent.accept(MixedContent.java:92)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.MixedContent.accept(MixedContent.java:92)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.Macro$Context.runMacro(Macro.java:168)
>       at freemarker.core.Environment.visit(Environment.java:602)
>       at freemarker.core.UnifiedCall.accept(UnifiedCall.java:106)
>       at freemarker.core.Environment.visit(Environment.java:209)
>       at freemarker.core.Environment.include(Environment.java:1482)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:97)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:124)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.renderLink(MacroScreenRenderer.java:278)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Link.renderWidgetString(ModelScreenWidget.java:1390)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:633)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:370)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:540)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:670)
>       at org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:126)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:703)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:670)
>       at org.ofbiz.widget.screen.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:126)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:703)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:257)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:540)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:637)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:637)
>       at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:101)
>       at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:188)
>       at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:392)
>       at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:135)
>       at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:97)
>       at org.ofbiz.widget.screen.MacroScreenViewHandler.render(MacroScreenViewHandler.java:104)
>       at org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:839)
>       at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:559)
>       at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:227)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
>       at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
>       at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>       at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:271)
>       at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>       at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>       at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
>       at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
>       at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
>       at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
>       at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>       at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
>       at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
>       at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:852)
>       at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588)
>       at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
>       at java.lang.Thread.run(Thread.java:619)
> _________________________________________________________________
> 
> Reverting to r978939, and using the same calling link, this error dissapears. Also one of my client, who is using trunk, decided to stay at r965923 (not sure why yet he uses this peculiar revision) because "he crossed issues" (I still don't know which issues he spoke about, he told me "many")
> 
> Also I was surprised that by using a url-mode="plain" I got no poping XSS security error message (it's only in the log). Has anyone changed this behaviour or is it normal? If it's normal I will change that!
> 
> Thanks
> 
> Jacques 
>