You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/08 06:55:07 UTC

[GitHub] seelmann commented on issue #4408: [AIRFLOW-3589] Visualize reschedule state in all views

seelmann commented on issue #4408: [AIRFLOW-3589] Visualize reschedule state in all views
URL: https://github.com/apache/airflow/pull/4408#issuecomment-452194510
 
 
   @ashb @Fokko PTAL, ready to merge from my PoV.
   
   I tested in our test env with Celery executor and added some tests for the changes in `jobs.py`.
   
   I decided to add a dedicated state `UP_FOR_RESCHEDULE`. It increases the complexity in `jobs.py` a bit. However with that change all the views just work without any code change.
   
   Other things to discuss:
   * Is the name `UP_FOR_RESCHEDULE` a good one or do you have a better idea?
   * As color I choosed `turquoise`, not sure if it's a good choice? See screenshots attached to the Jira.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services