[jira] [Commented] (HBASE-22427) HBOSS: TestTreeLockManager fails on non-ZK implementations

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853189#comment-16853189 ] 

Sean Busbey commented on HBASE-22427:
-------------------------------------

Is there a jira tracking the null implementation failing {{TestAtomicRename}} and {{TestCreateNonRecursive}}? When I test this TestTreeLockManager is fine but those two show up.

> HBOSS: TestTreeLockManager fails on non-ZK implementations
> ----------------------------------------------------------
>
>                 Key: HBASE-22427
>                 URL: https://issues.apache.org/jira/browse/HBASE-22427
>             Project: HBase
>          Issue Type: Bug
>          Components: Filesystem Integration
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Major
>              Labels: HBOSS
>             Fix For: hbase-filesystem-1.0.0-alpha1
>
>         Attachments: 0001-HBASE-22427-HBOSS-TestTreeLockManager-fails-on-non-Z.patch
>
>
> I thought I had run all the implementations on my HBASE-22386 patch, but I guess not. Some minor issues:
> * There's a <= / < mixup in LocalTreeLockManager *LockBelow logic that's having it look 1 layer deeper than it needs to.
> * We should org.junit.Assume that TestTreeLockManager's sync field isn't the null implementation, because we test internal details that the null implementation wouldn't even use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)