You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/19 12:03:09 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7135: net/wireless: add support for netdev private ioctl
anchao opened a new pull request, #7135:
URL: https://github.com/apache/incubator-nuttx/pull/7135
## Summary
1. net/wireless: add support for netdev private ioctl
2. net/wireless: separate command catagory of bt/pktradio from wireless ioctl
```
1. separate command catagory of bt/pktradio from wireless ioctl
2. Remove commoand count limit to support vendor command
```
## Impact
N/A
## Testing
CI check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7135: net/wireless: add support for netdev private ioctl
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7135:
URL: https://github.com/apache/incubator-nuttx/pull/7135#discussion_r974174673
##########
include/nuttx/wireless/bluetooth/bt_ioctl.h:
##########
@@ -67,10 +67,6 @@
/* Bluetooth network device IOCTL commands. */
-#if !defined(WL_BLUETOOTHCMDS) || WL_BLUETOOTHCMDS != 28
Review Comment:
update line 45
##########
include/nuttx/wireless/pktradio.h:
##########
@@ -37,33 +37,29 @@
/* Packet radio network device IOCTL commands. */
-#ifndef WL_NPKTRADIOCMDS != 3
Review Comment:
update line 30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7135: net/wireless: add support for netdev private ioctl
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7135:
URL: https://github.com/apache/incubator-nuttx/pull/7135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7135: net/wireless: add support for netdev private ioctl
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7135:
URL: https://github.com/apache/incubator-nuttx/pull/7135#discussion_r974375329
##########
include/nuttx/wireless/wireless.h:
##########
@@ -150,6 +150,42 @@
#define SIOCSIWPTAPRIO _WLIOC(0x0039) /* Set PTA priority type */
#define SIOCGIWPTAPRIO _WLIOC(0x003a) /* Get PTA priority type */
+/* -------------------- DEV PRIVATE IOCTL LIST -------------------- */
+
+/* These 32 ioctl are wireless device private, for 16 commands.
+ * Each driver is free to use them for whatever purpose it chooses,
+ * however the driver *must* export the description of those ioctls
+ * with SIOCGIWPRIV and *must* use arguments as defined below.
+ */
+
+#define SIOCIWFIRSTPRIV _WLIOC(0x00e0)
+#define SIOCIWLASTPRIV _WLIOC(0x00ff)
+
+/* Previously, we were using SIOCDEVPRIVATE, but we now have our
+ * separate range because of collisions with other tools such as
+ * 'mii-tool'.
+ * We now have 32 commands, so a bit more space ;-).
+ * Also, all 'even' commands are only usable by root and don't return the
+ * content of ifr/iwr to user (but you are not obliged to use the set/get
+ * convention, just use every other two command). More details in iwpriv.c.
+ * And I repeat : you are not forced to use them with iwpriv, but you
+ * must be compliant with it.
+ */
Review Comment:
Yes, let me remove the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7135: net/wireless: add support for netdev private ioctl
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7135:
URL: https://github.com/apache/incubator-nuttx/pull/7135#discussion_r974183261
##########
include/nuttx/wireless/bluetooth/bt_ioctl.h:
##########
@@ -67,10 +67,6 @@
/* Bluetooth network device IOCTL commands. */
-#if !defined(WL_BLUETOOTHCMDS) || WL_BLUETOOTHCMDS != 28
Review Comment:
Done
##########
include/nuttx/wireless/pktradio.h:
##########
@@ -37,33 +37,29 @@
/* Packet radio network device IOCTL commands. */
-#ifndef WL_NPKTRADIOCMDS != 3
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7135: net/wireless: add support for netdev private ioctl
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7135:
URL: https://github.com/apache/incubator-nuttx/pull/7135#discussion_r974360437
##########
include/nuttx/wireless/wireless.h:
##########
@@ -150,6 +150,42 @@
#define SIOCSIWPTAPRIO _WLIOC(0x0039) /* Set PTA priority type */
#define SIOCGIWPTAPRIO _WLIOC(0x003a) /* Get PTA priority type */
+/* -------------------- DEV PRIVATE IOCTL LIST -------------------- */
+
+/* These 32 ioctl are wireless device private, for 16 commands.
+ * Each driver is free to use them for whatever purpose it chooses,
+ * however the driver *must* export the description of those ioctls
+ * with SIOCGIWPRIV and *must* use arguments as defined below.
+ */
+
+#define SIOCIWFIRSTPRIV _WLIOC(0x00e0)
+#define SIOCIWLASTPRIV _WLIOC(0x00ff)
+
+/* Previously, we were using SIOCDEVPRIVATE, but we now have our
+ * separate range because of collisions with other tools such as
+ * 'mii-tool'.
+ * We now have 32 commands, so a bit more space ;-).
+ * Also, all 'even' commands are only usable by root and don't return the
+ * content of ifr/iwr to user (but you are not obliged to use the set/get
+ * convention, just use every other two command). More details in iwpriv.c.
+ * And I repeat : you are not forced to use them with iwpriv, but you
+ * must be compliant with it.
+ */
Review Comment:
This comment does not seem to be pertinent to this project, considering the references to `mii-tool` and `iwpriv.c`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org