You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2009/03/20 18:14:12 UTC

[jira] Created: (MNG-4098) increase concurrency of parallel downloads

increase concurrency of parallel downloads
------------------------------------------

                 Key: MNG-4098
                 URL: http://jira.codehaus.org/browse/MNG-4098
             Project: Maven 2
          Issue Type: Improvement
          Components: Artifacts and Repositories
    Affects Versions: 2.1.0
            Reporter: Brett Porter


this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.

Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-4098) increase concurrency of parallel downloads

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-4098:
------------------------------

    Fix Version/s:     (was: 2.2.x (to be reviewed))
                   3.x / Backlog

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2 & 3
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>             Fix For: 3.x / Backlog
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-4098) increase concurrency of parallel downloads

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174401#action_174401 ] 

John Casey commented on MNG-4098:
---------------------------------

Not quite ready yet...I'll revisit in a bit, when I find a way to tidy up these other issues...

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 2.1.1
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-4098) increase concurrency of parallel downloads

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174384#action_174384 ] 

John Casey commented on MNG-4098:
---------------------------------

What else do we need to do to get this resolved? Should we be looking at pushing this to the next release, if it's going to entail more than simply increasing concurrency?

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>             Fix For: 2.1.1
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-4098) increase concurrency of parallel downloads

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174690#action_174690 ] 

John Casey commented on MNG-4098:
---------------------------------

Do you have anything specific in mind for testing this once we remove the per-groupId restriction from parallel resolution?

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 2.2.0
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-4098) increase concurrency of parallel downloads

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174399#action_174399 ] 

Brett Porter commented on MNG-4098:
-----------------------------------

I think we can remove the grouping of the downloads and allow them to be as parallel as possible since the way the tree works should prevent sequencing/concurrency problems.

However, that requires more testing than a simple bugfix - no problem bumping it if you're ready to release

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>             Fix For: 2.1.1
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-4098) increase concurrency of parallel downloads

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MNG-4098:
----------------------------

    Fix Version/s:     (was: 2.2.0)
                   2.2.x

Let's push this until the next release, since we haven't made a start on it yet, and we're otherwise ready to start the release process.

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 2.2.x
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-4098) increase concurrency of parallel downloads

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174705#action_174705 ] 

Brett Porter commented on MNG-4098:
-----------------------------------

given how quickly we found the problems on a clean repo before, smoke testing will probably do the most. I think we still have an IT in place that deliberately grabs multiple artifacts that might need to be revised to ensure they are from different groups.

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 2.2.0
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-4098) increase concurrency of parallel downloads

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-4098:
------------------------------

    Fix Version/s: 2.1.1

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>             Fix For: 2.1.1
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-4098) increase concurrency of parallel downloads

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-4098.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 3.x / Backlog)
                   3.0-alpha-7
         Assignee: Benjamin Bentmann

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2 & 3
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>            Assignee: Benjamin Bentmann
>             Fix For: 3.0-alpha-7
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-4098) increase concurrency of parallel downloads

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-4098:
------------------------------

    Assignee:     (was: Brett Porter)

> increase concurrency of parallel downloads
> ------------------------------------------
>
>                 Key: MNG-4098
>                 URL: http://jira.codehaus.org/browse/MNG-4098
>             Project: Maven 2 & 3
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.1.0
>            Reporter: Brett Porter
>             Fix For: 2.2.x (to be reviewed)
>
>
> this started out in 2.1.0. To avoid file locking issues parallelism was limited to artifacts in different groups. However, I'm now of the opinion this is not necessary and we should investigate allowing jars to be downloaded in parallel regardless of group.
> Don has also suggested some improvements to the synchronization that might make the code cleaner and faster, which I'll look for him to add here.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira