You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/01 17:54:28 UTC
[GitHub] [incubator-druid] jihoonson edited a comment on issue #6960:
standardize naming of 'no-op' aggregators
jihoonson edited a comment on issue #6960: standardize naming of 'no-op' aggregators
URL: https://github.com/apache/incubator-druid/pull/6960#issuecomment-478679684
Should `EmptySequence` and `EmptyIterator` also be renamed?
> Since I'm renaming a few files in the area already, any upvotes for renaming some of the other datasketches extension post-aggregator types to make navigating to the right file easier?
I think it depends on how many classes you are thinking to rename. I'm fine by doing it in this PR if it's small enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org