You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Bilung Lee <bl...@gmail.com> on 2011/08/19 20:02:31 UTC
Review Request: SQOOP-320 Use Information Schema for SQLServerManager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1592/
-----------------------------------------------------------
Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.
Summary
-------
Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager.
This addresses bug SQOOP-320.
https://issues.apache.org/jira/browse/SQOOP-320
Diffs
-----
src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af
Diff: https://reviews.apache.org/r/1592/diff
Testing
-------
Thanks,
Bilung
Re: Review Request: SQOOP-320 Use Information Schema for SQLServerManager
Posted by Bilung Lee <bl...@gmail.com>.
> On 2011-08-19 20:04:25, Arvind Prabhakar wrote:
> > +1
> >
> > Can you please add the patch to the Jira. Thanks!
Ok. Done.
- Bilung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1592/#review1558
-----------------------------------------------------------
On 2011-08-19 18:02:31, Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1592/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 18:02:31)
>
>
> Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.
>
>
> Summary
> -------
>
> Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager.
>
>
> This addresses bug SQOOP-320.
> https://issues.apache.org/jira/browse/SQOOP-320
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af
>
> Diff: https://reviews.apache.org/r/1592/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bilung
>
>
Re: Review Request: SQOOP-320 Use Information Schema for SQLServerManager
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1592/#review1558
-----------------------------------------------------------
Ship it!
+1
Can you please add the patch to the Jira. Thanks!
- Arvind
On 2011-08-19 18:02:31, Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1592/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 18:02:31)
>
>
> Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.
>
>
> Summary
> -------
>
> Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager.
>
>
> This addresses bug SQOOP-320.
> https://issues.apache.org/jira/browse/SQOOP-320
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af
>
> Diff: https://reviews.apache.org/r/1592/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bilung
>
>