You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/01 06:05:47 UTC

[GitHub] [shardingsphere] roodkcab commented on a change in pull request #13187: support XA transaction for proxy #12771

roodkcab commented on a change in pull request #13187:
URL: https://github.com/apache/shardingsphere/pull/13187#discussion_r739975116



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLTCLStatementSQLVisitor.java
##########
@@ -98,7 +108,32 @@ public ASTNode visitSavepoint(final SavepointContext ctx) {
     }
     
     @Override
-    public ASTNode visitXa(final XaContext ctx) {
-        return new MySQLXAStatement();
+    public ASTNode visitXaBegin(final XaBeginContext ctx) {
+        return new MySQLXABeginStatement();

Review comment:
       yes, xid is generated by TransactionManager, and will be managed in itself, i.e. per xid per connection




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org