[GitHub] [incubator-nuttx] johannes-nivus commented on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox <gi...@apache.org>]

johannes-nivus commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597105619
 
 
   Concerning nxstyle I have to comment:
   As long as there are #defines below each other my revised nxstyle checks for all right of code comments beeing on the same column. You can set up a new column position by adding a blank line.
   So I see no false positives in the output of nxstyle with stm32h7x3xx_rcc.h (of current master).
   The nicer way to fix it would have been aligning the comments, and then extend the "ruler" to match the line length. In extreme case (to avoid  a too long linelength) use multiline comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services