[GitHub] [inlong] healchow commented on a diff in pull request #5225: [INLONG-5014][Improve] Fix the code scanning alerts exposed by CodeQL

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5225:
URL: https://github.com/apache/inlong/pull/5225#discussion_r932381161


##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/web/MasterStatusCheckFilter.java:
##########
@@ -65,7 +69,10 @@ public void doFilter(ServletRequest request,
             if (TStringUtils.isNotBlank(req.getQueryString())) {
                 sBuilder.append("?").append(req.getQueryString());
             }
-            resp.sendRedirect(sBuilder.toString());
+            this.redirectWhiteList = sBuilder.toString();
+            if (redirectWhiteList.equals(sBuilder.toString())) {

Review Comment:
   The `redirectWhiteList.equals(sBuilder.toString()` is always true, so why compare them here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org