You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/24 10:37:37 UTC
[GitHub] [airflow] eladkal opened a new pull request #18493: Rename AzureDataLakeStorage to ADLS
eladkal opened a new pull request #18493:
URL: https://github.com/apache/airflow/pull/18493
Followup of https://github.com/apache/airflow/pull/18168
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926548712
@eladkal for provider packages, this file has two roles - changelog and update guide. @potiuk updates the changelog, but we keep the update guide manually.
We have a similar case in Airflow Core We have a changelog, but we also have a note in UPDATING.md (Updating Guide). https://github.com/apache/airflow/blob/main/UPDATING.md#changes-to-import-paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926548712
@eladkal for provider packages, this file has two roles - changelog and update guide. @potiuk updates the changelog, but we keep the update guide manually.
We have a similar ccase in. We have a changelog, but we also have a note in nu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926562999
@mik-laj yeah we used to have there but it was removed in https://github.com/apache/airflow/pull/13767
Do you want me to create an `UPDATEING.md` in Azure provider? (Similar to https://github.com/eladkal/airflow/blob/1d722d84ef3c1f5d2cee2f4be72320b47fc9640b/airflow/providers/amazon/aws/ADDITIONAL_INFO.md ) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926693347
@eladkal We should have all information in UPDATING.md. For example, see: google provider -
https://github.com/apache/airflow/blob/main/airflow/providers/google/CHANGELOG.rst In this file, we have descriptions for multiple versions. In most cases, we have the only changelog in sections: "Features"
, "Bug Fixes" section, but we have sometimes additional sections such as "Updated google-cloud-* libraries", "Change in AutoMLPredictOperator". I think we should add a new section that describes how to update DAG to use the latest operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926529924
Can you add a note in `CHANGELOG.rst` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926562999
@mik-laj yeah we used to have it there but it was removed in https://github.com/apache/airflow/pull/13767
Do you want me to create an `UPDATEING.md` in Azure provider? (Similar to https://github.com/eladkal/airflow/blob/1d722d84ef3c1f5d2cee2f4be72320b47fc9640b/airflow/providers/amazon/aws/ADDITIONAL_INFO.md ) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #18493:
URL: https://github.com/apache/airflow/pull/18493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926548712
@eladkal for provider packages, this file has two roles - changelog and update guide. @potiuk updates the changelog, but we keep the update guide manually.
We have a similar case in Airflow Core We have a changelog, but we also have a note in UPDATING.md. https://github.com/apache/airflow/blob/main/UPDATING.md#changes-to-import-paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926530839
> Can you add a note in `CHANGELOG.rst` file?
@potiuk creates them automatically :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-927101618
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18493: Rename AzureDataLakeStorage to ADLS
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18493:
URL: https://github.com/apache/airflow/pull/18493#issuecomment-926550403
We also have a similar guide for backport providers. https://pypi.org/project/apache-airflow-backport-providers-google/ But we also have a changelog separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org