You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2016/09/23 15:11:49 UTC
[GitHub] nifi-minifi pull request #39: MINIFI-81 Adding a check for a valid command t...
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/39
MINIFI-81 Adding a check for a valid command to the config.sh toolkit\u2026
\u2026 script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-81
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 189a5ee21012a5b0c67ecc6a29dd91df6615a1d9
Author: Joseph Percivall <jo...@yahoo.com>
Date: 2016-09-23T15:11:41Z
MINIFI-81 Adding a check for a valid command to the config.sh toolkit script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #39: MINIFI-81 Adding a check for a valid command t...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/39#discussion_r80488336
--- Diff: minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java ---
@@ -85,8 +85,6 @@ public static void main(String[] args) {
public static void printValidateUsage() {
System.out.println("Validate Usage:");
System.out.println();
- System.out.print("java ");
--- End diff --
Hey @apiri, I chose to remove them because they can lead to very confusing errors messages for user who ran it using the scripts. If they happen to mis-type a file location not only would they see the error saying the file doesn't exist but also this "java <class name> ..." line that was quite confusing.
Also, I see this being run using the script in >99% of the cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #39: MINIFI-81 Adding a check for a valid command t...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/39#discussion_r80500315
--- Diff: minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java ---
@@ -85,8 +85,6 @@ public static void main(String[] args) {
public static void printValidateUsage() {
System.out.println("Validate Usage:");
System.out.println();
- System.out.print("java ");
--- End diff --
fair enough, will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #39: MINIFI-81 Adding a check for a valid command t...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/39#discussion_r80333632
--- Diff: minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java ---
@@ -85,8 +85,6 @@ public static void main(String[] args) {
public static void printValidateUsage() {
System.out.println("Validate Usage:");
System.out.println();
- System.out.print("java ");
--- End diff --
Should this and the other java invocation remain given that the interpretation of arguments is handled by the script when invoked from the script? This is valid in the context the class is run by itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi pull request #39: MINIFI-81 Adding a check for a valid command t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---