You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Earwin Burrfoot (JIRA)" <ji...@apache.org> on 2010/11/26 07:34:13 UTC
[jira] Created: (LUCENE-2781) Drop deprecations from trunk
Drop deprecations from trunk
----------------------------
Key: LUCENE-2781
URL: https://issues.apache.org/jira/browse/LUCENE-2781
Project: Lucene - Java
Issue Type: Task
Affects Versions: 4.0
Reporter: Earwin Burrfoot
Priority: Minor
subj.
Also, to each remaining deprecation add release version when it first appeared.
Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965087#action_12965087 ]
Ryan McKinley commented on LUCENE-2781:
---------------------------------------
+1
This sort of patch does not have a great shelflife, so lets not let it rot. If there is anything in question, lets leave it in for now, and can work with smaller patches to fix.
Thanks Earwin!
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, LUCENE-2781.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964751#action_12964751 ]
Earwin Burrfoot commented on LUCENE-2781:
-----------------------------------------
Hmm.. and regarding this exact case.
DutchStemFilter.java had this:
bq. @deprecated Use {@link SnowballFilter} with {@link org.tartarus.snowball.ext.DutchStemmer} instead, which has the same functionality.
considering the following snippet from DutchStemmer.java:
bq. The algorithm is an implementation of the <a href="http://snowball.tartarus.org/algorithms/dutch/stemmer.html">dutch stemming</a> algorithm in Martin Porter's snowball project.
we can reliably drop DutchStemFilter+DutchStemmer, people will fix their code to use SnowballFilter and happily read their 3.0 indexes.
No?
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir reassigned LUCENE-2781:
-----------------------------------
Assignee: Robert Muir
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964640#action_12964640 ]
Earwin Burrfoot commented on LUCENE-2781:
-----------------------------------------
bq. i thought you said you weren't going to sift through solr?
I fixed it to work with de-deprecated Lucene, I didn't remove any of Solr's own deprecations.
bq. is the only remaining issue the two commented out tests that used DateField? In my opinion we could TODO these...
Yes. That's the only remaining issue _known to me_.
There are already a ton of similar todo's out there. Not sure I'd like to increase that number, but too lazy currently to do anything about it. We can todo, yeah. :)
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965204#action_12965204 ]
Robert Muir commented on LUCENE-2781:
-------------------------------------
Committed revision 1040463.
Thanks a lot Earwin, this is tedious stuff and the patch was great... (the only issues were from my wrong deprecation notices in analyzers)
I'll fix these in branch_3.x so people know they are staying aroound till 5.0 for index bw compat reasons.
we should also deprecate Version_2.x in branch_3x.
finally we should fix the usage of deprecated code in 3.x (e.g. i think solr there needs to be fixed to use IWconfig too).
ill see about merging these parts.
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, LUCENE-2781.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2781:
--------------------------------
Attachment: LUCENE-2781_3x.patch
attached is a patch for the branch_3x changes.
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, LUCENE-2781.patch, LUCENE-2781_3x.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2781.
---------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Committed revision 1040505 for the 3x changes. Thanks again Earwin!
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 4.0
>
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, LUCENE-2781.patch, LUCENE-2781_3x.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964755#action_12964755 ]
Earwin Burrfoot commented on LUCENE-2781:
-----------------------------------------
Ok, restore it then and fix deprecation note to "will drop it in Lucene 5.0" or something?
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Earwin Burrfoot updated LUCENE-2781:
------------------------------------
Attachment: drop-deprecations.patch
Same, rebased on latest trunk.
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964749#action_12964749 ]
Earwin Burrfoot commented on LUCENE-2781:
-----------------------------------------
bq. unfortunately we cant yet remove anything we deprecated in 3.0 or 3.1,
Not completely true. We can't remove _some_ of the things deprecated in 3.0 or 3.1. _Some other_ we can remove.
I primarily relied on two pointers - something is already deprecated in 3.1, and/or it has "@deprecated This will be removed in Lucene 4.0" stanza.
Don't use the stanza if it's not true! :)
I also checked things _required to support 3.0 indexes_, and remember leaving some such code intact, but could surely miss something.
Please, post corrected version of the patch, or name exact things we should preserve.
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Earwin Burrfoot updated LUCENE-2781:
------------------------------------
Attachment: drop-deprecations.patch
New patch. Current status:
* Lucene's deprecations are mostly out. Those, which are still in, are marked with Lucene version when they were deprecated - for future reference.
* I didn't sift through Solr (and will not), but I fixed it not to use any of Lucene's removed stuff (eg. it builds and passes tests)
What has to be done?
* There are a couple of commented out tests marked with nocommit - these used removed DateField class. If anybody knows how to fix them fast - please do this. If not, I'll get back at them in a couple of days. Or maybe we can just drop them?
* Version.LUCENE_2x should be dropped, Version.LUCENE_3x - marked as deprecated
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964753#action_12964753 ]
Robert Muir commented on LUCENE-2781:
-------------------------------------
{quote}
we can reliably drop DutchStemFilter+DutchStemmer, people will fix their code to use SnowballFilter and happily read their 3.0 indexes.
No?
{quote}
The DutchStemmer might claim that, but it wasnt completely faithful to the algorithm (buggy).
here's my example from LUCENE-2055:
{noformat}
DutchStemFilter passes 98.9% of snowball tests. all bugs were in handling of double consonants:
examples:
aangetroffen -> aangetrof expected: aangetroff
afvoerbonnen -> afvoerbon expected: afvoerbonn
klommen -> klom expected: klomm
{noformat}
So we kept the buggy implementation, for index back compat :(
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2781:
--------------------------------
Attachment: LUCENE-2781.patch
Earwin's patch: I only restored anything necessary for 3.0+ analyzer back compat (along with any back-compat tests).
All tests pass... in my opinion the patch is sorely needed!
I think Earwin's suggestion here makes a ton of sense:
* Lets say you are on Lucene 2.4, when you upgrade to 3.0, it continues to provide you backwards compat via the version constant, but Version.LUCENE_24 becomes is deprecated, so its a deprecation in your code you know you must fix, before you move to 4.0. At your leisure, sometime during the entire 3.0-3.9 or whatever, you migrate to Version.LUCENE_30 and the deprecation goes away.
* When you move to Lucene 4.0, the Version.LUCENE_24 stuff etc stuff is gone, but its no surprise, because you are guided via deprecations. 4.0 doesnt support 2.x indexes anyway.
So I'm strongly +1 to committing this 2.3MB patch that removes 100,000 lines of crap from trunk.
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, LUCENE-2781.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964625#action_12964625 ]
Robert Muir commented on LUCENE-2781:
-------------------------------------
Earwin: this is looking really nice at a "glance"... i thought you said you weren't going to sift through solr? :) seems like it works here?
is the only remaining issue the two commented out tests that used DateField? In my opinion we could TODO these...
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964730#action_12964730 ]
Robert Muir commented on LUCENE-2781:
-------------------------------------
OK, i looked at the patch and i see a few issues, mainly with the analyzer stuff.
so if we are gonna really do the 2-version thing you suggested on the list, unfortunately we cant yet remove anything we deprecated in 3.0 or 3.1, as we still need some of these deprecated classes to support Version_3.0 in 4.0.
Yes I am aware some of these classes say in trunk/3.x '@deprecated This will be removed in Lucene 4.0' but this is wrong !
Examples include things like DutchStemmer, which are deprecated in 3.1 (branch_3x), but weren't in 3.0, so we have to keep them?
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965198#action_12965198 ]
Michael McCandless commented on LUCENE-2781:
--------------------------------------------
This is awesome work -- thanks Earwin!
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, LUCENE-2781.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Earwin Burrfoot updated LUCENE-2781:
------------------------------------
Attachment: drop-deprecations.patch
New patch.
Version 2x dropped, 3x deprecated. Builds/passes tests.
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964767#action_12964767 ]
Robert Muir commented on LUCENE-2781:
-------------------------------------
Earwin, yeah ill update your patch for this stuff... (since i was the culprit!)
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2781) Drop deprecations from trunk
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Earwin Burrfoot updated LUCENE-2781:
------------------------------------
Attachment: drop-deprecations.patch
Stab one.
Everything works, except Solr - this fails to compile, and a couple of tests that are commented-out and marked nocommit - these should be converted from DateField to DateUtil or dropped.
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Priority: Minor
> Attachments: drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2781) Drop deprecations from trunk
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964619#action_12964619 ]
Robert Muir commented on LUCENE-2781:
-------------------------------------
Lets not allow this patch to get out of date... Earwin i'll try to help with the Solr stuff after i review this monster
> Drop deprecations from trunk
> ----------------------------
>
> Key: LUCENE-2781
> URL: https://issues.apache.org/jira/browse/LUCENE-2781
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Earwin Burrfoot
> Assignee: Robert Muir
> Priority: Minor
> Attachments: drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch, drop-deprecations.patch
>
>
> subj.
> Also, to each remaining deprecation add release version when it first appeared.
> Patch incoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org