You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nick Dimiduk (Jira)" <ji...@apache.org> on 2020/03/27 17:17:00 UTC

[jira] [Commented] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException

    [ https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068915#comment-17068915 ] 

Nick Dimiduk commented on HBASE-24068:
--------------------------------------

Partial initialization + inheritance is evil. Would be best to refactor all use of non-{{private}} methods out of the constructors.

> [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-24068
>                 URL: https://issues.apache.org/jira/browse/HBASE-24068
>             Project: HBase
>          Issue Type: Bug
>          Components: flakies
>            Reporter: Michael Stack
>            Priority: Major
>
> This fails for me locally sporadically. 
> {code}
>  -------------------------------------------------------------------------------
>  Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>  -------------------------------------------------------------------------------
>  Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<< FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>  org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync  Time elapsed: 0.325 s  <<< ERROR!
>  java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
>  Exception in thread "testTable.asyncPrefetcher" java.lang.NullPointerException
>    at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>    at java.lang.Thread.run(Thread.java:748)
>  java.lang.NullPointerException
>    at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>    at java.lang.Thread.run(Thread.java:748)
>  java.lang.NullPointerException
>    at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>    at java.lang.Thread.run(Thread.java:748)
>  2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268] hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
>  java.lang.NullPointerException
>    at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>    at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created as a final data member. But then this issue happened for my compaƱero, [~ndimiduk]... and he saw that the call is from a Thread inner class in this class's grandparent that is set running on construction; i.e. the lock *could* be null at the time of reference.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)