You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/07 04:08:06 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #33238: [SPARK-36020][SQL][3.1] Check logical link in remove redundant projects
cloud-fan commented on a change in pull request #33238:
URL: https://github.com/apache/spark/pull/33238#discussion_r665024445
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1481,4 +1481,26 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-36020: Check logical link in remove redundant projects") {
+ withTempView("t") {
+ spark.range(10).selectExpr("id % 10 as key", "cast(id * 2 as int) as a",
+ "cast(id * 3 as int) as b", "array(id, id + 1, id + 3) as c").createOrReplaceTempView("t")
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
+ val query =
+ """
+ |WITH tt AS (
+ | SELECT key, a, b, explode(c) AS c FROM t
+ |)
+ |SELECT t1.key, t1.c, t2.key, t2.c
+ |FROM (SELECT a, b, c, key FROM tt WHERE a > 1) t1
+ |JOIN (SELECT a, b, c, key FROM tt) t2
+ | ON t1.key = t2.key
+ |""".stripMargin
+ val (origin, adaptive) = runAdaptiveAndVerifyResult(query)
Review comment:
so in 3.1, we just need to make sure this test can run?
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1481,4 +1481,26 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-36020: Check logical link in remove redundant projects") {
+ withTempView("t") {
+ spark.range(10).selectExpr("id % 10 as key", "cast(id * 2 as int) as a",
+ "cast(id * 3 as int) as b", "array(id, id + 1, id + 3) as c").createOrReplaceTempView("t")
+ withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
+ val query =
+ """
+ |WITH tt AS (
+ | SELECT key, a, b, explode(c) AS c FROM t
+ |)
+ |SELECT t1.key, t1.c, t2.key, t2.c
+ |FROM (SELECT a, b, c, key FROM tt WHERE a > 1) t1
+ |JOIN (SELECT a, b, c, key FROM tt) t2
+ | ON t1.key = t2.key
+ |""".stripMargin
+ val (origin, adaptive) = runAdaptiveAndVerifyResult(query)
Review comment:
so in 3.1, we just need to make sure this query can run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org