You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2020/12/04 03:58:16 UTC
[skywalking-nodejs] branch master updated: test: set up Node
version matrix to test different versions (#8)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git
The following commit(s) were added to refs/heads/master by this push:
new 443c8ef test: set up Node version matrix to test different versions (#8)
443c8ef is described below
commit 443c8efe3ddfb528593c9e50b99aaeac44f0af4a
Author: Zhenxu Ke <ke...@apache.org>
AuthorDate: Fri Dec 4 11:58:07 2020 +0800
test: set up Node version matrix to test different versions (#8)
---
.github/workflows/test.yaml | 2 ++
tests/plugins/common/Dockerfile.agent | 4 +++-
tests/plugins/common/base-compose.yml | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 38ecf3d..f210af9 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -30,6 +30,8 @@ jobs:
strategy:
matrix:
node-version: [ 10, 12, 14 ]
+ env:
+ SW_NODE_VERSION: ${{ matrix.node-version }}
steps:
- uses: actions/checkout@v2
with:
diff --git a/tests/plugins/common/Dockerfile.agent b/tests/plugins/common/Dockerfile.agent
index 7db6aee..4c51529 100644
--- a/tests/plugins/common/Dockerfile.agent
+++ b/tests/plugins/common/Dockerfile.agent
@@ -13,7 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM node:12
+ARG SW_NODE_VERSION
+
+FROM node:${SW_NODE_VERSION}
ARG ROOT=.
diff --git a/tests/plugins/common/base-compose.yml b/tests/plugins/common/base-compose.yml
index 264b19a..1e16c0a 100644
--- a/tests/plugins/common/base-compose.yml
+++ b/tests/plugins/common/base-compose.yml
@@ -37,6 +37,8 @@ services:
build:
context: ../../../
dockerfile: tests/plugins/common/Dockerfile.agent
+ args:
+ - SW_NODE_VERSION=${SW_NODE_VERSION:-latest}
environment:
SW_AGENT_COLLECTOR_BACKEND_SERVICES: collector:19876
networks: