You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by gd...@apache.org on 2007/05/03 16:00:05 UTC
svn commit: r534865 - in
/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client:
OperationClient.java ServiceClient.java
Author: gdaniels
Date: Thu May 3 07:00:04 2007
New Revision: 534865
URL: http://svn.apache.org/viewvc?view=rev&rev=534865
Log:
Always cache last operation context on the client if ServiceContext is configured that way.
Clean up JavaDoc.
Modified:
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java?view=diff&rev=534865&r1=534864&r2=534865
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java Thu May 3 07:00:04 2007
@@ -64,13 +64,16 @@
*/
protected boolean completed;
- protected OperationClient(AxisOperation axisOp, ServiceContext sc,
- Options options) {
+ protected OperationClient(AxisOperation axisOp, ServiceContext sc, Options options) {
this.axisOp = axisOp;
this.sc = sc;
this.options = new Options(options);
- this.completed = false;
- this.oc = ContextFactory.createOperationContext(axisOp, this.sc);
+ completed = false;
+ oc = ContextFactory.createOperationContext(axisOp, sc);
+
+ if (sc.isCachingOperationContext()) {
+ sc.setLastOperationContext(oc);
+ }
}
/**
Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java?view=diff&rev=534865&r1=534864&r2=534865
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java Thu May 3 07:00:04 2007
@@ -160,13 +160,13 @@
/**
* This is WSDL4J based constructor to configure the Service Client/
- * We are going to make this policy aware
+ * TODO: make this policy aware
*
- * @param configContext
- * @param wsdl4jDefinition
- * @param wsdlServiceName
- * @param portName
- * @throws AxisFault
+ * @param configContext active ConfigurationContext
+ * @param wsdl4jDefinition the WSDL we're going to be using to configure ourselves
+ * @param wsdlServiceName QName of the WSDL service we'd like to access
+ * @param portName name of the WSDL port we'd like to access
+ * @throws AxisFault in case of error
*/
public ServiceClient(ConfigurationContext configContext, Definition wsdl4jDefinition,
@@ -223,7 +223,7 @@
* Create a service client by assuming an anonymous service and any other
* necessary information.
*
- * @throws AxisFault
+ * @throws AxisFault in case of error
*/
public ServiceClient() throws AxisFault {
this(null, null);
@@ -291,7 +291,7 @@
* each client, with the standard values for the client still used for any
* values not set in the override configuration.
*
- * @param overrideOptions
+ * @param overrideOptions the Options to use
*/
public void setOverrideOptions(Options overrideOptions) {
this.overrideOptions = overrideOptions;
@@ -310,7 +310,7 @@
/**
* Engage a module for this service client.
*
- * @deprecate Please use String version instead
+ * @deprecated Please use String version instead
* @param moduleName name of the module to engage
* @throws AxisFault if something goes wrong
*/
@@ -338,8 +338,8 @@
/**
* Disengage a module for this service client
*
- * @deprecate Please use String version instead
- * @param moduleName
+ * @deprecated Please use String version instead
+ * @param moduleName name of Module to disengage
*/
public void disengageModule(QName moduleName) {
disengageModule(moduleName.getLocalPart());
@@ -348,7 +348,7 @@
/**
* Disengage a module for this service client
*
- * @param moduleName
+ * @param moduleName name of Module to disengage
*/
public void disengageModule(String moduleName) {
AxisModule module = axisConfig.getModule(moduleName);
@@ -393,20 +393,18 @@
/**
- * Add a simple header consisting of some text (and a header name; duh) to
- * be sent with interactions.
+ * Add a simple header containing some text to be sent with interactions.
*
- * @param headerName
- * @param headerText
- * @throws AxisFault
+ * @param headerName name of header to add
+ * @param headerText text content for header
+ * @throws AxisFault in case of error
*/
public void addStringHeader(QName headerName, String headerText) throws AxisFault {
if (headerName.getNamespaceURI() == null || "".equals(headerName.getNamespaceURI())) {
throw new AxisFault(
- "Failed to add string header , you have to have namespaceURI for the QName");
+ "Failed to add string header, you have to have namespaceURI for the QName");
}
- OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(
- headerName, null);
+ OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(headerName, null);
omElement.setText(headerText);
addHeader(omElement);
}
@@ -491,9 +489,9 @@
* can instead create a client for the operation and use that client to
* execute the exchange.
*
- * @param elem
+ * @param elem the data to send (becomes the content of SOAP body)
* @return response
- * @throws AxisFault
+ * @throws AxisFault in case of error
* @see #createClient(QName)
*/
public OMElement sendReceive(OMElement elem) throws AxisFault {
@@ -507,9 +505,9 @@
* the exchange.
*
* @param operationQName name of operationQName to be invoked (non-<code>null</code>)
- * @param xmlPayload
- * @return response
- * @throws AxisFault
+ * @param xmlPayload the data to send (becomes the content of SOAP body)
+ * @return response OMElement
+ * @throws AxisFault in case of error
*/
public OMElement sendReceive(QName operationQName, OMElement xmlPayload)
throws AxisFault {
@@ -530,9 +528,9 @@
* create a client for the operation and use that client to execute the
* exchange.
*
- * @param elem
- * @param callback
- * @throws AxisFault
+ * @param elem the data to send (becomes the content of SOAP body)
+ * @param callback a Callback which will be notified upon completion
+ * @throws AxisFault in case of error
* @see #createClient(QName)
*/
public void sendReceiveNonBlocking(OMElement elem, Callback callback)
@@ -548,9 +546,9 @@
* exchange.
*
* @param operation name of operation to be invoked (non-<code>null</code>)
- * @param elem
- * @param callback
- * @throws AxisFault
+ * @param elem the data to send (becomes the content of SOAP body)
+ * @param callback a Callback which will be notified upon completion
+ * @throws AxisFault in case of error
* @see #createClient(QName)
*/
public void sendReceiveNonBlocking(QName operation, OMElement elem,
@@ -638,7 +636,7 @@
/**
* Add all configured headers to a SOAP envelope.
*
- * @param envelope
+ * @param envelope the SOAPEnvelope in which to write the headers
*/
public void addHeadersToEnvelope(SOAPEnvelope envelope) {
if (headers != null) {
@@ -655,7 +653,7 @@
*
* @param transport transport name (non-<code>null</code>)
* @return local endpoint
- * @throws AxisFault
+ * @throws AxisFault in case of error
*/
public EndpointReference getMyEPR(String transport) throws AxisFault {
return serviceContext.getMyEPR(transport);
@@ -673,7 +671,7 @@
/**
* Set the endpoint reference for the service.
*
- * @param targetEpr
+ * @param targetEpr the EPR this ServiceClient should target
*/
public void setTargetEPR(EndpointReference targetEpr) {
serviceContext.setTargetEPR(targetEpr);
@@ -682,6 +680,8 @@
/**
* Gets the last OperationContext
+ *
+ * @return the last OperationContext that was invoked by this ServiceClient
*/
public OperationContext getLastOperationContext() {
return serviceContext.getLastOperationContext();
@@ -689,6 +689,8 @@
/**
* Sets whether or not to cache the last OperationContext
+ *
+ * @param cachingOpContext true if we should hold onto the last active OperationContext
*/
public void setCachingOperationContext(boolean cachingOpContext) {
serviceContext.setCachingOperationContext(cachingOpContext);
@@ -714,7 +716,7 @@
* you're done using the client, in order to discard any associated
* resources.
*
- * @throws AxisFault
+ * @throws AxisFault in case of error
*/
public void cleanup() throws AxisFault {
// if a configuration context was created for this client there'll also
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
Re: svn commit: r534865 - in
/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client:
OperationClient.java ServiceClient.java
Posted by Deepal Jayasinghe <de...@opensource.lk>.
Hi Dims,
User can get the last operationContext from ServiceClient in both stub
and serviceClient case.
Thanks
Deepal
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
[axis2] Re: svn commit: r534865 - in
/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client:
OperationClient.java ServiceClient.java
Posted by Glen Daniels <gl...@thoughtcraft.com>.
[switching over to axis-dev and adding prefix]
Hi folks!
Deepal wrote:
>Why do you want to do such a thing ? , does anyone ask for a feature
>like this ?
>As I can see you are breaking Axis2 concepts.
Deepal, I'm not sure what you meant by "breaking Axis2 concepts" either?
Davanum Srinivas wrote:
> Is this for the Stub scenario where we automatically save the oc so
> that the user can get to it when the invocation is over?
Yes, but also for the DII scenario where you just use a ServiceClient or
OperationClient directly. The version Deepal and I put in before was
specifically for use in stubs, but I found that I needed the same
functionality in a DII test, so it makes much more sense to implement it
generically, where it should work for both Stubs and DII.
I actually put it in the wrong place - it shouldn't be in the
constructor, it should be in execute(), so that it really is "last
operation context executed" instead of "last operation context created".
As such I'm making execute() a final method in the abstract
OperationClient class, and renaming the abstract method executeImpl().
Just made this change, testing it now. I'll also make sure we have a
test or two for this.
I didn't find any references to setLastOperationContext() anywhere in
our source tree, including in the stub generation templates... Did the
stub-related version of this functionality disappear at some point?
(perhaps this is why that JIRA got filed)
Thanks,
--Glen
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: svn commit: r534865 - in
/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client:
OperationClient.java ServiceClient.java
Posted by Deepal Jayasinghe <de...@opensource.lk>.
Hi Dims,
User can get the last operationContext from ServiceClient in both stub
and serviceClient case.
Thanks
Deepal
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
Re: svn commit: r534865 - in /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client: OperationClient.java ServiceClient.java
Posted by Davanum Srinivas <da...@gmail.com>.
Deepal,
What "concept" is this? Where is it doc-ed?
Glen,
Is this for the Stub scenario where we automatically save the oc so
that the user can get to it when the invocation is over?
-- dims
On 5/3/07, Deepal Jayasinghe <de...@opensource.lk> wrote:
> Hi Glen,
>
> Why do you want to do such a thing ? , does anyone ask for a feature
> like this ?
> As I can see you are breaking Axis2 concepts :)
>
> In the meantime I can not understand from where we are going to end up
> with these changes.
>
>
> Thanks
> Deepal
>
> gdaniels@apache.org wrote:
>
> >Author: gdaniels
> >Date: Thu May 3 07:00:04 2007
> >New Revision: 534865
> >
> >URL: http://svn.apache.org/viewvc?view=rev&rev=534865
> >Log:
> >Always cache last operation context on the client if ServiceContext is configured that way.
> >
> >Clean up JavaDoc.
> >
> >Modified:
> > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
> > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
> >
> >Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
> >URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java?view=diff&rev=534865&r1=534864&r2=534865
> >==============================================================================
> >--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java (original)
> >+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java Thu May 3 07:00:04 2007
> >@@ -64,13 +64,16 @@
> > */
> > protected boolean completed;
> >
> >- protected OperationClient(AxisOperation axisOp, ServiceContext sc,
> >- Options options) {
> >+ protected OperationClient(AxisOperation axisOp, ServiceContext sc, Options options) {
> > this.axisOp = axisOp;
> > this.sc = sc;
> > this.options = new Options(options);
> >- this.completed = false;
> >- this.oc = ContextFactory.createOperationContext(axisOp, this.sc);
> >+ completed = false;
> >+ oc = ContextFactory.createOperationContext(axisOp, sc);
> >+
> >+ if (sc.isCachingOperationContext()) {
> >+ sc.setLastOperationContext(oc);
> >+ }
> > }
> >
> > /**
> >
> >Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
> >URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java?view=diff&rev=534865&r1=534864&r2=534865
> >==============================================================================
> >--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java (original)
> >+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java Thu May 3 07:00:04 2007
> >@@ -160,13 +160,13 @@
> >
> > /**
> > * This is WSDL4J based constructor to configure the Service Client/
> >- * We are going to make this policy aware
> >+ * TODO: make this policy aware
> > *
> >- * @param configContext
> >- * @param wsdl4jDefinition
> >- * @param wsdlServiceName
> >- * @param portName
> >- * @throws AxisFault
> >+ * @param configContext active ConfigurationContext
> >+ * @param wsdl4jDefinition the WSDL we're going to be using to configure ourselves
> >+ * @param wsdlServiceName QName of the WSDL service we'd like to access
> >+ * @param portName name of the WSDL port we'd like to access
> >+ * @throws AxisFault in case of error
> > */
> >
> > public ServiceClient(ConfigurationContext configContext, Definition wsdl4jDefinition,
> >@@ -223,7 +223,7 @@
> > * Create a service client by assuming an anonymous service and any other
> > * necessary information.
> > *
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > */
> > public ServiceClient() throws AxisFault {
> > this(null, null);
> >@@ -291,7 +291,7 @@
> > * each client, with the standard values for the client still used for any
> > * values not set in the override configuration.
> > *
> >- * @param overrideOptions
> >+ * @param overrideOptions the Options to use
> > */
> > public void setOverrideOptions(Options overrideOptions) {
> > this.overrideOptions = overrideOptions;
> >@@ -310,7 +310,7 @@
> > /**
> > * Engage a module for this service client.
> > *
> >- * @deprecate Please use String version instead
> >+ * @deprecated Please use String version instead
> > * @param moduleName name of the module to engage
> > * @throws AxisFault if something goes wrong
> > */
> >@@ -338,8 +338,8 @@
> > /**
> > * Disengage a module for this service client
> > *
> >- * @deprecate Please use String version instead
> >- * @param moduleName
> >+ * @deprecated Please use String version instead
> >+ * @param moduleName name of Module to disengage
> > */
> > public void disengageModule(QName moduleName) {
> > disengageModule(moduleName.getLocalPart());
> >@@ -348,7 +348,7 @@
> > /**
> > * Disengage a module for this service client
> > *
> >- * @param moduleName
> >+ * @param moduleName name of Module to disengage
> > */
> > public void disengageModule(String moduleName) {
> > AxisModule module = axisConfig.getModule(moduleName);
> >@@ -393,20 +393,18 @@
> >
> >
> > /**
> >- * Add a simple header consisting of some text (and a header name; duh) to
> >- * be sent with interactions.
> >+ * Add a simple header containing some text to be sent with interactions.
> > *
> >- * @param headerName
> >- * @param headerText
> >- * @throws AxisFault
> >+ * @param headerName name of header to add
> >+ * @param headerText text content for header
> >+ * @throws AxisFault in case of error
> > */
> > public void addStringHeader(QName headerName, String headerText) throws AxisFault {
> > if (headerName.getNamespaceURI() == null || "".equals(headerName.getNamespaceURI())) {
> > throw new AxisFault(
> >- "Failed to add string header , you have to have namespaceURI for the QName");
> >+ "Failed to add string header, you have to have namespaceURI for the QName");
> > }
> >- OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(
> >- headerName, null);
> >+ OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(headerName, null);
> > omElement.setText(headerText);
> > addHeader(omElement);
> > }
> >@@ -491,9 +489,9 @@
> > * can instead create a client for the operation and use that client to
> > * execute the exchange.
> > *
> >- * @param elem
> >+ * @param elem the data to send (becomes the content of SOAP body)
> > * @return response
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > * @see #createClient(QName)
> > */
> > public OMElement sendReceive(OMElement elem) throws AxisFault {
> >@@ -507,9 +505,9 @@
> > * the exchange.
> > *
> > * @param operationQName name of operationQName to be invoked (non-<code>null</code>)
> >- * @param xmlPayload
> >- * @return response
> >- * @throws AxisFault
> >+ * @param xmlPayload the data to send (becomes the content of SOAP body)
> >+ * @return response OMElement
> >+ * @throws AxisFault in case of error
> > */
> > public OMElement sendReceive(QName operationQName, OMElement xmlPayload)
> > throws AxisFault {
> >@@ -530,9 +528,9 @@
> > * create a client for the operation and use that client to execute the
> > * exchange.
> > *
> >- * @param elem
> >- * @param callback
> >- * @throws AxisFault
> >+ * @param elem the data to send (becomes the content of SOAP body)
> >+ * @param callback a Callback which will be notified upon completion
> >+ * @throws AxisFault in case of error
> > * @see #createClient(QName)
> > */
> > public void sendReceiveNonBlocking(OMElement elem, Callback callback)
> >@@ -548,9 +546,9 @@
> > * exchange.
> > *
> > * @param operation name of operation to be invoked (non-<code>null</code>)
> >- * @param elem
> >- * @param callback
> >- * @throws AxisFault
> >+ * @param elem the data to send (becomes the content of SOAP body)
> >+ * @param callback a Callback which will be notified upon completion
> >+ * @throws AxisFault in case of error
> > * @see #createClient(QName)
> > */
> > public void sendReceiveNonBlocking(QName operation, OMElement elem,
> >@@ -638,7 +636,7 @@
> > /**
> > * Add all configured headers to a SOAP envelope.
> > *
> >- * @param envelope
> >+ * @param envelope the SOAPEnvelope in which to write the headers
> > */
> > public void addHeadersToEnvelope(SOAPEnvelope envelope) {
> > if (headers != null) {
> >@@ -655,7 +653,7 @@
> > *
> > * @param transport transport name (non-<code>null</code>)
> > * @return local endpoint
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > */
> > public EndpointReference getMyEPR(String transport) throws AxisFault {
> > return serviceContext.getMyEPR(transport);
> >@@ -673,7 +671,7 @@
> > /**
> > * Set the endpoint reference for the service.
> > *
> >- * @param targetEpr
> >+ * @param targetEpr the EPR this ServiceClient should target
> > */
> > public void setTargetEPR(EndpointReference targetEpr) {
> > serviceContext.setTargetEPR(targetEpr);
> >@@ -682,6 +680,8 @@
> >
> > /**
> > * Gets the last OperationContext
> >+ *
> >+ * @return the last OperationContext that was invoked by this ServiceClient
> > */
> > public OperationContext getLastOperationContext() {
> > return serviceContext.getLastOperationContext();
> >@@ -689,6 +689,8 @@
> >
> > /**
> > * Sets whether or not to cache the last OperationContext
> >+ *
> >+ * @param cachingOpContext true if we should hold onto the last active OperationContext
> > */
> > public void setCachingOperationContext(boolean cachingOpContext) {
> > serviceContext.setCachingOperationContext(cachingOpContext);
> >@@ -714,7 +716,7 @@
> > * you're done using the client, in order to discard any associated
> > * resources.
> > *
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > */
> > public void cleanup() throws AxisFault {
> > // if a configuration context was created for this client there'll also
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> >For additional commands, e-mail: axis-cvs-help@ws.apache.org
> >
> >
> >
> >
> >
>
> --
> Thanks,
> Deepal
> ................................................................
> "The highest tower is built one brick at a time"
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
--
Davanum Srinivas :: http://davanum.wordpress.com
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
Re: svn commit: r534865 - in /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client: OperationClient.java ServiceClient.java
Posted by Davanum Srinivas <da...@gmail.com>.
Deepal,
What "concept" is this? Where is it doc-ed?
Glen,
Is this for the Stub scenario where we automatically save the oc so
that the user can get to it when the invocation is over?
-- dims
On 5/3/07, Deepal Jayasinghe <de...@opensource.lk> wrote:
> Hi Glen,
>
> Why do you want to do such a thing ? , does anyone ask for a feature
> like this ?
> As I can see you are breaking Axis2 concepts :)
>
> In the meantime I can not understand from where we are going to end up
> with these changes.
>
>
> Thanks
> Deepal
>
> gdaniels@apache.org wrote:
>
> >Author: gdaniels
> >Date: Thu May 3 07:00:04 2007
> >New Revision: 534865
> >
> >URL: http://svn.apache.org/viewvc?view=rev&rev=534865
> >Log:
> >Always cache last operation context on the client if ServiceContext is configured that way.
> >
> >Clean up JavaDoc.
> >
> >Modified:
> > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
> > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
> >
> >Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
> >URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java?view=diff&rev=534865&r1=534864&r2=534865
> >==============================================================================
> >--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java (original)
> >+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java Thu May 3 07:00:04 2007
> >@@ -64,13 +64,16 @@
> > */
> > protected boolean completed;
> >
> >- protected OperationClient(AxisOperation axisOp, ServiceContext sc,
> >- Options options) {
> >+ protected OperationClient(AxisOperation axisOp, ServiceContext sc, Options options) {
> > this.axisOp = axisOp;
> > this.sc = sc;
> > this.options = new Options(options);
> >- this.completed = false;
> >- this.oc = ContextFactory.createOperationContext(axisOp, this.sc);
> >+ completed = false;
> >+ oc = ContextFactory.createOperationContext(axisOp, sc);
> >+
> >+ if (sc.isCachingOperationContext()) {
> >+ sc.setLastOperationContext(oc);
> >+ }
> > }
> >
> > /**
> >
> >Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
> >URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java?view=diff&rev=534865&r1=534864&r2=534865
> >==============================================================================
> >--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java (original)
> >+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java Thu May 3 07:00:04 2007
> >@@ -160,13 +160,13 @@
> >
> > /**
> > * This is WSDL4J based constructor to configure the Service Client/
> >- * We are going to make this policy aware
> >+ * TODO: make this policy aware
> > *
> >- * @param configContext
> >- * @param wsdl4jDefinition
> >- * @param wsdlServiceName
> >- * @param portName
> >- * @throws AxisFault
> >+ * @param configContext active ConfigurationContext
> >+ * @param wsdl4jDefinition the WSDL we're going to be using to configure ourselves
> >+ * @param wsdlServiceName QName of the WSDL service we'd like to access
> >+ * @param portName name of the WSDL port we'd like to access
> >+ * @throws AxisFault in case of error
> > */
> >
> > public ServiceClient(ConfigurationContext configContext, Definition wsdl4jDefinition,
> >@@ -223,7 +223,7 @@
> > * Create a service client by assuming an anonymous service and any other
> > * necessary information.
> > *
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > */
> > public ServiceClient() throws AxisFault {
> > this(null, null);
> >@@ -291,7 +291,7 @@
> > * each client, with the standard values for the client still used for any
> > * values not set in the override configuration.
> > *
> >- * @param overrideOptions
> >+ * @param overrideOptions the Options to use
> > */
> > public void setOverrideOptions(Options overrideOptions) {
> > this.overrideOptions = overrideOptions;
> >@@ -310,7 +310,7 @@
> > /**
> > * Engage a module for this service client.
> > *
> >- * @deprecate Please use String version instead
> >+ * @deprecated Please use String version instead
> > * @param moduleName name of the module to engage
> > * @throws AxisFault if something goes wrong
> > */
> >@@ -338,8 +338,8 @@
> > /**
> > * Disengage a module for this service client
> > *
> >- * @deprecate Please use String version instead
> >- * @param moduleName
> >+ * @deprecated Please use String version instead
> >+ * @param moduleName name of Module to disengage
> > */
> > public void disengageModule(QName moduleName) {
> > disengageModule(moduleName.getLocalPart());
> >@@ -348,7 +348,7 @@
> > /**
> > * Disengage a module for this service client
> > *
> >- * @param moduleName
> >+ * @param moduleName name of Module to disengage
> > */
> > public void disengageModule(String moduleName) {
> > AxisModule module = axisConfig.getModule(moduleName);
> >@@ -393,20 +393,18 @@
> >
> >
> > /**
> >- * Add a simple header consisting of some text (and a header name; duh) to
> >- * be sent with interactions.
> >+ * Add a simple header containing some text to be sent with interactions.
> > *
> >- * @param headerName
> >- * @param headerText
> >- * @throws AxisFault
> >+ * @param headerName name of header to add
> >+ * @param headerText text content for header
> >+ * @throws AxisFault in case of error
> > */
> > public void addStringHeader(QName headerName, String headerText) throws AxisFault {
> > if (headerName.getNamespaceURI() == null || "".equals(headerName.getNamespaceURI())) {
> > throw new AxisFault(
> >- "Failed to add string header , you have to have namespaceURI for the QName");
> >+ "Failed to add string header, you have to have namespaceURI for the QName");
> > }
> >- OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(
> >- headerName, null);
> >+ OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(headerName, null);
> > omElement.setText(headerText);
> > addHeader(omElement);
> > }
> >@@ -491,9 +489,9 @@
> > * can instead create a client for the operation and use that client to
> > * execute the exchange.
> > *
> >- * @param elem
> >+ * @param elem the data to send (becomes the content of SOAP body)
> > * @return response
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > * @see #createClient(QName)
> > */
> > public OMElement sendReceive(OMElement elem) throws AxisFault {
> >@@ -507,9 +505,9 @@
> > * the exchange.
> > *
> > * @param operationQName name of operationQName to be invoked (non-<code>null</code>)
> >- * @param xmlPayload
> >- * @return response
> >- * @throws AxisFault
> >+ * @param xmlPayload the data to send (becomes the content of SOAP body)
> >+ * @return response OMElement
> >+ * @throws AxisFault in case of error
> > */
> > public OMElement sendReceive(QName operationQName, OMElement xmlPayload)
> > throws AxisFault {
> >@@ -530,9 +528,9 @@
> > * create a client for the operation and use that client to execute the
> > * exchange.
> > *
> >- * @param elem
> >- * @param callback
> >- * @throws AxisFault
> >+ * @param elem the data to send (becomes the content of SOAP body)
> >+ * @param callback a Callback which will be notified upon completion
> >+ * @throws AxisFault in case of error
> > * @see #createClient(QName)
> > */
> > public void sendReceiveNonBlocking(OMElement elem, Callback callback)
> >@@ -548,9 +546,9 @@
> > * exchange.
> > *
> > * @param operation name of operation to be invoked (non-<code>null</code>)
> >- * @param elem
> >- * @param callback
> >- * @throws AxisFault
> >+ * @param elem the data to send (becomes the content of SOAP body)
> >+ * @param callback a Callback which will be notified upon completion
> >+ * @throws AxisFault in case of error
> > * @see #createClient(QName)
> > */
> > public void sendReceiveNonBlocking(QName operation, OMElement elem,
> >@@ -638,7 +636,7 @@
> > /**
> > * Add all configured headers to a SOAP envelope.
> > *
> >- * @param envelope
> >+ * @param envelope the SOAPEnvelope in which to write the headers
> > */
> > public void addHeadersToEnvelope(SOAPEnvelope envelope) {
> > if (headers != null) {
> >@@ -655,7 +653,7 @@
> > *
> > * @param transport transport name (non-<code>null</code>)
> > * @return local endpoint
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > */
> > public EndpointReference getMyEPR(String transport) throws AxisFault {
> > return serviceContext.getMyEPR(transport);
> >@@ -673,7 +671,7 @@
> > /**
> > * Set the endpoint reference for the service.
> > *
> >- * @param targetEpr
> >+ * @param targetEpr the EPR this ServiceClient should target
> > */
> > public void setTargetEPR(EndpointReference targetEpr) {
> > serviceContext.setTargetEPR(targetEpr);
> >@@ -682,6 +680,8 @@
> >
> > /**
> > * Gets the last OperationContext
> >+ *
> >+ * @return the last OperationContext that was invoked by this ServiceClient
> > */
> > public OperationContext getLastOperationContext() {
> > return serviceContext.getLastOperationContext();
> >@@ -689,6 +689,8 @@
> >
> > /**
> > * Sets whether or not to cache the last OperationContext
> >+ *
> >+ * @param cachingOpContext true if we should hold onto the last active OperationContext
> > */
> > public void setCachingOperationContext(boolean cachingOpContext) {
> > serviceContext.setCachingOperationContext(cachingOpContext);
> >@@ -714,7 +716,7 @@
> > * you're done using the client, in order to discard any associated
> > * resources.
> > *
> >- * @throws AxisFault
> >+ * @throws AxisFault in case of error
> > */
> > public void cleanup() throws AxisFault {
> > // if a configuration context was created for this client there'll also
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> >For additional commands, e-mail: axis-cvs-help@ws.apache.org
> >
> >
> >
> >
> >
>
> --
> Thanks,
> Deepal
> ................................................................
> "The highest tower is built one brick at a time"
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
--
Davanum Srinivas :: http://davanum.wordpress.com
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
Re: svn commit: r534865 - in
/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client:
OperationClient.java ServiceClient.java
Posted by Deepal Jayasinghe <de...@opensource.lk>.
Hi Glen,
Why do you want to do such a thing ? , does anyone ask for a feature
like this ?
As I can see you are breaking Axis2 concepts :)
In the meantime I can not understand from where we are going to end up
with these changes.
Thanks
Deepal
gdaniels@apache.org wrote:
>Author: gdaniels
>Date: Thu May 3 07:00:04 2007
>New Revision: 534865
>
>URL: http://svn.apache.org/viewvc?view=rev&rev=534865
>Log:
>Always cache last operation context on the client if ServiceContext is configured that way.
>
>Clean up JavaDoc.
>
>Modified:
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
>
>Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
>URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java?view=diff&rev=534865&r1=534864&r2=534865
>==============================================================================
>--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java (original)
>+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java Thu May 3 07:00:04 2007
>@@ -64,13 +64,16 @@
> */
> protected boolean completed;
>
>- protected OperationClient(AxisOperation axisOp, ServiceContext sc,
>- Options options) {
>+ protected OperationClient(AxisOperation axisOp, ServiceContext sc, Options options) {
> this.axisOp = axisOp;
> this.sc = sc;
> this.options = new Options(options);
>- this.completed = false;
>- this.oc = ContextFactory.createOperationContext(axisOp, this.sc);
>+ completed = false;
>+ oc = ContextFactory.createOperationContext(axisOp, sc);
>+
>+ if (sc.isCachingOperationContext()) {
>+ sc.setLastOperationContext(oc);
>+ }
> }
>
> /**
>
>Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
>URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java?view=diff&rev=534865&r1=534864&r2=534865
>==============================================================================
>--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java (original)
>+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java Thu May 3 07:00:04 2007
>@@ -160,13 +160,13 @@
>
> /**
> * This is WSDL4J based constructor to configure the Service Client/
>- * We are going to make this policy aware
>+ * TODO: make this policy aware
> *
>- * @param configContext
>- * @param wsdl4jDefinition
>- * @param wsdlServiceName
>- * @param portName
>- * @throws AxisFault
>+ * @param configContext active ConfigurationContext
>+ * @param wsdl4jDefinition the WSDL we're going to be using to configure ourselves
>+ * @param wsdlServiceName QName of the WSDL service we'd like to access
>+ * @param portName name of the WSDL port we'd like to access
>+ * @throws AxisFault in case of error
> */
>
> public ServiceClient(ConfigurationContext configContext, Definition wsdl4jDefinition,
>@@ -223,7 +223,7 @@
> * Create a service client by assuming an anonymous service and any other
> * necessary information.
> *
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> */
> public ServiceClient() throws AxisFault {
> this(null, null);
>@@ -291,7 +291,7 @@
> * each client, with the standard values for the client still used for any
> * values not set in the override configuration.
> *
>- * @param overrideOptions
>+ * @param overrideOptions the Options to use
> */
> public void setOverrideOptions(Options overrideOptions) {
> this.overrideOptions = overrideOptions;
>@@ -310,7 +310,7 @@
> /**
> * Engage a module for this service client.
> *
>- * @deprecate Please use String version instead
>+ * @deprecated Please use String version instead
> * @param moduleName name of the module to engage
> * @throws AxisFault if something goes wrong
> */
>@@ -338,8 +338,8 @@
> /**
> * Disengage a module for this service client
> *
>- * @deprecate Please use String version instead
>- * @param moduleName
>+ * @deprecated Please use String version instead
>+ * @param moduleName name of Module to disengage
> */
> public void disengageModule(QName moduleName) {
> disengageModule(moduleName.getLocalPart());
>@@ -348,7 +348,7 @@
> /**
> * Disengage a module for this service client
> *
>- * @param moduleName
>+ * @param moduleName name of Module to disengage
> */
> public void disengageModule(String moduleName) {
> AxisModule module = axisConfig.getModule(moduleName);
>@@ -393,20 +393,18 @@
>
>
> /**
>- * Add a simple header consisting of some text (and a header name; duh) to
>- * be sent with interactions.
>+ * Add a simple header containing some text to be sent with interactions.
> *
>- * @param headerName
>- * @param headerText
>- * @throws AxisFault
>+ * @param headerName name of header to add
>+ * @param headerText text content for header
>+ * @throws AxisFault in case of error
> */
> public void addStringHeader(QName headerName, String headerText) throws AxisFault {
> if (headerName.getNamespaceURI() == null || "".equals(headerName.getNamespaceURI())) {
> throw new AxisFault(
>- "Failed to add string header , you have to have namespaceURI for the QName");
>+ "Failed to add string header, you have to have namespaceURI for the QName");
> }
>- OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(
>- headerName, null);
>+ OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(headerName, null);
> omElement.setText(headerText);
> addHeader(omElement);
> }
>@@ -491,9 +489,9 @@
> * can instead create a client for the operation and use that client to
> * execute the exchange.
> *
>- * @param elem
>+ * @param elem the data to send (becomes the content of SOAP body)
> * @return response
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> * @see #createClient(QName)
> */
> public OMElement sendReceive(OMElement elem) throws AxisFault {
>@@ -507,9 +505,9 @@
> * the exchange.
> *
> * @param operationQName name of operationQName to be invoked (non-<code>null</code>)
>- * @param xmlPayload
>- * @return response
>- * @throws AxisFault
>+ * @param xmlPayload the data to send (becomes the content of SOAP body)
>+ * @return response OMElement
>+ * @throws AxisFault in case of error
> */
> public OMElement sendReceive(QName operationQName, OMElement xmlPayload)
> throws AxisFault {
>@@ -530,9 +528,9 @@
> * create a client for the operation and use that client to execute the
> * exchange.
> *
>- * @param elem
>- * @param callback
>- * @throws AxisFault
>+ * @param elem the data to send (becomes the content of SOAP body)
>+ * @param callback a Callback which will be notified upon completion
>+ * @throws AxisFault in case of error
> * @see #createClient(QName)
> */
> public void sendReceiveNonBlocking(OMElement elem, Callback callback)
>@@ -548,9 +546,9 @@
> * exchange.
> *
> * @param operation name of operation to be invoked (non-<code>null</code>)
>- * @param elem
>- * @param callback
>- * @throws AxisFault
>+ * @param elem the data to send (becomes the content of SOAP body)
>+ * @param callback a Callback which will be notified upon completion
>+ * @throws AxisFault in case of error
> * @see #createClient(QName)
> */
> public void sendReceiveNonBlocking(QName operation, OMElement elem,
>@@ -638,7 +636,7 @@
> /**
> * Add all configured headers to a SOAP envelope.
> *
>- * @param envelope
>+ * @param envelope the SOAPEnvelope in which to write the headers
> */
> public void addHeadersToEnvelope(SOAPEnvelope envelope) {
> if (headers != null) {
>@@ -655,7 +653,7 @@
> *
> * @param transport transport name (non-<code>null</code>)
> * @return local endpoint
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> */
> public EndpointReference getMyEPR(String transport) throws AxisFault {
> return serviceContext.getMyEPR(transport);
>@@ -673,7 +671,7 @@
> /**
> * Set the endpoint reference for the service.
> *
>- * @param targetEpr
>+ * @param targetEpr the EPR this ServiceClient should target
> */
> public void setTargetEPR(EndpointReference targetEpr) {
> serviceContext.setTargetEPR(targetEpr);
>@@ -682,6 +680,8 @@
>
> /**
> * Gets the last OperationContext
>+ *
>+ * @return the last OperationContext that was invoked by this ServiceClient
> */
> public OperationContext getLastOperationContext() {
> return serviceContext.getLastOperationContext();
>@@ -689,6 +689,8 @@
>
> /**
> * Sets whether or not to cache the last OperationContext
>+ *
>+ * @param cachingOpContext true if we should hold onto the last active OperationContext
> */
> public void setCachingOperationContext(boolean cachingOpContext) {
> serviceContext.setCachingOperationContext(cachingOpContext);
>@@ -714,7 +716,7 @@
> * you're done using the client, in order to discard any associated
> * resources.
> *
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> */
> public void cleanup() throws AxisFault {
> // if a configuration context was created for this client there'll also
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
>For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
>
>
>
--
Thanks,
Deepal
................................................................
"The highest tower is built one brick at a time"
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
Re: svn commit: r534865 - in
/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client:
OperationClient.java ServiceClient.java
Posted by Deepal Jayasinghe <de...@opensource.lk>.
Hi Glen,
Why do you want to do such a thing ? , does anyone ask for a feature
like this ?
As I can see you are breaking Axis2 concepts :)
In the meantime I can not understand from where we are going to end up
with these changes.
Thanks
Deepal
gdaniels@apache.org wrote:
>Author: gdaniels
>Date: Thu May 3 07:00:04 2007
>New Revision: 534865
>
>URL: http://svn.apache.org/viewvc?view=rev&rev=534865
>Log:
>Always cache last operation context on the client if ServiceContext is configured that way.
>
>Clean up JavaDoc.
>
>Modified:
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
>
>Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java
>URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java?view=diff&rev=534865&r1=534864&r2=534865
>==============================================================================
>--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java (original)
>+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/OperationClient.java Thu May 3 07:00:04 2007
>@@ -64,13 +64,16 @@
> */
> protected boolean completed;
>
>- protected OperationClient(AxisOperation axisOp, ServiceContext sc,
>- Options options) {
>+ protected OperationClient(AxisOperation axisOp, ServiceContext sc, Options options) {
> this.axisOp = axisOp;
> this.sc = sc;
> this.options = new Options(options);
>- this.completed = false;
>- this.oc = ContextFactory.createOperationContext(axisOp, this.sc);
>+ completed = false;
>+ oc = ContextFactory.createOperationContext(axisOp, sc);
>+
>+ if (sc.isCachingOperationContext()) {
>+ sc.setLastOperationContext(oc);
>+ }
> }
>
> /**
>
>Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java
>URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java?view=diff&rev=534865&r1=534864&r2=534865
>==============================================================================
>--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java (original)
>+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java Thu May 3 07:00:04 2007
>@@ -160,13 +160,13 @@
>
> /**
> * This is WSDL4J based constructor to configure the Service Client/
>- * We are going to make this policy aware
>+ * TODO: make this policy aware
> *
>- * @param configContext
>- * @param wsdl4jDefinition
>- * @param wsdlServiceName
>- * @param portName
>- * @throws AxisFault
>+ * @param configContext active ConfigurationContext
>+ * @param wsdl4jDefinition the WSDL we're going to be using to configure ourselves
>+ * @param wsdlServiceName QName of the WSDL service we'd like to access
>+ * @param portName name of the WSDL port we'd like to access
>+ * @throws AxisFault in case of error
> */
>
> public ServiceClient(ConfigurationContext configContext, Definition wsdl4jDefinition,
>@@ -223,7 +223,7 @@
> * Create a service client by assuming an anonymous service and any other
> * necessary information.
> *
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> */
> public ServiceClient() throws AxisFault {
> this(null, null);
>@@ -291,7 +291,7 @@
> * each client, with the standard values for the client still used for any
> * values not set in the override configuration.
> *
>- * @param overrideOptions
>+ * @param overrideOptions the Options to use
> */
> public void setOverrideOptions(Options overrideOptions) {
> this.overrideOptions = overrideOptions;
>@@ -310,7 +310,7 @@
> /**
> * Engage a module for this service client.
> *
>- * @deprecate Please use String version instead
>+ * @deprecated Please use String version instead
> * @param moduleName name of the module to engage
> * @throws AxisFault if something goes wrong
> */
>@@ -338,8 +338,8 @@
> /**
> * Disengage a module for this service client
> *
>- * @deprecate Please use String version instead
>- * @param moduleName
>+ * @deprecated Please use String version instead
>+ * @param moduleName name of Module to disengage
> */
> public void disengageModule(QName moduleName) {
> disengageModule(moduleName.getLocalPart());
>@@ -348,7 +348,7 @@
> /**
> * Disengage a module for this service client
> *
>- * @param moduleName
>+ * @param moduleName name of Module to disengage
> */
> public void disengageModule(String moduleName) {
> AxisModule module = axisConfig.getModule(moduleName);
>@@ -393,20 +393,18 @@
>
>
> /**
>- * Add a simple header consisting of some text (and a header name; duh) to
>- * be sent with interactions.
>+ * Add a simple header containing some text to be sent with interactions.
> *
>- * @param headerName
>- * @param headerText
>- * @throws AxisFault
>+ * @param headerName name of header to add
>+ * @param headerText text content for header
>+ * @throws AxisFault in case of error
> */
> public void addStringHeader(QName headerName, String headerText) throws AxisFault {
> if (headerName.getNamespaceURI() == null || "".equals(headerName.getNamespaceURI())) {
> throw new AxisFault(
>- "Failed to add string header , you have to have namespaceURI for the QName");
>+ "Failed to add string header, you have to have namespaceURI for the QName");
> }
>- OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(
>- headerName, null);
>+ OMElement omElement = OMAbstractFactory.getOMFactory().createOMElement(headerName, null);
> omElement.setText(headerText);
> addHeader(omElement);
> }
>@@ -491,9 +489,9 @@
> * can instead create a client for the operation and use that client to
> * execute the exchange.
> *
>- * @param elem
>+ * @param elem the data to send (becomes the content of SOAP body)
> * @return response
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> * @see #createClient(QName)
> */
> public OMElement sendReceive(OMElement elem) throws AxisFault {
>@@ -507,9 +505,9 @@
> * the exchange.
> *
> * @param operationQName name of operationQName to be invoked (non-<code>null</code>)
>- * @param xmlPayload
>- * @return response
>- * @throws AxisFault
>+ * @param xmlPayload the data to send (becomes the content of SOAP body)
>+ * @return response OMElement
>+ * @throws AxisFault in case of error
> */
> public OMElement sendReceive(QName operationQName, OMElement xmlPayload)
> throws AxisFault {
>@@ -530,9 +528,9 @@
> * create a client for the operation and use that client to execute the
> * exchange.
> *
>- * @param elem
>- * @param callback
>- * @throws AxisFault
>+ * @param elem the data to send (becomes the content of SOAP body)
>+ * @param callback a Callback which will be notified upon completion
>+ * @throws AxisFault in case of error
> * @see #createClient(QName)
> */
> public void sendReceiveNonBlocking(OMElement elem, Callback callback)
>@@ -548,9 +546,9 @@
> * exchange.
> *
> * @param operation name of operation to be invoked (non-<code>null</code>)
>- * @param elem
>- * @param callback
>- * @throws AxisFault
>+ * @param elem the data to send (becomes the content of SOAP body)
>+ * @param callback a Callback which will be notified upon completion
>+ * @throws AxisFault in case of error
> * @see #createClient(QName)
> */
> public void sendReceiveNonBlocking(QName operation, OMElement elem,
>@@ -638,7 +636,7 @@
> /**
> * Add all configured headers to a SOAP envelope.
> *
>- * @param envelope
>+ * @param envelope the SOAPEnvelope in which to write the headers
> */
> public void addHeadersToEnvelope(SOAPEnvelope envelope) {
> if (headers != null) {
>@@ -655,7 +653,7 @@
> *
> * @param transport transport name (non-<code>null</code>)
> * @return local endpoint
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> */
> public EndpointReference getMyEPR(String transport) throws AxisFault {
> return serviceContext.getMyEPR(transport);
>@@ -673,7 +671,7 @@
> /**
> * Set the endpoint reference for the service.
> *
>- * @param targetEpr
>+ * @param targetEpr the EPR this ServiceClient should target
> */
> public void setTargetEPR(EndpointReference targetEpr) {
> serviceContext.setTargetEPR(targetEpr);
>@@ -682,6 +680,8 @@
>
> /**
> * Gets the last OperationContext
>+ *
>+ * @return the last OperationContext that was invoked by this ServiceClient
> */
> public OperationContext getLastOperationContext() {
> return serviceContext.getLastOperationContext();
>@@ -689,6 +689,8 @@
>
> /**
> * Sets whether or not to cache the last OperationContext
>+ *
>+ * @param cachingOpContext true if we should hold onto the last active OperationContext
> */
> public void setCachingOperationContext(boolean cachingOpContext) {
> serviceContext.setCachingOperationContext(cachingOpContext);
>@@ -714,7 +716,7 @@
> * you're done using the client, in order to discard any associated
> * resources.
> *
>- * @throws AxisFault
>+ * @throws AxisFault in case of error
> */
> public void cleanup() throws AxisFault {
> // if a configuration context was created for this client there'll also
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
>For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
>
>
>
--
Thanks,
Deepal
................................................................
"The highest tower is built one brick at a time"
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org