You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2019/06/12 13:32:26 UTC

[Bug 63498] New: [PATCH] NPE when calling getShapeName on XSLFTableCell

https://bz.apache.org/bugzilla/show_bug.cgi?id=63498

            Bug ID: 63498
           Summary: [PATCH] NPE when calling getShapeName on XSLFTableCell
           Product: POI
           Version: 4.0.x-dev
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSLF
          Assignee: dev@poi.apache.org
          Reporter: bmateusz@gmail.com
  Target Milestone: ---

Created attachment 36622
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36622&action=edit
Fix in XSLFShape.java and a test for it

Calling getCNvPr() on a TableCell returns null, then we call .getName() on it
without checking it.
Please see my patch and test case. I re-used table_test.pptx from the
test-data.

I'm not sure if returning null is correct, but still better than an NPE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 63498] [PATCH] NPE when calling getShapeName on XSLFTableCell

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63498

--- Comment #2 from PJ Fanning <fa...@yahoo.com> ---
Comment on attachment 36622
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36622
Fix in XSLFShape.java and a test for it

I added https://svn.apache.org/viewvc?view=revision&revision=1861172

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 63498] [PATCH] NPE when calling getShapeName on XSLFTableCell

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63498

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Dominik Stadler <do...@gmx.at> ---
This is fixed according to the previous comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 63498] [PATCH] NPE when calling getShapeName on XSLFTableCell

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63498

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
getShapeId id not null safe either

I'm not sure if it is meant to be valid to have XLSFShape that has no
underlying XMLBean shape object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org