[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

[mattyb149 <gi...@git.apache.org>]

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2138#discussion_r213045384
  
    --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHive3QLProcessor.java ---
    @@ -345,4 +348,22 @@ private void findTableNames(final Object obj, final Set<TableName> tableNames) {
             }
             return attributes;
         }
    +
    +    /**
    +     * Method to set the configured timeout on the statement to be executed
    +     * @param stmt statement to be executed
    +     * @param context process context to retrieve the configured value
    +     * @param flowFile flow file to evaluate expression language
    +     * @throws ProcessException exception in case configured value cannot be converted to an integer
    +     */
    +    protected void setTimeout(Statement stmt, ProcessContext context, FlowFile flowFile) throws ProcessException {
    --- End diff --
    
    Should we have a customValidate() for this like you added for AbstractHiveQLProcessor?


---