[jira] [Commented] (TINKERPOP-2591) Administrative adjustments to gremlint site

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391653#comment-17391653 ] 

ASF GitHub Bot commented on TINKERPOP-2591:
-------------------------------------------

spmallette commented on a change in pull request #1457:
URL: https://github.com/apache/tinkerpop/pull/1457#discussion_r681067643



##########
File path: docs/gremlint/package.json
##########
@@ -11,8 +11,10 @@
     "@types/node": "^12.0.0",
     "@types/react": "^16.9.53",
     "@types/react-dom": "^16.9.8",
-    "gremlint": "github:OyvindSabo/gremlint#master",
+    "customize-cra": "^1.0.0",
+    "gremlint": "^3.5.1",

Review comment:
       the only part in my mind where it gets tricky is with the release process, but i think you have it right. when we release 3.5.2 we dont' publish docs until after we'd have deployed that artifact to npm at which point we'd get the newer version to be live on the website at gremlint.com. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Administrative adjustments to gremlint site
> -------------------------------------------
>
>                 Key: TINKERPOP-2591
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2591
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: gremlint
>    Affects Versions: 3.5.1
>            Reporter: Stephen Mallette
>            Assignee: Øyvind Sæbø
>            Priority: Minor
>
> I presume that we can now pin the gremlint web site to a particular version of the gremlint library?
> https://github.com/apache/tinkerpop/blob/e1b377a98b97578017d8d815daed76e11b04c9f7/docs/gremlint/package.json#L14
> I guess we'd want the version to match the current version of the library? 3.5.2-alpha1 for the case of 3.5.2-SNAPSHOT? and then when we do {{bin/generate-home.sh}} we could swap that automatically to whatever the most recent version is published to npm? or i guess just setting it to ^3.5.1 will capture the latest in npm and the local alphas?
> I think it would be good if the gremlint web site had the version displayed in a footer along with the standard "Copyright © 2015-2021 The Apache Software Foundation." and perhaps a link back to the https?tinkerpop.apache.org site.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)