Mention of version # in release

[Jacques Le Roux <ja...@les7arts.com>]

I wonder if we should not put a mention of the version number in footer for releases ?

Jacques

Re: Mention of version # in release

[Jacopo Cappellato <ti...@sastau.it>]

Ah yes,

now I understand what you mean Jacques.
Yes, I think it is a good idea to add the version number to the 
footer.ftl template of the release branch.

Jacopo


Jacques Le Roux wrote:
> We could harcode at least the version number : release 4.0 in footer.ftl ?
> 
> Jacques
> 
> De : "Jacopo Cappellato" <ti...@sastau.it>
> 
> 
>> This would be cool... if we find a way of implementing this.
>>
>> Jacopo
>>
>> BJ Freeman wrote:
>>> +1
>>> Plus Svn release number.
>>>
>>> Jacques Le Roux sent the following on 10/6/2007 4:32 PM:
>>>> I wonder if we should not put a mention of the version number in footer for releases ?
>>>>
>>>> Jacques
>>>>
>>

Re: Mention of version # in release

[Jacques Le Roux <ja...@les7arts.com>]

We could harcode at least the version number : release 4.0 in footer.ftl ?

Jacques

De : "Jacopo Cappellato" <ti...@sastau.it>


> This would be cool... if we find a way of implementing this.
> 
> Jacopo
> 
> BJ Freeman wrote:
> > +1
> > Plus Svn release number.
> > 
> > Jacques Le Roux sent the following on 10/6/2007 4:32 PM:
> >> I wonder if we should not put a mention of the version number in footer for releases ?
> >>
> >> Jacques
> >>
> 
> 

Re: Mention of version # in release

[Jonathon -- Improov <jo...@improov.com>]

Jacques,

Say you are compiling and running an OFBiz instance that is also an SVN workspace.

You do your `ant build' and/or your `ant run-install'.

You then run the SubWCRev program (SVN util program) that writes the precise "working copy highest 
commit revision" into a footer .ftl file.

You start your compiled and data-seeded OFBiz.

And voila. You see the revision number in the footer of every page.

But when committing changes, remember to revert the changes to footer first.

That "working copy highest commit revision" number has no business residing in SVN. It should be 
part of your build process instead. But if you really want it committed into SVN, my suggested 
solution was given in a prior post.

If you're talking about the "release branch name" (eg 4.0 or 5.0), then I suppose it's alright to 
just commit that number into the branch.

Jonathon

Jacques Le Roux wrote:
> Jacopo, Adam and Jonathon,
> 
> I'm not sure you got my idea. It was really a simple one : to put the release version number into respective footer.ftl files ... We
> may also indicate when it's trunk and then maybe revision number would be helpful. Maybe this is only interesting for programmers
> and perhaps even more for commiters. But even in that case I still find it helpful (when testing for instance). OK, I'm a commiter
> and this will ease my life ;o)
> 
> Jacques
> 
> À : <de...@ofbiz.apache.org>
> 
> 
>> Well, ok, if you really want to do this in SVN, you can.
>>
>> But every commit must be preceded by writing that revision number into a "revision info file". And
>> that file must be checked in together with the other changes, part of the same change set.
>>
>> Hmm. Wait. You also have to "add 1" to the revision number in that file. Otherwise, you'll always
>> be 1 behind.
>>
>> Use a post-commit hook, or you'll get very wrong results when many committers commit at the same time.
>>
>> Jonathon
>>
>> Jonathon -- Improov wrote:
>>> You're talking about "working copy highest commit revision".
>>>
>>> See
>>> http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-subwcrev-keywords.html
>>> .
>>>
>>> By the way, I don't think it's a good idea to put that revision number
>>> into SVN. For those users checking out from SVN, let them manually
>>> insert that revision number themselves in their build processes.
>>>
>>> That revision number should go into a build, not into SVN.
>>>
>>> Jonathon
>>>
>>> Adam Heath wrote:
>>>> Jonathon -- Improov wrote:
>>>>> Keyword substitution in SVN. Same as in CVS.
>>>> Nope.  That will only show the latest version of *one* particular file.
>>>>  What we want is the latest version of *any* file in the checkout.
>>>>
>>>>
>>>
> 
> 

Re: Mention of version # in release

[Jacques Le Roux <ja...@les7arts.com>]

Jacopo, Adam and Jonathon,

I'm not sure you got my idea. It was really a simple one : to put the release version number into respective footer.ftl files ... We
may also indicate when it's trunk and then maybe revision number would be helpful. Maybe this is only interesting for programmers
and perhaps even more for commiters. But even in that case I still find it helpful (when testing for instance). OK, I'm a commiter
and this will ease my life ;o)

Jacques

À : <de...@ofbiz.apache.org>


> Well, ok, if you really want to do this in SVN, you can.
>
> But every commit must be preceded by writing that revision number into a "revision info file". And
> that file must be checked in together with the other changes, part of the same change set.
>
> Hmm. Wait. You also have to "add 1" to the revision number in that file. Otherwise, you'll always
> be 1 behind.
>
> Use a post-commit hook, or you'll get very wrong results when many committers commit at the same time.
>
> Jonathon
>
> Jonathon -- Improov wrote:
> > You're talking about "working copy highest commit revision".
> >
> > See
> > http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-subwcrev-keywords.html
> > .
> >
> > By the way, I don't think it's a good idea to put that revision number
> > into SVN. For those users checking out from SVN, let them manually
> > insert that revision number themselves in their build processes.
> >
> > That revision number should go into a build, not into SVN.
> >
> > Jonathon
> >
> > Adam Heath wrote:
> >> Jonathon -- Improov wrote:
> >>> Keyword substitution in SVN. Same as in CVS.
> >>
> >> Nope.  That will only show the latest version of *one* particular file.
> >>  What we want is the latest version of *any* file in the checkout.
> >>
> >>
> >
> >
>

Re: Mention of version # in release

[Jonathon -- Improov <jo...@improov.com>]

Well, ok, if you really want to do this in SVN, you can.

But every commit must be preceded by writing that revision number into a "revision info file". And 
that file must be checked in together with the other changes, part of the same change set.

Hmm. Wait. You also have to "add 1" to the revision number in that file. Otherwise, you'll always 
be 1 behind.

Use a post-commit hook, or you'll get very wrong results when many committers commit at the same time.

Jonathon

Jonathon -- Improov wrote:
> You're talking about "working copy highest commit revision".
> 
> See 
> http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-subwcrev-keywords.html 
> .
> 
> By the way, I don't think it's a good idea to put that revision number 
> into SVN. For those users checking out from SVN, let them manually 
> insert that revision number themselves in their build processes.
> 
> That revision number should go into a build, not into SVN.
> 
> Jonathon
> 
> Adam Heath wrote:
>> Jonathon -- Improov wrote:
>>> Keyword substitution in SVN. Same as in CVS.
>>
>> Nope.  That will only show the latest version of *one* particular file.
>>  What we want is the latest version of *any* file in the checkout.
>>
>>
> 
> 

Re: Mention of version # in release

[Jonathon -- Improov <jo...@improov.com>]

You're talking about "working copy highest commit revision".

See http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-subwcrev-keywords.html .

By the way, I don't think it's a good idea to put that revision number into SVN. For those users 
checking out from SVN, let them manually insert that revision number themselves in their build 
processes.

That revision number should go into a build, not into SVN.

Jonathon

Adam Heath wrote:
> Jonathon -- Improov wrote:
>> Keyword substitution in SVN. Same as in CVS.
> 
> Nope.  That will only show the latest version of *one* particular file.
>  What we want is the latest version of *any* file in the checkout.
> 
> 

Re: Mention of version # in release

[Adam Heath <do...@brainfood.com>]

Jonathon -- Improov wrote:
> Keyword substitution in SVN. Same as in CVS.

Nope.  That will only show the latest version of *one* particular file.
 What we want is the latest version of *any* file in the checkout.

Re: Mention of version # in release

[Jonathon -- Improov <jo...@improov.com>]

Keyword substitution in SVN. Same as in CVS.

Jonathon

Jacopo Cappellato wrote:
> This would be cool... if we find a way of implementing this.
> 
> Jacopo
> 
> BJ Freeman wrote:
>> +1
>> Plus Svn release number.
>>
>> Jacques Le Roux sent the following on 10/6/2007 4:32 PM:
>>> I wonder if we should not put a mention of the version number in 
>>> footer for releases ?
>>>
>>> Jacques
>>>
> 
> 
> 

Re: Mention of version # in release

[Jacopo Cappellato <ti...@sastau.it>]

This would be cool... if we find a way of implementing this.

Jacopo

BJ Freeman wrote:
> +1
> Plus Svn release number.
> 
> Jacques Le Roux sent the following on 10/6/2007 4:32 PM:
>> I wonder if we should not put a mention of the version number in footer for releases ?
>>
>> Jacques
>>

Re: Mention of version # in release

[BJ Freeman <bj...@free-man.net>]

+1
Plus Svn release number.

Jacques Le Roux sent the following on 10/6/2007 4:32 PM:
> I wonder if we should not put a mention of the version number in footer for releases ?
> 
> Jacques
>