You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Gavin Baumanis <ga...@thespidernet.com> on 2009/04/15 02:54:41 UTC
[PATCH] Update HACKING: Mutual respect / Evaluate the code, not the
coder.
As discussed at;
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496987
[[[
Update HACKING: Mutual respect / Evaluate the code, not the coder.
* www/hacking.html
Patch by: Gavin Baumanis <ga...@thespidernet.com>
Found by: gstein
]]]
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720169
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Jack Repenning <jr...@collab.net>.
On Apr 15, 2009, at 7:31 PM, Gavin 'Beau' Baumanis wrote:
> I did redo the patch in a follow up reply with a .diff file extension.
Ah, thanks, I didn't spot that.
> But the mail header reported the mime type of the attachment as being;
> Content-Type: application/octet-stream;
> x-unix-mode=0644;
> name="hacking.html.diff"
>
> So it would seem there is a MAC related (or perhaps simply a THIS
> MAC) issue with applying the correct MIME type to an attachment - as
> opposed to a tigris one.
Yes, I can confirm this (I use Apple Mail, too). I'm not sure if that
choice can be controlled by the user; I looked in some of the usual
places but came up dry.
> From my side, I'll just continue to use a .txt extension for any
> future patches as that seems to get an appropriate MIME type from
> "Apple Mail".
Good that you've found a working solution. Until someone can discover
how to influence Mail's "file name extension to MIME-type" mapping,
guess that'll have to be the answer.
-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1752516
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Jack,
On 16/04/2009, at 3:05 AM, Jack Repenning wrote:
<snip>
>
> I think that the original attempt was on the right track, and would
> have worked except for the unfortunate file-name typo. Am I wrong
> about that?
>
I did redo the patch in a follow up reply with a .diff file extension.
But the mail header reported the mime type of the attachment as being;
Content-Type: application/octet-stream;
x-unix-mode=0644;
name="hacking.html.diff"
So it would seem there is a MAC related (or perhaps simply a THIS MAC)
issue with applying the correct MIME type to an attachment - as
opposed to a tigris one.
From my side, I'll just continue to use a .txt extension for any
future patches as that seems to get an appropriate MIME type from
"Apple Mail".
Gavin.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1737473
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Jack Repenning <jr...@collab.net>.
On Apr 16, 2009, at 3:34 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> The attachment was also broken.
>
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1696155
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1698044
> http://svn.haxx.se/dev/archive-2009-04/0398.shtml
> http://svn.haxx.se/dev/archive-2009-04/0400.shtml
I see "the attachment created by our butt-head mailer, from text that
was originally just the message body, is broken."
I do not see "an attachment provided by the original sender is broken."
Are you seeing something different?
The current state and plan, as we understand it, is:
1. attachments provided by the originator are not munged
2. code review can be performed, if necessary by attaching the patch
rather than in-lining it
3. the fix to un-butt-head our ML is scheduled for the next _release_,
not _patch_ or _hot-fix_, because of the above two mitigators
I'm trying to explain the current state as clearly as possible; I'm
not arguing that the current state is right (God forbid!), or even
optimal; just explaining what it is. If the mitigators don't actually
happen, I want to know about that. If you think the mitigators aren't
good enough, I want to know about that as well.
-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1752317
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Arfrever Frehtes Taifersar Arahesis <Ar...@GMail.Com>.
2009/4/15 Greg Stein <gs...@gmail.com>:
> On Wed, Apr 15, 2009 at 21:12, Jack Repenning <jr...@collab.net> wrote:
>> On Apr 15, 2009, at 10:43 AM, Greg Stein wrote:
>>
>>> Stefan Sperling ran into a problem where the ML software munged his
>>> patch. Basically, it *rewrote* the message into something that was
>>> *incorrect*. It said "quoted-printable", but the content was wrong.
>>
>> I'm aware of quoted-printable botches over the message *body*, including
>> bodies that stupidly get converted to attachments, but not for things that
>> start out as attachments. I've worked some of the former cases with Stefan.
>> Can you link me to an example of the latter?
>
> Sorry... thought I mentioned the patch was *inline* ... it was not
> munging an attachment.
The attachment was also broken.
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1696155
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1698044
http://svn.haxx.se/dev/archive-2009-04/0398.shtml
http://svn.haxx.se/dev/archive-2009-04/0400.shtml
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1744758
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Greg Stein <gs...@gmail.com>.
On Wed, Apr 15, 2009 at 21:12, Jack Repenning <jr...@collab.net> wrote:
> On Apr 15, 2009, at 10:43 AM, Greg Stein wrote:
>
>> Stefan Sperling ran into a problem where the ML software munged his
>> patch. Basically, it *rewrote* the message into something that was
>> *incorrect*. It said "quoted-printable", but the content was wrong.
>
> I'm aware of quoted-printable botches over the message *body*, including
> bodies that stupidly get converted to attachments, but not for things that
> start out as attachments. I've worked some of the former cases with Stefan.
> Can you link me to an example of the latter?
Sorry... thought I mentioned the patch was *inline* ... it was not
munging an attachment.
>> Oh. And I'm still waiting to see a solution to correct the "this
>> message has been converted to an attachment". I thought you said that
>> was solved by making the message delivery a passthru, and the
>> conversion would only happen for he web UI. What happened to that?
>
> Still in the pipeline.
Thanks.
>...
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1732165
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Jack Repenning <jr...@collab.net>.
On Apr 15, 2009, at 10:43 AM, Greg Stein wrote:
> Stefan Sperling ran into a problem where the ML software munged his
> patch. Basically, it *rewrote* the message into something that was
> *incorrect*. It said "quoted-printable", but the content was wrong.
I'm aware of quoted-printable botches over the message *body*,
including bodies that stupidly get converted to attachments, but not
for things that start out as attachments. I've worked some of the
former cases with Stefan. Can you link me to an example of the latter?
> Oh. And I'm still waiting to see a solution to correct the "this
> message has been converted to an attachment". I thought you said that
> was solved by making the message delivery a passthru, and the
> conversion would only happen for he web UI. What happened to that?
Still in the pipeline. The argument (which you may have just refuted,
above) was that true attachments are safe, whatever butchery is
happening to the bodies, and so key uses such as patch-based change
review are doable. That, so the theory goes, lowers the priority of
the "don't convert bodies to attachments in the first place, you
ninny" fix to "next scheduled release." FYI: we basically have three
degrees of urgency:
- Next scheduled release (typically, quarterly)
- Next scheduled (typically, monthly)
- Hot fix (can turn around in hours)
To recap: in this thread, we've discussed (or veered very near) the
following problems:
- Dropping "inline" attachments entirely: PCN 65761. Scheduled fix:
5.3. Currently hot-fixed onto Tigris.
- Stupidly converting bodies to attachments: PCN 65675. Scheduled
fix: Patch 3.
- Quoted-printable botch of body text: PCN 65997. Scheduled fix: 5.3.
- Quoted-printable botch of things that actually started out as
attachments: that would be new; show me, show me!
Tigris is currently on 5.2.0 patch 2, with a hot fix or two. The slick
way to learn that requires administrative privs, but any user can use
the sneaky way: "View Source" on any Tigris page, and scan down for
this:
<meta name="version" content="5.2.0.140.2" />
That means "Release 5.2.0" and "patch 2." The "140" in the middle is
the build number of the final release of 5.2.0; that leaked into the
version number at some point, but isn't particularly helpful for any
deployed system (you'll never see any number other than 140 for a
deployed 5.2.0, for example).
-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1731263
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Greg Stein <gs...@gmail.com>.
On Wed, Apr 15, 2009 at 19:05, Jack Repenning <jr...@collab.net> wrote:
>...
> However, all that aside ... cataloging and assigning Tigris mail-list
> botches at the moment is considerably more "fun" than anyone really
> needs to have. I'm not sure how many, or precisely which, of the known
Stefan Sperling ran into a problem where the ML software munged his
patch. Basically, it *rewrote* the message into something that was
*incorrect*. It said "quoted-printable", but the content was wrong.
There was a URL with an ?something=16<more digits> in it which didn't
get quoted. Thus, MUAs interpreted it as: ...?something<0x16> <more
digits> ... which meant the URL terminated at the end of "something"
rather than including the digits. And (thus) the URL was totally
broken. He also said the patch contents, which were inline, was
monkeyed up incorrectly.
> problems have cropped up in the history of this thread, but it does
> seem to be a pretty impressive sampling. Hyrum is now reviewing, so he
> evidently got the text somehow, but "how" is not clear from the thread.
The "how" is to wait for the text file to come thru so that it is
visible. Or to just download the attachment and review it outside of
the MUA (which was the original pain point making the patch
"unreviewable").
> I think that the original attempt was on the right track, and would
> have worked except for the unfortunate file-name typo. Am I wrong
> about that?
Yah... that is probably the original problem with the mime type for
the attachment.
But there is still the double-quoting of the message body.
Oh. And I'm still waiting to see a solution to correct the "this
message has been converted to an attachment". I thought you said that
was solved by making the message delivery a passthru, and the
conversion would only happen for he web UI. What happened to that?
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1730551
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Jack Repenning <jr...@collab.net>.
On Apr 15, 2009, at 5:29 AM, Hyrum K. Wright wrote:
> Thanks for working with me on this, I can verify the patch was
> attached with the correct mime-type. Unfortunately, you've *also*
> run across the "tigris mailing list software is broken with
> attachments" bug, and your mail has been repeated twice below (but
> the attachment is still included, oddly enough). Copying jackr to
> let me know about it.
I'm startled, and a bit alarmed, to see Hyrum claim that his review
machinery depends on the sending MUA getting the MIME type right. I've
been fighting to get MUAs to support MIME properly for 20 years, and
was not aware that victory was close enough to make such a dependency
worth its weight. I would have guessed, rather, that the initial
problem was that the file name, perhaps because of a typo, had the
extension ".html-patch" (a dash where, perhaps, a dot would have
helped).
The report that the file works on the same machine where it was
created is considerably less help than one might suppose, as single
machines have many secret channels to tell themselves how to do it
right; somewhat fewer but still many exist among several machines of
the same type. What MIME is all about is extending this degree of
hintage into the heterogeneous world, such as Hyrum's (looks like
Linux?).
However, all that aside ... cataloging and assigning Tigris mail-list
botches at the moment is considerably more "fun" than anyone really
needs to have. I'm not sure how many, or precisely which, of the known
problems have cropped up in the history of this thread, but it does
seem to be a pretty impressive sampling. Hyrum is now reviewing, so he
evidently got the text somehow, but "how" is not clear from the thread.
I think that the original attempt was on the right track, and would
have worked except for the unfortunate file-name typo. Am I wrong
about that?
-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1730037
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Edmund Wong <ed...@kdtc.net>.
Hyrum K. Wright wrote:
> Gavin,
> Thanks for working with me on this, I can verify the patch was
> attached with the correct mime-type. Unfortunately, you've *also* run
> across the "tigris mailing list software is broken with attachments"
> bug, and your mail has been repeated twice below (but the attachment
> is still included, oddly enough). Copying jackr to let me know about
> it.
Hi Hyrum,
PMJI, but thanks for the clarification. I was
meaning to ask that question on why I was getting
his message repeated.
Edmund
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1727129
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Gavin,
Thanks for working with me on this, I can verify the patch was
attached with the correct mime-type. Unfortunately, you've *also* run
across the "tigris mailing list software is broken with attachments"
bug, and your mail has been repeated twice below (but the attachment
is still included, oddly enough). Copying jackr to let me know about
it.
-Hyrum
On Apr 14, 2009, at 11:54 PM, Gavin Baumanis wrote:
> Hi Hyrum,
>
> I'm obviously doing something incorrectly... but not too sure what
> that is.
>
> The file *is* plain text;
> created with;
>
> svn diff www/hacking.html > hacking.html.diff
>
> The file opens correctly on my Mac.
> Whether I use VI or (Mac's) TextEdit.app application.
>
> And while assumption *IS* the mother of of stuff-ups - I have
> associated both of those file extensions with TextEdit.app and thusly
> assumed that specifying .patch or .diff would be sufficient to ensure
> the correct MIME type was applied to the attachment.
>
> Anyway, here it is again - with a TXT extension.
> In a an email to myself, the header reads;
>
> Content-Disposition: attachment;
> filename=hacking.html.txt
> Content-Type: text/plain;
> x-unix-mode=0644;
> name="hacking.html.txt"
> Content-Transfer-Encoding: 7bit
>
> Hopefully this is sufficient - otherwise I might need some help from a
> MAC savvy list member.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1721547
> <hacking.html.txt>Hi Hyrum,
>
> I'm obviously doing something incorrectly... but not too sure what
> that is.
>
> The file *is* plain text;
> created with;
>
> svn diff www/hacking.html > hacking.html.diff
>
> The file opens correctly on my Mac.
> Whether I use VI or (Mac's) TextEdit.app application.
>
> And while assumption *IS* the mother of of stuff-ups - I have
> associated both of those file extensions with TextEdit.app and thusly
> assumed that specifying .patch or .diff would be sufficient to ensure
> the correct MIME type was applied to the attachment.
>
> Anyway, here it is again - with a TXT extension.
> In a an email to myself, the header reads;
>
> Content-Disposition: attachment;
> filename=hacking.html.txt
> Content-Type: text/plain;
> x-unix-mode=0644;
> name="hacking.html.txt"
> Content-Transfer-Encoding: 7bit
>
> Hopefully this is sufficient - otherwise I might need some help from a
> MAC savvy list member.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1721547
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1726546
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Logged as issue #3409.
Gavin.
On 24/04/2009, at 11:56 AM, Gavin Baumanis wrote:
> Ping.
> The updated patch has not received any comments.
>
> Gavin.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1884910
> <hacking.html.txt>Ping.
> The updated patch has not received any comments.
>
> Gavin.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1884910
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2013262
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Ping.
The updated patch has not received any comments.
Gavin.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1884910
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Hyrum,
Thanks for the review.
I have re-attached the patch with your suggested changes.
Gavin.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1739027
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Now reviewing the actual change...
On Apr 14, 2009, at 11:54 PM, Gavin Baumanis wrote:
> Hi Hyrum,
>
> I'm obviously doing something incorrectly... but not too sure what
> that is.
>
> The file *is* plain text;
> created with;
>
> svn diff www/hacking.html > hacking.html.diff
>
> The file opens correctly on my Mac.
> Whether I use VI or (Mac's) TextEdit.app application.
>
> And while assumption *IS* the mother of of stuff-ups - I have
> associated both of those file extensions with TextEdit.app and thusly
> assumed that specifying .patch or .diff would be sufficient to ensure
> the correct MIME type was applied to the attachment.
>
> Anyway, here it is again - with a TXT extension.
> In a an email to myself, the header reads;
>
> Content-Disposition: attachment;
> filename=hacking.html.txt
> Content-Type: text/plain;
> x-unix-mode=0644;
> name="hacking.html.txt"
> Content-Transfer-Encoding: 7bit
>
> Hopefully this is sufficient - otherwise I might need some help from a
> MAC savvy list member.
> Index: hacking.html
> ===================================================================
> --- hacking.html (revision 37267)
> +++ hacking.html (working copy)
> @@ -139,6 +139,20 @@
> >http://subversion.tigris.org/servlets/
ProjectMailingListList</a>
> in the description for the svn-breakage list.</p>
>
> +<p>Finally, despite the online nature of the subversion project /
community it is
Subversion should be capitalized, and I would pick either "project" or
"community", not both.
> +important to realise that there are <em>real</em> people at the
end of all
"realize", says my anglo-centric spell-o-matic.
> +contributions. Ensure that you treat all other community members
in a
> +manner to which you would expect to be treated yourself.</p>
> +
> +<p>When performing a review of a contribution ensure that your
review is
> +of the contribution and not the contributor.</p>
> +
> +<p>Simply;</p>
^
colon, not semi-colon
> +<ul>
> +<li><p>Treat everyone with respect,</p></li>
> +<li><p>Do not excessively annoy another,</p></li>
> +<li><p>Do not allow yourself to be excessively annoyed.</p></li>
> +</ul>
> </div>
And I'd use consistent '.' at the end of each item in the bulleted list.
Those are all grammar nits, maybe not even worth mentioning. The idea
of the patch is good, though.
-Hyrum
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1727689
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Hyrum,
I'm obviously doing something incorrectly... but not too sure what
that is.
The file *is* plain text;
created with;
svn diff www/hacking.html > hacking.html.diff
The file opens correctly on my Mac.
Whether I use VI or (Mac's) TextEdit.app application.
And while assumption *IS* the mother of of stuff-ups - I have
associated both of those file extensions with TextEdit.app and thusly
assumed that specifying .patch or .diff would be sufficient to ensure
the correct MIME type was applied to the attachment.
Anyway, here it is again - with a TXT extension.
In a an email to myself, the header reads;
Content-Disposition: attachment;
filename=hacking.html.txt
Content-Type: text/plain;
x-unix-mode=0644;
name="hacking.html.txt"
Content-Transfer-Encoding: 7bit
Hopefully this is sufficient - otherwise I might need some help from a
MAC savvy list member.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1721547
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Sorry to break it to you, but the patch still doesn't have correct
mime-type. From your mail:
Content-Disposition: attachment;
filename=hacking.html.diff
Content-Type: application/octet-stream;
name=hacking.html.diff;
x-unix-mode=0644
(I'm not trying to go an be all pedantic about this. I would actually
like to review the patch, but the mime-type confusion presents a very
real barrier to that. My reader won't display something with a binary
mime-type inline, meaning that reviewing the patch is more hassle than
it's worth.)
-Hyrum
On Apr 14, 2009, at 11:05 PM, Gavin 'Beau' Baumanis wrote:
> Of course...
>
> How nice of the PM to submit a patch inappropriately!
> Would the excuse it was meant to be .patch (not -patch) work for
> you?? :D
>
> <hacking.html.diff>
>
>
>
> On 15/04/2009, at 1:27 PM, Hyrum K. Wright wrote:
>
>> Can we have the patch attached using one of the suggested mime-types
>> [1]? :P
>>
>> [1] text/x-diff, text/x-patch, or text/plain
>>
>> On Apr 14, 2009, at 9:54 PM, Gavin Baumanis wrote:
>>
>>> As discussed at;
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496987
>>>
>>> [[[
>>> Update HACKING: Mutual respect / Evaluate the code, not the coder.
>>>
>>> * www/hacking.html
>>>
>>> Patch by: Gavin Baumanis <ga...@thespidernet.com>
>>> Found by: gstein
>>> ]]]
>>>
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720169
>>> <hacking.html-patch>As discussed at;
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496987
>>>
>>> [[[
>>> Update HACKING: Mutual respect / Evaluate the code, not the coder.
>>>
>>> * www/hacking.html
>>>
>>> Patch by: Gavin Baumanis <ga...@thespidernet.com>
>>> Found by: gstein
>>> ]]]
>>>
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720169
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720557
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1721171
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Of course...
How nice of the PM to submit a patch inappropriately!
Would the excuse it was meant to be .patch (not -patch) work for
you?? :D
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1721054
Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not
the coder.
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Can we have the patch attached using one of the suggested mime-types
[1]? :P
[1] text/x-diff, text/x-patch, or text/plain
On Apr 14, 2009, at 9:54 PM, Gavin Baumanis wrote:
> As discussed at;
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496987
>
> [[[
> Update HACKING: Mutual respect / Evaluate the code, not the coder.
>
> * www/hacking.html
>
> Patch by: Gavin Baumanis <ga...@thespidernet.com>
> Found by: gstein
> ]]]
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720169
> <hacking.html-patch>As discussed at;
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496987
>
> [[[
> Update HACKING: Mutual respect / Evaluate the code, not the coder.
>
> * www/hacking.html
>
> Patch by: Gavin Baumanis <ga...@thespidernet.com>
> Found by: gstein
> ]]]
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720169
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720557